<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189370] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189370">189370</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2015-09-04 12:24:55 -0700 (Fri, 04 Sep 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>swipe-start-hysteresis-failures is flaky
https://bugs.webkit.org/show_bug.cgi?id=148809

Reviewed by Alexey Proskuryakov.

* swipe/swipe-start-hysteresis-failures.html:
* swipe/swipe-start-hysteresis-failures-expected.txt:
Instead of depending on the specific timing of didStartSwipe vs. the events
in this case, just make sure we hit it by the time the test finishes.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsswipeswipestarthysteresisfailuresexpectedtxt">trunk/LayoutTests/swipe/swipe-start-hysteresis-failures-expected.txt</a></li>
<li><a href="#trunkLayoutTestsswipeswipestarthysteresisfailureshtml">trunk/LayoutTests/swipe/swipe-start-hysteresis-failures.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189369 => 189370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2015-09-04 19:14:36 UTC (rev 189369)
+++ trunk/LayoutTests/ChangeLog        2015-09-04 19:24:55 UTC (rev 189370)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-09-04  Tim Horton  &lt;timothy_horton@apple.com&gt;
+
+        swipe-start-hysteresis-failures is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=148809
+
+        Reviewed by Alexey Proskuryakov.
+
+        * swipe/swipe-start-hysteresis-failures.html:
+        * swipe/swipe-start-hysteresis-failures-expected.txt:
+        Instead of depending on the specific timing of didStartSwipe vs. the events
+        in this case, just make sure we hit it by the time the test finishes.
+
</ins><span class="cx"> 2015-09-04  Alexey Proskuryakov  &lt;ap@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Skip newly imported IndexedDB test on iOS WebKit1, because IndexedDB only works with WebKit2.
</span></span></pre></div>
<a id="trunkLayoutTestsswipeswipestarthysteresisfailuresexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/swipe/swipe-start-hysteresis-failures-expected.txt (189369 => 189370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/swipe/swipe-start-hysteresis-failures-expected.txt        2015-09-04 19:14:36 UTC (rev 189369)
+++ trunk/LayoutTests/swipe/swipe-start-hysteresis-failures-expected.txt        2015-09-04 19:24:55 UTC (rev 189370)
</span><span class="lines">@@ -17,7 +17,6 @@
</span><span class="cx"> swipe event (delta 0 0, phase 'maybegin')
</span><span class="cx"> scroll event (delta 3 1, phase 'began')
</span><span class="cx"> scroll event (delta 0 0, phase 'changed')
</span><del>-didBeginSwipe
</del><span class="cx"> scroll event (delta 0 0, phase 'ended')
</span><span class="cx"> swipe event (delta 0 0, phase 'ended')
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsswipeswipestarthysteresisfailureshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/swipe/swipe-start-hysteresis-failures.html (189369 => 189370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/swipe/swipe-start-hysteresis-failures.html        2015-09-04 19:14:36 UTC (rev 189369)
+++ trunk/LayoutTests/swipe/swipe-start-hysteresis-failures.html        2015-09-04 19:24:55 UTC (rev 189370)
</span><span class="lines">@@ -59,14 +59,15 @@
</span><span class="cx"> {
</span><span class="cx">     // Swap in a different callback that makes sure we *do* reach didBeginSwipe.
</span><span class="cx">     testRunner.clearTestRunnerCallbacks();
</span><ins>+    var sawDidBeginSwipe = false;
</ins><span class="cx">     testRunner.installDidBeginSwipeCallback(function () {
</span><del>-        log(&quot;didBeginSwipe&quot;);
-
</del><ins>+        sawDidBeginSwipe = true;
</ins><span class="cx">         // Need a swipe-end event to clean up.
</span><span class="cx">         eventQueue.enqueueSwipeEvent(0, 0, 'ended');
</span><span class="cx">     });
</span><span class="cx"> 
</span><span class="cx">     testRunner.installDidRemoveSwipeSnapshotCallback(function () {
</span><ins>+        shouldBe(true, sawDidBeginSwipe, &quot;The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.&quot;)
</ins><span class="cx">         testComplete();
</span><span class="cx">     });
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>