<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189401] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189401">189401</a></dd>
<dt>Author</dt> <dd>eric.carlson@apple.com</dd>
<dt>Date</dt> <dd>2015-09-04 16:50:17 -0700 (Fri, 04 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[mediacontrols] Test AirPlay picker button
https://bugs.webkit.org/show_bug.cgi?id=148836
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/controls/airplay-picker.html
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.getCurrentControlsStatus.elements.forEach.):
(Controller.prototype.getCurrentControlsStatus):
LayoutTests:
* media/controls/airplay-picker-expected.txt: New test.
* media/controls/airplay-picker.html: New results.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediacontrolsairplaypickerexpectedtxt">trunk/LayoutTests/media/controls/airplay-picker-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediacontrolsairplaypickerhtml">trunk/LayoutTests/media/controls/airplay-picker.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189400 => 189401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-04 23:48:58 UTC (rev 189400)
+++ trunk/LayoutTests/ChangeLog 2015-09-04 23:50:17 UTC (rev 189401)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-09-04 Eric Carlson <eric.carlson@apple.com>
+
+ [mediacontrols] Test AirPlay picker button
+ https://bugs.webkit.org/show_bug.cgi?id=148836
+
+ Reviewed by Dean Jackson.
+
+ * media/controls/airplay-picker-expected.txt: New test.
+ * media/controls/airplay-picker.html: New results.
+
</ins><span class="cx"> 2015-09-04 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> Should have a test to make sure links don't navigate after a cancelled force
</span></span></pre></div>
<a id="trunkLayoutTestsmediacontrolsairplaypickerexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/controls/airplay-picker-expected.txt (0 => 189401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/controls/airplay-picker-expected.txt (rev 0)
+++ trunk/LayoutTests/media/controls/airplay-picker-expected.txt 2015-09-04 23:50:17 UTC (rev 189401)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+This tests for the wireless device picker icon.
+
+This test only runs in DRT!
+
+
+EVENT: canplaythrough
+PASS: We are using the apple idiom
+
+Get the wireless device picker button
+
+PASS: Name is 'AppleTV Device Picker'
+PASS: Has hidden class
+PASS: CSS display: none
+PASS: Aria label is 'Choose Wireless Display'
+
+Testing finished.
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediacontrolsairplaypickerhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/controls/airplay-picker.html (0 => 189401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/controls/airplay-picker.html (rev 0)
+++ trunk/LayoutTests/media/controls/airplay-picker.html 2015-09-04 23:50:17 UTC (rev 189401)
</span><span class="lines">@@ -0,0 +1,47 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <script src="../media-file.js"></script>
+ <script src="controls-test-helpers.js"></script>
+ <script>
+ var tester = new ControlsTest()
+ .whenReady(runTests)
+ .start();
+
+ function runTests()
+ {
+ var currentState = tester.currentState;
+ tester.test("We are using the apple idiom")
+ .value(currentState.idiom)
+ .isEqualTo("apple");
+
+ tester.startNewSection("Get the wireless device picker button");
+ var statusState = tester.stateForControlsElement("AppleTV Device Picker");
+
+ tester.test("Name is 'AppleTV Device Picker'")
+ .value(statusState.name)
+ .isEqualTo("AppleTV Device Picker");
+
+ tester.test("Has hidden class")
+ .value(statusState.className)
+ .isEqualTo("hidden");
+
+ tester.test("CSS display: none")
+ .value(statusState.computedStyle.display)
+ .isEqualTo("none");
+
+ tester.test("Aria label is 'Choose Wireless Display'")
+ .value(statusState.ariaLabel)
+ .isEqualTo("Choose Wireless Display");
+
+ tester.end();
+ }
+
+ </script>
+ </head>
+ <body>
+ <p>This tests for the wireless device picker icon.</p>
+ <p>This test only runs in DRT!</p>
+ <video controls></video>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189400 => 189401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-04 23:48:58 UTC (rev 189400)
+++ trunk/Source/WebCore/ChangeLog 2015-09-04 23:50:17 UTC (rev 189401)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-09-04 Eric Carlson <eric.carlson@apple.com>
+
+ [mediacontrols] Test AirPlay picker button
+ https://bugs.webkit.org/show_bug.cgi?id=148836
+
+ Reviewed by Dean Jackson.
+
+ Test: media/controls/airplay-picker.html
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.getCurrentControlsStatus.elements.forEach.):
+ (Controller.prototype.getCurrentControlsStatus):
+
</ins><span class="cx"> 2015-09-04 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> dispatchEvent() should throw an InvalidStateError if the event's initialized flag is not set
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (189400 => 189401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-09-04 23:48:58 UTC (rev 189400)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-09-04 23:50:17 UTC (rev 189401)
</span><span class="lines">@@ -2132,7 +2132,13 @@
</span><span class="cx"> {
</span><span class="cx"> name: "Fullscreen Button",
</span><span class="cx"> object: this.controls.fullscreenButton
</span><del>- }
</del><ins>+ },
+ {
+ name: "AppleTV Device Picker",
+ object: this.controls.wirelessTargetPicker,
+ styleValues: ["display"],
+ extraProperties: ["hidden"],
+ },
</ins><span class="cx"> ];
</span><span class="cx">
</span><span class="cx"> elements.forEach(function (element) {
</span><span class="lines">@@ -2150,6 +2156,7 @@
</span><span class="cx">
</span><span class="cx"> element.bounds = obj.getBoundingClientRect();
</span><span class="cx"> element.className = obj.className;
</span><ins>+ element.ariaLabel = obj.getAttribute('aria-label');
</ins><span class="cx">
</span><span class="cx"> if (element.extraProperties) {
</span><span class="cx"> element.extraProperties.forEach(function (property) {
</span></span></pre>
</div>
</div>
</body>
</html>