<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189250] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189250">189250</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-02 10:06:15 -0700 (Wed, 02 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>http/tests/navigation/anchor-frames-same-origin.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=148690
Reviewed by Zalan Bujtas.
This is a temporary workaround for Bug 148690, until we have time
to investigate why scroll propagation does not work properly if
the frame is not already layed out when we scroll to the anchor.
This change updates the test to force a layout in the grandchild
frame before we scroll to the anchor. With this change, the test
is consistently passing when run on its own or after others.
* http/tests/navigation/resources/grandchild-with-anchor.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationresourcesgrandchildwithanchorhtml">trunk/LayoutTests/http/tests/navigation/resources/grandchild-with-anchor.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189249 => 189250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-02 16:56:15 UTC (rev 189249)
+++ trunk/LayoutTests/ChangeLog 2015-09-02 17:06:15 UTC (rev 189250)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-09-02 Chris Dumez <cdumez@apple.com>
+
+ http/tests/navigation/anchor-frames-same-origin.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=148690
+
+ Reviewed by Zalan Bujtas.
+
+ This is a temporary workaround for Bug 148690, until we have time
+ to investigate why scroll propagation does not work properly if
+ the frame is not already layed out when we scroll to the anchor.
+
+ This change updates the test to force a layout in the grandchild
+ frame before we scroll to the anchor. With this change, the test
+ is consistently passing when run on its own or after others.
+
+ * http/tests/navigation/resources/grandchild-with-anchor.html:
+
</ins><span class="cx"> 2015-09-02 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r189241.
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationresourcesgrandchildwithanchorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/navigation/resources/grandchild-with-anchor.html (189249 => 189250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/resources/grandchild-with-anchor.html 2015-09-02 16:56:15 UTC (rev 189249)
+++ trunk/LayoutTests/http/tests/navigation/resources/grandchild-with-anchor.html 2015-09-02 17:06:15 UTC (rev 189250)
</span><span class="lines">@@ -5,5 +5,10 @@
</span><span class="cx"> <!-- Spacer to make sure that the named anchor below requires scrolling -->
</span><span class="cx"> </div>
</span><span class="cx"> <a name="anchor1">This is an anchor point named "anchor1"</a>.
</span><ins>+<script>
+// Temporary workaround for https://bugs.webkit.org/show_bug.cgi?id=148690.
+// Make sure layout is done before we scroll to the anchor.
+document.body.offsetHeight;
+</script>
</ins><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre>
</div>
</div>
</body>
</html>