<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189243] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189243">189243</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-01 19:31:37 -0700 (Tue, 01 Sep 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Rename ShadowRoot::hostElement to shadowRoot::host to match the latest spec
https://bugs.webkit.org/show_bug.cgi?id=148694

Address the review comments by Chris.

* dom/Element.cpp:
(WebCore::Element::removeShadowRoot):
* dom/Node.cpp:
(WebCore::Node::shadowHost):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
* dom/ShadowRoot.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#trunkSourceWebCoredomShadowRootcpp">trunk/Source/WebCore/dom/ShadowRoot.cpp</a></li>
<li><a href="#trunkSourceWebCoredomShadowRooth">trunk/Source/WebCore/dom/ShadowRoot.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189242 => 189243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-09-02 01:56:59 UTC (rev 189242)
+++ trunk/Source/WebCore/ChangeLog        2015-09-02 02:31:37 UTC (rev 189243)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-09-01  Ryosuke Niwa  &lt;rniwa@webkit.org&gt;
+
+        Rename ShadowRoot::hostElement to shadowRoot::host to match the latest spec
+        https://bugs.webkit.org/show_bug.cgi?id=148694
+
+        Address the review comments by Chris.
+
+        * dom/Element.cpp:
+        (WebCore::Element::removeShadowRoot):
+        * dom/Node.cpp:
+        (WebCore::Node::shadowHost):
+        * dom/ShadowRoot.cpp:
+        (WebCore::ShadowRoot::ShadowRoot):
+        * dom/ShadowRoot.h:
+
</ins><span class="cx"> 2015-09-01  Zalan Bujtas  &lt;zalan@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Recompute maximum outline size only when outline changes.
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (189242 => 189243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp        2015-09-02 01:56:59 UTC (rev 189242)
+++ trunk/Source/WebCore/dom/Element.cpp        2015-09-02 02:31:37 UTC (rev 189243)
</span><span class="lines">@@ -1660,7 +1660,7 @@
</span><span class="cx"> 
</span><span class="cx">     elementRareData()-&gt;clearShadowRoot();
</span><span class="cx"> 
</span><del>-    oldRoot-&gt;setHost(0);
</del><ins>+    oldRoot-&gt;setHost(nullptr);
</ins><span class="cx">     oldRoot-&gt;setParentTreeScope(&amp;document());
</span><span class="cx"> 
</span><span class="cx">     ChildNodeRemovalNotifier(*this).notify(*oldRoot);
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (189242 => 189243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp        2015-09-02 01:56:59 UTC (rev 189242)
+++ trunk/Source/WebCore/dom/Node.cpp        2015-09-02 02:31:37 UTC (rev 189243)
</span><span class="lines">@@ -1035,7 +1035,7 @@
</span><span class="cx"> {
</span><span class="cx">     if (ShadowRoot* root = containingShadowRoot())
</span><span class="cx">         return root-&gt;host();
</span><del>-    return 0;
</del><ins>+    return nullptr;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> Node* Node::deprecatedShadowAncestorNode() const
</span></span></pre></div>
<a id="trunkSourceWebCoredomShadowRootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (189242 => 189243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ShadowRoot.cpp        2015-09-02 01:56:59 UTC (rev 189242)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp        2015-09-02 02:31:37 UTC (rev 189243)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">     , TreeScope(*this, document)
</span><span class="cx">     , m_resetStyleInheritance(false)
</span><span class="cx">     , m_type(type)
</span><del>-    , m_hostElement(0)
</del><ins>+    , m_host(0)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoredomShadowRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ShadowRoot.h (189242 => 189243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ShadowRoot.h        2015-09-02 01:56:59 UTC (rev 189242)
+++ trunk/Source/WebCore/dom/ShadowRoot.h        2015-09-02 02:31:37 UTC (rev 189243)
</span><span class="lines">@@ -53,8 +53,8 @@
</span><span class="cx">     bool resetStyleInheritance() const { return m_resetStyleInheritance; }
</span><span class="cx">     void setResetStyleInheritance(bool);
</span><span class="cx"> 
</span><del>-    Element* host() const { return m_hostElement; }
-    void setHost(Element* hostElement) { m_hostElement = hostElement; }
</del><ins>+    Element* host() const { return m_host; }
+    void setHost(Element* host) { m_host = host; }
</ins><span class="cx"> 
</span><span class="cx">     String innerHTML() const;
</span><span class="cx">     void setInnerHTML(const String&amp;, ExceptionCode&amp;);
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx">     PassRefPtr&lt;Node&gt; cloneNode(bool, ExceptionCode&amp;);
</span><span class="cx"> 
</span><span class="cx">     ContentDistributor&amp; distributor() { return m_distributor; }
</span><del>-    void invalidateDistribution() { m_distributor.invalidateDistribution(m_hostElement); }
</del><ins>+    void invalidateDistribution() { m_distributor.invalidateDistribution(m_host); }
</ins><span class="cx"> 
</span><span class="cx">     virtual void removeAllEventListeners() override;
</span><span class="cx"> 
</span><span class="lines">@@ -79,12 +79,12 @@
</span><span class="cx">     virtual RefPtr&lt;Node&gt; cloneNodeInternal(Document&amp;, CloningOperation) override;
</span><span class="cx"> 
</span><span class="cx">     // FIXME: This shouldn't happen. https://bugs.webkit.org/show_bug.cgi?id=88834
</span><del>-    bool isOrphan() const { return !m_hostElement; }
</del><ins>+    bool isOrphan() const { return !m_host; }
</ins><span class="cx"> 
</span><span class="cx">     unsigned m_resetStyleInheritance : 1;
</span><span class="cx">     unsigned m_type : 1;
</span><span class="cx"> 
</span><del>-    Element* m_hostElement;
</del><ins>+    Element* m_host;
</ins><span class="cx"> 
</span><span class="cx">     ContentDistributor m_distributor;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>

</body>
</html>