<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189183] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189183">189183</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2015-08-31 13:57:49 -0700 (Mon, 31 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Rendering Frame tasks making up < 1% of the selection don't appear in the pie chart
https://bugs.webkit.org/show_bug.cgi?id=148549
Reviewed by Timothy Hatcher.
Small data points can be invisible or difficult to see in the pie chart. This patch introduces
a minimum slice size of 1.5% (determined by visual inspection) for chart items.
Legend items continue to show the original data point values, not the adjusted values used to
draw the chart slices.
* UserInterface/Views/ChartDetailsSectionRow.js:
(WebInspector.ChartDetailsSectionRow):
(WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
Adjust display values up or down as needed, so no data point is less than the
minimum and all chart slices still total 100%.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsChartDetailsSectionRowjs">trunk/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (189182 => 189183)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-31 20:41:34 UTC (rev 189182)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-31 20:57:49 UTC (rev 189183)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-08-31 Matt Baker <mattbaker@apple.com>
+
+ Web Inspector: Rendering Frame tasks making up < 1% of the selection don't appear in the pie chart
+ https://bugs.webkit.org/show_bug.cgi?id=148549
+
+ Reviewed by Timothy Hatcher.
+
+ Small data points can be invisible or difficult to see in the pie chart. This patch introduces
+ a minimum slice size of 1.5% (determined by visual inspection) for chart items.
+
+ Legend items continue to show the original data point values, not the adjusted values used to
+ draw the chart slices.
+
+ * UserInterface/Views/ChartDetailsSectionRow.js:
+ (WebInspector.ChartDetailsSectionRow):
+ (WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
+ Adjust display values up or down as needed, so no data point is less than the
+ minimum and all chart slices still total 100%.
+
</ins><span class="cx"> 2015-08-28 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: "animationEnd" event names should be "animationend" (broken dashboard animation after pause)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsChartDetailsSectionRowjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js (189182 => 189183)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js 2015-08-31 20:41:34 UTC (rev 189182)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js 2015-08-31 20:57:49 UTC (rev 189183)
</span><span class="lines">@@ -318,6 +318,41 @@
</span><span class="cx"> ].join(" ");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // Balance item values so that all non-zero chart segments are visible.
+ const minimumDisplayValue = this._total * 0.015;
+
+ let items = [];
+ for (let item of this._items.values()) {
+ item.displayValue = item.value ? Math.max(minimumDisplayValue, item.value) : 0;
+ if (item.displayValue)
+ items.push(item);
+ }
+
+ if (items.length > 1) {
+ items.sort(function(a, b) { return a.value - b.value; });
+
+ let largeItemCount = items.length;
+ let totalAdjustedValue = 0;
+ for (let item of items) {
+ if (item.value < minimumDisplayValue) {
+ totalAdjustedValue += minimumDisplayValue - item.value;
+ largeItemCount--;
+ continue;
+ }
+
+ if (!totalAdjustedValue || !largeItemCount)
+ break;
+
+ const donatedValue = totalAdjustedValue / largeItemCount;
+ if (item.displayValue - donatedValue >= minimumDisplayValue) {
+ item.displayValue -= donatedValue;
+ totalAdjustedValue -= donatedValue;
+ }
+
+ largeItemCount--;
+ }
+ }
+
</ins><span class="cx"> const center = this._chartSize / 2;
</span><span class="cx"> let startAngle = -Math.PI / 2;
</span><span class="cx"> let endAngle = 0;
</span><span class="lines">@@ -337,7 +372,7 @@
</span><span class="cx"> continue;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const angle = (item.value / this._total) * Math.PI * 2;
</del><ins>+ const angle = (item.displayValue / this._total) * Math.PI * 2;
</ins><span class="cx"> endAngle = startAngle + angle;
</span><span class="cx">
</span><span class="cx"> path.setAttribute("d", createSegmentPathData(center, startAngle, endAngle, this._radius, this._innerRadius));
</span></span></pre>
</div>
</div>
</body>
</html>