<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189192] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189192">189192</a></dd>
<dt>Author</dt> <dd>basile_clement@apple.com</dd>
<dt>Date</dt> <dd>2015-08-31 16:13:13 -0700 (Mon, 31 Aug 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>ValueRecovery should distinguish between doubles in an FPR and JSValues in an FPR
https://bugs.webkit.org/show_bug.cgi?id=148336

Reviewed by Michael Saboff.

Currently, ValueRecovery::InFPR means &quot;this is a *double* value in an
FPR&quot;. Let's change the semantics to be &quot;this is a *JSValue* in an FPR&quot;
(to match ValueRecovery::InGPR), and introduce
ValueRecovery::UnboxedDoubleInFPR to mean &quot;this is a double value in an
FPR&quot;.

* bytecode/ValueRecovery.cpp:
(JSC::ValueRecovery::dumpInContext):
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::operator bool):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::isInGPR):
(JSC::ValueRecovery::isInFPR):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::isInJSStack):
(JSC::ValueRecovery::dataFormat):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::isInJSValueRegs):
(JSC::ValueRecovery::jsValueRegs):
(JSC::ValueRecovery::fpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::constant):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeValueRecoverycpp">trunk/Source/JavaScriptCore/bytecode/ValueRecovery.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeValueRecoveryh">trunk/Source/JavaScriptCore/bytecode/ValueRecovery.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGOSRExitCompiler32_64cpp">trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGOSRExitCompiler64cpp">trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGVariableEventStreamcpp">trunk/Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (189191 => 189192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2015-08-31 22:53:50 UTC (rev 189191)
+++ trunk/Source/JavaScriptCore/ChangeLog        2015-08-31 23:13:13 UTC (rev 189192)
</span><span class="lines">@@ -1,3 +1,39 @@
</span><ins>+2015-08-24  Basile Clement  &lt;basile_clement@apple.com&gt;
+
+        ValueRecovery should distinguish between doubles in an FPR and JSValues in an FPR
+        https://bugs.webkit.org/show_bug.cgi?id=148336
+
+        Reviewed by Michael Saboff.
+
+        Currently, ValueRecovery::InFPR means &quot;this is a *double* value in an
+        FPR&quot;. Let's change the semantics to be &quot;this is a *JSValue* in an FPR&quot;
+        (to match ValueRecovery::InGPR), and introduce
+        ValueRecovery::UnboxedDoubleInFPR to mean &quot;this is a double value in an
+        FPR&quot;.
+
+        * bytecode/ValueRecovery.cpp:
+        (JSC::ValueRecovery::dumpInContext):
+        * bytecode/ValueRecovery.h:
+        (JSC::ValueRecovery::operator bool):
+        (JSC::ValueRecovery::inFPR):
+        (JSC::ValueRecovery::isInGPR):
+        (JSC::ValueRecovery::isInFPR):
+        (JSC::ValueRecovery::isInRegisters):
+        (JSC::ValueRecovery::isInJSStack):
+        (JSC::ValueRecovery::dataFormat):
+        (JSC::ValueRecovery::gpr):
+        (JSC::ValueRecovery::isInJSValueRegs):
+        (JSC::ValueRecovery::jsValueRegs):
+        (JSC::ValueRecovery::fpr):
+        (JSC::ValueRecovery::virtualRegister):
+        (JSC::ValueRecovery::constant):
+        * dfg/DFGOSRExitCompiler32_64.cpp:
+        (JSC::DFG::OSRExitCompiler::compileExit):
+        * dfg/DFGOSRExitCompiler64.cpp:
+        (JSC::DFG::OSRExitCompiler::compileExit):
+        * dfg/DFGVariableEventStream.cpp:
+        (JSC::DFG::VariableEventStream::reconstruct):
+
</ins><span class="cx"> 2015-08-31  Chris Dumez  &lt;cdumez@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         NodeFilter.SHOW_ALL has wrong value on 32-bit
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeValueRecoverycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/ValueRecovery.cpp (189191 => 189192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/ValueRecovery.cpp        2015-08-31 22:53:50 UTC (rev 189191)
+++ trunk/Source/JavaScriptCore/bytecode/ValueRecovery.cpp        2015-08-31 23:13:13 UTC (rev 189192)
</span><span class="lines">@@ -86,6 +86,9 @@
</span><span class="cx">     case InFPR:
</span><span class="cx">         out.print(fpr());
</span><span class="cx">         return;
</span><ins>+    case UnboxedDoubleInFPR:
+        out.print(&quot;double(&quot;, fpr(), &quot;)&quot;);
+        return;
</ins><span class="cx"> #if USE(JSVALUE32_64)
</span><span class="cx">     case InPair:
</span><span class="cx">         out.print(&quot;pair(&quot;, tagGPR(), &quot;, &quot;, payloadGPR(), &quot;)&quot;);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeValueRecoveryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/ValueRecovery.h (189191 => 189192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/ValueRecovery.h        2015-08-31 22:53:50 UTC (rev 189191)
+++ trunk/Source/JavaScriptCore/bytecode/ValueRecovery.h        2015-08-31 23:13:13 UTC (rev 189192)
</span><span class="lines">@@ -55,6 +55,7 @@
</span><span class="cx">     InPair,
</span><span class="cx"> #endif
</span><span class="cx">     InFPR,
</span><ins>+    UnboxedDoubleInFPR,
</ins><span class="cx">     // It's in the stack, but at a different location.
</span><span class="cx">     DisplacedInJSStack,
</span><span class="cx">     // It's in the stack, at a different location, and it's unboxed.
</span><span class="lines">@@ -82,6 +83,7 @@
</span><span class="cx">     
</span><span class="cx">     bool isSet() const { return m_technique != DontKnow; }
</span><span class="cx">     bool operator!() const { return !isSet(); }
</span><ins>+    explicit operator bool() const { return isSet(); }
</ins><span class="cx">     
</span><span class="cx">     static ValueRecovery inGPR(MacroAssembler::RegisterID gpr, DataFormat dataFormat)
</span><span class="cx">     {
</span><span class="lines">@@ -117,10 +119,14 @@
</span><span class="cx">     }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    static ValueRecovery inFPR(MacroAssembler::FPRegisterID fpr)
</del><ins>+    static ValueRecovery inFPR(MacroAssembler::FPRegisterID fpr, DataFormat dataFormat)
</ins><span class="cx">     {
</span><ins>+        ASSERT(dataFormat == DataFormatDouble || dataFormat &amp; DataFormatJS);
</ins><span class="cx">         ValueRecovery result;
</span><del>-        result.m_technique = InFPR;
</del><ins>+        if (dataFormat == DataFormatDouble)
+            result.m_technique = UnboxedDoubleInFPR;
+        else
+            result.m_technique = InFPR;
</ins><span class="cx">         result.m_source.fpr = fpr;
</span><span class="cx">         return result;
</span><span class="cx">     }
</span><span class="lines">@@ -185,12 +191,12 @@
</span><span class="cx">         result.m_source.nodeID = id.bits();
</span><span class="cx">         return result;
</span><span class="cx">     }
</span><del>-    
</del><ins>+
</ins><span class="cx">     ValueRecoveryTechnique technique() const { return m_technique; }
</span><span class="cx">     
</span><span class="cx">     bool isConstant() const { return m_technique == Constant; }
</span><del>-    
-    bool isInRegisters() const
</del><ins>+
+    bool isInGPR() const
</ins><span class="cx">     {
</span><span class="cx">         switch (m_technique) {
</span><span class="cx">         case InGPR:
</span><span class="lines">@@ -199,19 +205,81 @@
</span><span class="cx">         case UnboxedCellInGPR:
</span><span class="cx">         case UnboxedInt52InGPR:
</span><span class="cx">         case UnboxedStrictInt52InGPR:
</span><del>-#if USE(JSVALUE32_64)
-        case InPair:
-#endif
</del><ins>+            return true;
+        default:
+            return false;
+        }
+    }
+
+    bool isInFPR() const
+    {
+        switch (m_technique) {
</ins><span class="cx">         case InFPR:
</span><ins>+        case UnboxedDoubleInFPR:
</ins><span class="cx">             return true;
</span><span class="cx">         default:
</span><span class="cx">             return false;
</span><span class="cx">         }
</span><span class="cx">     }
</span><ins>+
+    bool isInRegisters() const
+    {
+        return isInJSValueRegs() || isInGPR() || isInFPR();
+    }
+
+    bool isInJSStack() const
+    {
+        switch (m_technique) {
+        case DisplacedInJSStack:
+        case Int32DisplacedInJSStack:
+        case Int52DisplacedInJSStack:
+        case StrictInt52DisplacedInJSStack:
+        case DoubleDisplacedInJSStack:
+        case CellDisplacedInJSStack:
+        case BooleanDisplacedInJSStack:
+            return true;
+        default:
+            return false;
+        }
+    }
+
+    DataFormat dataFormat() const
+    {
+        switch (m_technique) {
+        case InGPR:
+        case InFPR:
+        case DisplacedInJSStack:
+        case Constant:
+#if USE(JSVALUE32_64)
+        case InPair:
+#endif
+            return DataFormatJS;
+        case UnboxedInt32InGPR:
+        case Int32DisplacedInJSStack:
+            return DataFormatInt32;
+        case UnboxedInt52InGPR:
+        case Int52DisplacedInJSStack:
+            return DataFormatInt52;
+        case UnboxedStrictInt52InGPR:
+        case StrictInt52DisplacedInJSStack:
+            return DataFormatStrictInt52;
+        case UnboxedBooleanInGPR:
+        case BooleanDisplacedInJSStack:
+            return DataFormatBoolean;
+        case UnboxedCellInGPR:
+        case CellDisplacedInJSStack:
+            return DataFormatCell;
+        case UnboxedDoubleInFPR:
+        case DoubleDisplacedInJSStack:
+            return DataFormatDouble;
+        default:
+            return DataFormatNone;
+        }
+    }
</ins><span class="cx">     
</span><span class="cx">     MacroAssembler::RegisterID gpr() const
</span><span class="cx">     {
</span><del>-        ASSERT(m_technique == InGPR || m_technique == UnboxedInt32InGPR || m_technique == UnboxedBooleanInGPR || m_technique == UnboxedInt52InGPR || m_technique == UnboxedStrictInt52InGPR || m_technique == UnboxedCellInGPR);
</del><ins>+        ASSERT(isInGPR());
</ins><span class="cx">         return m_source.gpr;
</span><span class="cx">     }
</span><span class="cx">     
</span><span class="lines">@@ -227,17 +295,39 @@
</span><span class="cx">         ASSERT(m_technique == InPair);
</span><span class="cx">         return m_source.pair.payloadGPR;
</span><span class="cx">     }
</span><ins>+
+    bool isInJSValueRegs() const
+    {
+        return m_technique == InPair;
+    }
+
+    JSValueRegs jsValueRegs() const
+    {
+        ASSERT(isInJSValueRegs());
+        return JSValueRegs(tagGPR(), payloadGPR());
+    }
+#else
+    bool isInJSValueRegs() const
+    {
+        return isInGPR();
+    }
+
+    JSValueRegs jsValueRegs() const
+    {
+        ASSERT(isInGPR());
+        return JSValueRegs(gpr());
+    }
</ins><span class="cx"> #endif
</span><span class="cx">     
</span><span class="cx">     MacroAssembler::FPRegisterID fpr() const
</span><span class="cx">     {
</span><del>-        ASSERT(m_technique == InFPR);
</del><ins>+        ASSERT(isInFPR());
</ins><span class="cx">         return m_source.fpr;
</span><span class="cx">     }
</span><span class="cx">     
</span><span class="cx">     VirtualRegister virtualRegister() const
</span><span class="cx">     {
</span><del>-        ASSERT(m_technique == DisplacedInJSStack || m_technique == Int32DisplacedInJSStack || m_technique == DoubleDisplacedInJSStack || m_technique == CellDisplacedInJSStack || m_technique == BooleanDisplacedInJSStack || m_technique == Int52DisplacedInJSStack || m_technique == StrictInt52DisplacedInJSStack);
</del><ins>+        ASSERT(isInJSStack());
</ins><span class="cx">         return VirtualRegister(m_source.virtualReg);
</span><span class="cx">     }
</span><span class="cx">     
</span><span class="lines">@@ -264,7 +354,7 @@
</span><span class="cx">     
</span><span class="cx">     JSValue constant() const
</span><span class="cx">     {
</span><del>-        ASSERT(m_technique == Constant);
</del><ins>+        ASSERT(isConstant());
</ins><span class="cx">         return JSValue::decode(m_source.constant);
</span><span class="cx">     }
</span><span class="cx">     
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGOSRExitCompiler32_64cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp (189191 => 189192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp        2015-08-31 22:53:50 UTC (rev 189191)
+++ trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp        2015-08-31 23:13:13 UTC (rev 189192)
</span><span class="lines">@@ -191,6 +191,7 @@
</span><span class="cx">         const ValueRecovery&amp; recovery = operands[index];
</span><span class="cx">         
</span><span class="cx">         switch (recovery.technique()) {
</span><ins>+        case UnboxedDoubleInFPR:
</ins><span class="cx">         case InFPR:
</span><span class="cx">             m_jit.move(AssemblyHelpers::TrustedImmPtr(scratch + index), GPRInfo::regT0);
</span><span class="cx">             m_jit.storeDouble(recovery.fpr(), MacroAssembler::Address(GPRInfo::regT0));
</span><span class="lines">@@ -252,6 +253,7 @@
</span><span class="cx">         switch (recovery.technique()) {
</span><span class="cx">         case InPair:
</span><span class="cx">         case DisplacedInJSStack:
</span><ins>+        case InFPR:
</ins><span class="cx">             m_jit.load32(
</span><span class="cx">                 &amp;bitwise_cast&lt;EncodedValueDescriptor*&gt;(scratch + index)-&gt;asBits.tag,
</span><span class="cx">                 GPRInfo::regT0);
</span><span class="lines">@@ -266,7 +268,7 @@
</span><span class="cx">                 AssemblyHelpers::payloadFor(operand));
</span><span class="cx">             break;
</span><span class="cx">             
</span><del>-        case InFPR:
</del><ins>+        case UnboxedDoubleInFPR:
</ins><span class="cx">         case DoubleDisplacedInJSStack:
</span><span class="cx">             m_jit.move(AssemblyHelpers::TrustedImmPtr(scratch + index), GPRInfo::regT0);
</span><span class="cx">             m_jit.loadDouble(MacroAssembler::Address(GPRInfo::regT0), FPRInfo::fpRegT0);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGOSRExitCompiler64cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp (189191 => 189192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp        2015-08-31 22:53:50 UTC (rev 189191)
+++ trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp        2015-08-31 23:13:13 UTC (rev 189192)
</span><span class="lines">@@ -209,6 +209,7 @@
</span><span class="cx">         const ValueRecovery&amp; recovery = operands[index];
</span><span class="cx">         
</span><span class="cx">         switch (recovery.technique()) {
</span><ins>+        case UnboxedDoubleInFPR:
</ins><span class="cx">         case InFPR:
</span><span class="cx">             m_jit.move(AssemblyHelpers::TrustedImmPtr(scratch + index), GPRInfo::regT0);
</span><span class="cx">             m_jit.storeDouble(recovery.fpr(), MacroAssembler::Address(GPRInfo::regT0));
</span><span class="lines">@@ -265,6 +266,7 @@
</span><span class="cx">         case DisplacedInJSStack:
</span><span class="cx">         case CellDisplacedInJSStack:
</span><span class="cx">         case BooleanDisplacedInJSStack:
</span><ins>+        case InFPR:
</ins><span class="cx">             m_jit.load64(scratch + index, GPRInfo::regT0);
</span><span class="cx">             m_jit.store64(GPRInfo::regT0, AssemblyHelpers::addressFor(operand));
</span><span class="cx">             break;
</span><span class="lines">@@ -293,7 +295,7 @@
</span><span class="cx">             m_jit.store64(GPRInfo::regT0, AssemblyHelpers::addressFor(operand));
</span><span class="cx">             break;
</span><span class="cx">             
</span><del>-        case InFPR:
</del><ins>+        case UnboxedDoubleInFPR:
</ins><span class="cx">         case DoubleDisplacedInJSStack:
</span><span class="cx">             m_jit.move(AssemblyHelpers::TrustedImmPtr(scratch + index), GPRInfo::regT0);
</span><span class="cx">             m_jit.loadDouble(MacroAssembler::Address(GPRInfo::regT0), FPRInfo::fpRegT0);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGVariableEventStreamcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp (189191 => 189192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp        2015-08-31 22:53:50 UTC (rev 189191)
+++ trunk/Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp        2015-08-31 23:13:13 UTC (rev 189192)
</span><span class="lines">@@ -209,7 +209,7 @@
</span><span class="cx">         
</span><span class="cx">         if (info.filled) {
</span><span class="cx">             if (info.format == DataFormatDouble) {
</span><del>-                valueRecoveries[i] = ValueRecovery::inFPR(info.u.fpr);
</del><ins>+                valueRecoveries[i] = ValueRecovery::inFPR(info.u.fpr, DataFormatDouble);
</ins><span class="cx">                 continue;
</span><span class="cx">             }
</span><span class="cx"> #if USE(JSVALUE32_64)
</span></span></pre>
</div>
</div>

</body>
</html>