<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188972] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188972">188972</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-26 11:34:38 -0700 (Wed, 26 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove the unused *Executable::unlinkCalls() and CodeBlock::unlinkCalls()
https://bugs.webkit.org/show_bug.cgi?id=148469
Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-08-26
Reviewed by Geoffrey Garen.
We use CodeBlock::unlinkIncomingCalls() to unlink calls.
(...)Executable::unlinkCalls() and CodeBlock::unlinkCalls() are no longer used.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkCalls): Deleted.
* bytecode/CodeBlock.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::unlinkCalls): Deleted.
(JSC::ProgramExecutable::unlinkCalls): Deleted.
(JSC::FunctionExecutable::unlinkCalls): Deleted.
* runtime/Executable.h:
(JSC::ScriptExecutable::unlinkCalls): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeCodeBlockcpp">trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeCodeBlockh">trunk/Source/JavaScriptCore/bytecode/CodeBlock.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExecutablecpp">trunk/Source/JavaScriptCore/runtime/Executable.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExecutableh">trunk/Source/JavaScriptCore/runtime/Executable.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (188971 => 188972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-08-26 18:18:14 UTC (rev 188971)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-08-26 18:34:38 UTC (rev 188972)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-08-26 Sukolsak Sakshuwong <sukolsak@gmail.com>
+
+ Remove the unused *Executable::unlinkCalls() and CodeBlock::unlinkCalls()
+ https://bugs.webkit.org/show_bug.cgi?id=148469
+
+ Reviewed by Geoffrey Garen.
+
+ We use CodeBlock::unlinkIncomingCalls() to unlink calls.
+ (...)Executable::unlinkCalls() and CodeBlock::unlinkCalls() are no longer used.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::unlinkCalls): Deleted.
+ * bytecode/CodeBlock.h:
+ * runtime/Executable.cpp:
+ (JSC::EvalExecutable::unlinkCalls): Deleted.
+ (JSC::ProgramExecutable::unlinkCalls): Deleted.
+ (JSC::FunctionExecutable::unlinkCalls): Deleted.
+ * runtime/Executable.h:
+ (JSC::ScriptExecutable::unlinkCalls): Deleted.
+
</ins><span class="cx"> 2015-08-25 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: no need to allocate protocolErrors array for every dispatched backend command
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeCodeBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp (188971 => 188972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp 2015-08-26 18:18:14 UTC (rev 188971)
+++ trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp 2015-08-26 18:34:38 UTC (rev 188972)
</span><span class="lines">@@ -2973,27 +2973,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(JIT)
</span><del>-void CodeBlock::unlinkCalls()
-{
- if (!!m_alternative)
- m_alternative->unlinkCalls();
- for (size_t i = 0; i < m_llintCallLinkInfos.size(); ++i) {
- if (m_llintCallLinkInfos[i].isLinked())
- m_llintCallLinkInfos[i].unlink();
- }
- if (m_callLinkInfos.isEmpty())
- return;
- if (!m_vm->canUseJIT())
- return;
- RepatchBuffer repatchBuffer(this);
- for (auto iter = m_callLinkInfos.begin(); !!iter; ++iter) {
- CallLinkInfo& info = **iter;
- if (!info.isLinked())
- continue;
- info.unlink(repatchBuffer);
- }
-}
-
</del><span class="cx"> void CodeBlock::linkIncomingCall(ExecState* callerFrame, CallLinkInfo* incoming)
</span><span class="cx"> {
</span><span class="cx"> noticeIncomingCall(callerFrame);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeCodeBlockh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/CodeBlock.h (188971 => 188972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/CodeBlock.h 2015-08-26 18:18:14 UTC (rev 188971)
+++ trunk/Source/JavaScriptCore/bytecode/CodeBlock.h 2015-08-26 18:34:38 UTC (rev 188972)
</span><span class="lines">@@ -230,8 +230,6 @@
</span><span class="cx"> void unlinkIncomingCalls();
</span><span class="cx">
</span><span class="cx"> #if ENABLE(JIT)
</span><del>- void unlinkCalls();
-
</del><span class="cx"> void linkIncomingCall(ExecState* callerFrame, CallLinkInfo*);
</span><span class="cx"> void linkIncomingPolymorphicCall(ExecState* callerFrame, PolymorphicCallNode*);
</span><span class="cx"> #endif // ENABLE(JIT)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExecutablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Executable.cpp (188971 => 188972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Executable.cpp 2015-08-26 18:18:14 UTC (rev 188971)
+++ trunk/Source/JavaScriptCore/runtime/Executable.cpp 2015-08-26 18:34:38 UTC (rev 188972)
</span><span class="lines">@@ -442,16 +442,6 @@
</span><span class="cx"> visitor.append(&thisObject->m_unlinkedEvalCodeBlock);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void EvalExecutable::unlinkCalls()
-{
-#if ENABLE(JIT)
- if (!m_jitCodeForCall)
- return;
- RELEASE_ASSERT(m_evalCodeBlock);
- m_evalCodeBlock->unlinkCalls();
-#endif
-}
-
</del><span class="cx"> void EvalExecutable::clearCode()
</span><span class="cx"> {
</span><span class="cx"> m_evalCodeBlock = nullptr;
</span><span class="lines">@@ -473,16 +463,6 @@
</span><span class="cx"> return error.toErrorObject(lexicalGlobalObject, m_source);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ProgramExecutable::unlinkCalls()
-{
-#if ENABLE(JIT)
- if (!m_jitCodeForCall)
- return;
- RELEASE_ASSERT(m_programCodeBlock);
- m_programCodeBlock->unlinkCalls();
-#endif
-}
-
</del><span class="cx"> JSObject* ProgramExecutable::initializeGlobalProperties(VM& vm, CallFrame* callFrame, JSScope* scope)
</span><span class="cx"> {
</span><span class="cx"> RELEASE_ASSERT(scope);
</span><span class="lines">@@ -569,20 +549,6 @@
</span><span class="cx"> Base::clearCode();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void FunctionExecutable::unlinkCalls()
-{
-#if ENABLE(JIT)
- if (!!m_jitCodeForCall) {
- RELEASE_ASSERT(m_codeBlockForCall);
- m_codeBlockForCall->unlinkCalls();
- }
- if (!!m_jitCodeForConstruct) {
- RELEASE_ASSERT(m_codeBlockForConstruct);
- m_codeBlockForConstruct->unlinkCalls();
- }
-#endif
-}
-
</del><span class="cx"> FunctionExecutable* FunctionExecutable::fromGlobalCode(
</span><span class="cx"> const Identifier& name, ExecState& exec, const SourceCode& source,
</span><span class="cx"> JSObject*& exception, int overrideLineNumber)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExecutableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Executable.h (188971 => 188972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Executable.h 2015-08-26 18:18:14 UTC (rev 188971)
+++ trunk/Source/JavaScriptCore/runtime/Executable.h 2015-08-26 18:34:38 UTC (rev 188972)
</span><span class="lines">@@ -381,8 +381,6 @@
</span><span class="cx">
</span><span class="cx"> bool* addressOfDidTryToEnterInLoop() { return &m_didTryToEnterInLoop; }
</span><span class="cx">
</span><del>- void unlinkCalls();
-
</del><span class="cx"> CodeFeatures features() const { return m_features; }
</span><span class="cx">
</span><span class="cx"> DECLARE_INFO;
</span><span class="lines">@@ -470,8 +468,6 @@
</span><span class="cx">
</span><span class="cx"> DECLARE_INFO;
</span><span class="cx">
</span><del>- void unlinkCalls();
-
</del><span class="cx"> void clearCode();
</span><span class="cx">
</span><span class="cx"> ExecutableInfo executableInfo() const { return ExecutableInfo(needsActivation(), usesEval(), isStrictMode(), false, false, ConstructorKind::None, false); }
</span><span class="lines">@@ -525,8 +521,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> DECLARE_INFO;
</span><del>-
- void unlinkCalls();
</del><span class="cx">
</span><span class="cx"> void clearCode();
</span><span class="cx">
</span><span class="lines">@@ -656,8 +650,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> DECLARE_INFO;
</span><del>-
- void unlinkCalls();
</del><span class="cx">
</span><span class="cx"> void clearCode();
</span><span class="cx">
</span><span class="lines">@@ -694,20 +686,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline void ScriptExecutable::unlinkCalls()
-{
- switch (type()) {
- case EvalExecutableType:
- return jsCast<EvalExecutable*>(this)->unlinkCalls();
- case ProgramExecutableType:
- return jsCast<ProgramExecutable*>(this)->unlinkCalls();
- case FunctionExecutableType:
- return jsCast<FunctionExecutable*>(this)->unlinkCalls();
- default:
- RELEASE_ASSERT_NOT_REACHED();
- }
</del><span class="cx"> }
</span><span class="cx">
</span><del>-}
-
</del><span class="cx"> #endif
</span></span></pre>
</div>
</div>
</body>
</html>