<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[188994] trunk/Source</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188994">188994</a></dd>

<dt>Author</dt> <dd>cdumez@apple.com</dd>

<dt>Date</dt> <dd>2015-08-26 15:09:29 -0700 (Wed, 26 Aug 2015)</dd>

</dl>

<h3>Log Message</h3>

<pre>Distinguish Web IDL callback interfaces from Web IDL callback functions

https://bugs.webkit.org/show_bug.cgi?id=148434

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add isNull() convenience method on PropertyName.

* runtime/PropertyName.h:

(JSC::PropertyName::isNull):

Source/WebCore:

Distinguish Web IDL callback interfaces [1] from Web IDL callback

functions [2].

One Web-exposed difference is that when using a callback interface,

the user can pass either a function / callable object or a non-callable

object that has a method with the same name as the callback interface

operation:

https://heycam.github.io/webidl/#es-user-objects

When using a callback function, the user needs to pass a function /

callable object:

https://heycam.github.io/webidl/#es-callback-function

This patch adds a new [Callback=FunctionOnly] IDL extended attribute to

indicate that a callback interface should be function-only (i.e. a callback

function in the latest Web IDL specification). Without this IDL extended

attribute, the callback interface will be treated as a regular callback

interface. This will be needed for Bug 148415, as NodeFilter should be

an actual callback interface.

Note that longer term, we should really drop the old-style

[Callback=FunctionOnly] extendd attribute and use actual IDL callback

functions as per the latest Web IDL specification. However, I did not

do this in this patch to minimize patch size.

This patch adds Callback=FunctionOnly] IDL extended attribute to all

our pre-existing callback interfaces so that there is no behavior

change.

       [1] https://heycam.github.io/webidl/#dfn-callback-interface

       [2] https://heycam.github.io/webidl/#idl-callback-functions

* Modules/geolocation/PositionCallback.idl:

* Modules/geolocation/PositionErrorCallback.idl:

* Modules/mediastream/MediaStreamTrackSourcesCallback.idl:

* Modules/mediastream/NavigatorUserMediaErrorCallback.idl:

* Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:

* Modules/mediastream/RTCPeerConnectionErrorCallback.idl:

* Modules/mediastream/RTCSessionDescriptionCallback.idl:

* Modules/mediastream/RTCStatsCallback.idl:

* Modules/notifications/NotificationPermissionCallback.idl:

* Modules/quota/StorageErrorCallback.idl:

* Modules/quota/StorageQuotaCallback.idl:

* Modules/quota/StorageUsageCallback.idl:

* Modules/webaudio/AudioBufferCallback.idl:

* Modules/webdatabase/DatabaseCallback.idl:

* Modules/webdatabase/SQLStatementCallback.idl:

* Modules/webdatabase/SQLStatementErrorCallback.idl:

* Modules/webdatabase/SQLTransactionCallback.idl:

* Modules/webdatabase/SQLTransactionErrorCallback.idl:

* bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

* bindings/js/JSCallbackData.h:

* bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

* bindings/scripts/CodeGenerator.pm:

(trim):

(IsFunctionOnlyCallbackInterface):

* bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheckExpression):

(GenerateParametersCheck):

(GenerateCallbackImplementation):

* bindings/scripts/IDLAttributes.txt:

* bindings/scripts/test/GObject/WebKitDOMTestCallbackFunction.cpp: Added.

(WebKit::kit):

(WebKit::core):

(WebKit::wrapTestCallbackFunction):

(webkit_dom_test_callback_function_finalize):

(webkit_dom_test_callback_function_constructor):

(webkit_dom_test_callback_function_class_init):

(webkit_dom_test_callback_function_init):

(webkit_dom_test_callback_function_callback_with_no_param):

(webkit_dom_test_callback_function_callback_with_array_param):

(webkit_dom_test_callback_function_callback_with_serialized_script_value_param):

(webkit_dom_test_callback_function_callback_with_non_bool_return_type):

(webkit_dom_test_callback_function_callback_with_string_list):

(webkit_dom_test_callback_function_callback_with_boolean):

(webkit_dom_test_callback_function_callback_requires_this_to_pass):

* bindings/scripts/test/GObject/WebKitDOMTestCallbackFunction.h: Added.

* bindings/scripts/test/GObject/WebKitDOMTestCallbackFunctionPrivate.h: Copied from Source/WebCore/css/MediaQueryListListener.idl.

* bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithNoParam):

(WebCore::JSTestCallback::callbackWithArrayParam):

(WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):

(WebCore::JSTestCallback::callbackWithStringList):

(WebCore::JSTestCallback::callbackWithBoolean):

(WebCore::JSTestCallback::callbackRequiresThisToPass):

* bindings/scripts/test/JS/JSTestCallbackFunction.cpp: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp.

(WebCore::JSTestCallbackFunction::JSTestCallbackFunction):

(WebCore::JSTestCallbackFunction::~JSTestCallbackFunction):

(WebCore::JSTestCallbackFunction::callbackWithNoParam):

(WebCore::JSTestCallbackFunction::callbackWithArrayParam):

(WebCore::JSTestCallbackFunction::callbackWithSerializedScriptValueParam):

(WebCore::JSTestCallbackFunction::callbackWithStringList):

(WebCore::JSTestCallbackFunction::callbackWithBoolean):

(WebCore::JSTestCallbackFunction::callbackRequiresThisToPass):

* bindings/scripts/test/JS/JSTestCallbackFunction.h: Added.

(WebCore::JSTestCallbackFunction::create):

(WebCore::JSTestCallbackFunction::scriptExecutionContext):

* bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::constructJSTestObj):

(WebCore::JSTestObjConstructor::finishCreation):

(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):

(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):

(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):

(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionArg):

(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackFunctionArg):

(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionAndOptionalArg):

(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg):

(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg):

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): Deleted.

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10): Deleted.

* bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):

* bindings/scripts/test/ObjC/DOMTestCallbackFunction.h: Copied from Source/WebCore/html/VoidCallback.idl.

* bindings/scripts/test/ObjC/DOMTestCallbackFunction.mm: Added.

(-[DOMTestCallbackFunction dealloc]):

(-[DOMTestCallbackFunction finalize]):

(-[DOMTestCallbackFunction callbackWithNoParam]):

(-[DOMTestCallbackFunction callbackWithArrayParam:]):

(-[DOMTestCallbackFunction callbackWithSerializedScriptValueParam:strArg:]):

(-[DOMTestCallbackFunction callbackWithNonBoolReturnType:]):

(-[DOMTestCallbackFunction customCallback:class6Param:]):

(-[DOMTestCallbackFunction callbackWithStringList:]):

(-[DOMTestCallbackFunction callbackWithBoolean:]):

(-[DOMTestCallbackFunction callbackRequiresThisToPass:testNodeParam:]):

(core):

(kit):

* bindings/scripts/test/ObjC/DOMTestCallbackFunctionInternal.h: Copied from Source/WebCore/html/VoidCallback.idl.

* bindings/scripts/test/TestCallbackFunction.idl: Copied from Source/WebCore/Modules/webdatabase/DatabaseCallback.idl.

* bindings/scripts/test/TestObj.idl:

* css/MediaQueryListListener.idl:

* dom/RequestAnimationFrameCallback.idl:

* dom/StringCallback.idl:

* html/VoidCallback.idl:</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>

<li><a href="#trunkSourceJavaScriptCoreruntimePropertyNameh">trunk/Source/JavaScriptCore/runtime/PropertyName.h</a></li>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoreModulesgeolocationPositionCallbackidl">trunk/Source/WebCore/Modules/geolocation/PositionCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesgeolocationPositionErrorCallbackidl">trunk/Source/WebCore/Modules/geolocation/PositionErrorCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackSourcesCallbackidl">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackSourcesCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamNavigatorUserMediaErrorCallbackidl">trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaErrorCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamNavigatorUserMediaSuccessCallbackidl">trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaSuccessCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectionErrorCallbackidl">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnectionErrorCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCSessionDescriptionCallbackidl">trunk/Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesmediastreamRTCStatsCallbackidl">trunk/Source/WebCore/Modules/mediastream/RTCStatsCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesnotificationsNotificationPermissionCallbackidl">trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesquotaStorageErrorCallbackidl">trunk/Source/WebCore/Modules/quota/StorageErrorCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesquotaStorageQuotaCallbackidl">trunk/Source/WebCore/Modules/quota/StorageQuotaCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModulesquotaStorageUsageCallbackidl">trunk/Source/WebCore/Modules/quota/StorageUsageCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModuleswebaudioAudioBufferCallbackidl">trunk/Source/WebCore/Modules/webaudio/AudioBufferCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseCallbackidl">trunk/Source/WebCore/Modules/webdatabase/DatabaseCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLStatementCallbackidl">trunk/Source/WebCore/Modules/webdatabase/SQLStatementCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLStatementErrorCallbackidl">trunk/Source/WebCore/Modules/webdatabase/SQLStatementErrorCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLTransactionCallbackidl">trunk/Source/WebCore/Modules/webdatabase/SQLTransactionCallback.idl</a></li>

<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLTransactionErrorCallbackidl">trunk/Source/WebCore/Modules/webdatabase/SQLTransactionErrorCallback.idl</a></li>

<li><a href="#trunkSourceWebCorebindingsjsJSCallbackDatacpp">trunk/Source/WebCore/bindings/js/JSCallbackData.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsjsJSCallbackDatah">trunk/Source/WebCore/bindings/js/JSCallbackData.h</a></li>

<li><a href="#trunkSourceWebCorebindingsjsJSCustomSQLStatementErrorCallbackcpp">trunk/Source/WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorpm">trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptsIDLAttributestxt">trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCallbackcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestTestObjidl">trunk/Source/WebCore/bindings/scripts/test/TestObj.idl</a></li>

<li><a href="#trunkSourceWebCorecssMediaQueryListListeneridl">trunk/Source/WebCore/css/MediaQueryListListener.idl</a></li>

<li><a href="#trunkSourceWebCoredomRequestAnimationFrameCallbackidl">trunk/Source/WebCore/dom/RequestAnimationFrameCallback.idl</a></li>

<li><a href="#trunkSourceWebCoredomStringCallbackidl">trunk/Source/WebCore/dom/StringCallback.idl</a></li>

<li><a href="#trunkSourceWebCorehtmlVoidCallbackidl">trunk/Source/WebCore/html/VoidCallback.idl</a></li>

</ul>

<h3>Added Paths</h3>

<ul>

<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestCallbackFunctioncpp">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallbackFunction.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestCallbackFunctionh">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallbackFunction.h</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestCallbackFunctionPrivateh">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallbackFunctionPrivate.h</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCallbackFunctioncpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunction.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCallbackFunctionh">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunction.h</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestObjCDOMTestCallbackFunctionh">trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestCallbackFunction.h</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestObjCDOMTestCallbackFunctionmm">trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestCallbackFunction.mm</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestObjCDOMTestCallbackFunctionInternalh">trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestCallbackFunctionInternal.h</a></li>

<li><a href="#trunkSourceWebCorebindingsscriptstestTestCallbackFunctionidl">trunk/Source/WebCore/bindings/scripts/test/TestCallbackFunction.idl</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkSourceJavaScriptCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/JavaScriptCore/ChangeLog        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -1,3 +1,15 @@

</span><ins>+2015-08-26  Chris Dumez  &lt;cdumez@apple.com&gt;

+

+        Distinguish Web IDL callback interfaces from Web IDL callback functions

+        https://bugs.webkit.org/show_bug.cgi?id=148434

+

+        Reviewed by Geoffrey Garen.

+

+        Add isNull() convenience method on PropertyName.

+

+        * runtime/PropertyName.h:

+        (JSC::PropertyName::isNull):

+

</ins><span class="cx"> 2015-08-26  Filip Pizlo  &lt;fpizlo@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         Node::origin should be able to tell you if it's OK to exit

</span></span></pre></div>

<a id="trunkSourceJavaScriptCoreruntimePropertyNameh"></a>

<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/PropertyName.h (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/JavaScriptCore/runtime/PropertyName.h        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/JavaScriptCore/runtime/PropertyName.h        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -51,6 +51,8 @@

</span><span class="cx">         ASSERT(m_impl-&gt;isSymbol());

</span><span class="cx">     }

</span><span class="cx"> 

</span><ins>+    bool isNull() const { return m_impl; }

+

</ins><span class="cx">     bool isSymbol()

</span><span class="cx">     {

</span><span class="cx">         return m_impl &amp;&amp; m_impl-&gt;isSymbol();

</span></span></pre></div>

<a id="trunkSourceWebCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/ChangeLog        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -1,3 +1,148 @@

</span><ins>+2015-08-26  Chris Dumez  &lt;cdumez@apple.com&gt;

+

+        Distinguish Web IDL callback interfaces from Web IDL callback functions

+        https://bugs.webkit.org/show_bug.cgi?id=148434

+

+        Reviewed by Geoffrey Garen.

+

+        Distinguish Web IDL callback interfaces [1] from Web IDL callback

+        functions [2].

+

+        One Web-exposed difference is that when using a callback interface,

+        the user can pass either a function / callable object or a non-callable

+        object that has a method with the same name as the callback interface

+        operation:

+        https://heycam.github.io/webidl/#es-user-objects

+

+        When using a callback function, the user needs to pass a function /

+        callable object:

+        https://heycam.github.io/webidl/#es-callback-function

+

+        This patch adds a new [Callback=FunctionOnly] IDL extended attribute to

+        indicate that a callback interface should be function-only (i.e. a callback

+        function in the latest Web IDL specification). Without this IDL extended

+        attribute, the callback interface will be treated as a regular callback

+        interface. This will be needed for Bug 148415, as NodeFilter should be

+        an actual callback interface.

+

+        Note that longer term, we should really drop the old-style

+        [Callback=FunctionOnly] extendd attribute and use actual IDL callback

+        functions as per the latest Web IDL specification. However, I did not

+        do this in this patch to minimize patch size.

+

+        This patch adds Callback=FunctionOnly] IDL extended attribute to all

+        our pre-existing callback interfaces so that there is no behavior

+        change.

+

+       [1] https://heycam.github.io/webidl/#dfn-callback-interface

+       [2] https://heycam.github.io/webidl/#idl-callback-functions

+

+        * Modules/geolocation/PositionCallback.idl:

+        * Modules/geolocation/PositionErrorCallback.idl:

+        * Modules/mediastream/MediaStreamTrackSourcesCallback.idl:

+        * Modules/mediastream/NavigatorUserMediaErrorCallback.idl:

+        * Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:

+        * Modules/mediastream/RTCPeerConnectionErrorCallback.idl:

+        * Modules/mediastream/RTCSessionDescriptionCallback.idl:

+        * Modules/mediastream/RTCStatsCallback.idl:

+        * Modules/notifications/NotificationPermissionCallback.idl:

+        * Modules/quota/StorageErrorCallback.idl:

+        * Modules/quota/StorageQuotaCallback.idl:

+        * Modules/quota/StorageUsageCallback.idl:

+        * Modules/webaudio/AudioBufferCallback.idl:

+        * Modules/webdatabase/DatabaseCallback.idl:

+        * Modules/webdatabase/SQLStatementCallback.idl:

+        * Modules/webdatabase/SQLStatementErrorCallback.idl:

+        * Modules/webdatabase/SQLTransactionCallback.idl:

+        * Modules/webdatabase/SQLTransactionErrorCallback.idl:

+        * bindings/js/JSCallbackData.cpp:

+        (WebCore::JSCallbackData::invokeCallback):

+        * bindings/js/JSCallbackData.h:

+        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:

+        (WebCore::JSSQLStatementErrorCallback::handleEvent):

+        * bindings/scripts/CodeGenerator.pm:

+        (trim):

+        (IsFunctionOnlyCallbackInterface):

+        * bindings/scripts/CodeGeneratorJS.pm:

+        (GenerateParametersCheckExpression):

+        (GenerateParametersCheck):

+        (GenerateCallbackImplementation):

+        * bindings/scripts/IDLAttributes.txt:

+        * bindings/scripts/test/GObject/WebKitDOMTestCallbackFunction.cpp: Added.

+        (WebKit::kit):

+        (WebKit::core):

+        (WebKit::wrapTestCallbackFunction):

+        (webkit_dom_test_callback_function_finalize):

+        (webkit_dom_test_callback_function_constructor):

+        (webkit_dom_test_callback_function_class_init):

+        (webkit_dom_test_callback_function_init):

+        (webkit_dom_test_callback_function_callback_with_no_param):

+        (webkit_dom_test_callback_function_callback_with_array_param):

+        (webkit_dom_test_callback_function_callback_with_serialized_script_value_param):

+        (webkit_dom_test_callback_function_callback_with_non_bool_return_type):

+        (webkit_dom_test_callback_function_callback_with_string_list):

+        (webkit_dom_test_callback_function_callback_with_boolean):

+        (webkit_dom_test_callback_function_callback_requires_this_to_pass):

+        * bindings/scripts/test/GObject/WebKitDOMTestCallbackFunction.h: Added.

+        * bindings/scripts/test/GObject/WebKitDOMTestCallbackFunctionPrivate.h: Copied from Source/WebCore/css/MediaQueryListListener.idl.

+        * bindings/scripts/test/JS/JSTestCallback.cpp:

+        (WebCore::JSTestCallback::callbackWithNoParam):

+        (WebCore::JSTestCallback::callbackWithArrayParam):

+        (WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):

+        (WebCore::JSTestCallback::callbackWithStringList):

+        (WebCore::JSTestCallback::callbackWithBoolean):

+        (WebCore::JSTestCallback::callbackRequiresThisToPass):

+        * bindings/scripts/test/JS/JSTestCallbackFunction.cpp: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp.

+        (WebCore::JSTestCallbackFunction::JSTestCallbackFunction):

+        (WebCore::JSTestCallbackFunction::~JSTestCallbackFunction):

+        (WebCore::JSTestCallbackFunction::callbackWithNoParam):

+        (WebCore::JSTestCallbackFunction::callbackWithArrayParam):

+        (WebCore::JSTestCallbackFunction::callbackWithSerializedScriptValueParam):

+        (WebCore::JSTestCallbackFunction::callbackWithStringList):

+        (WebCore::JSTestCallbackFunction::callbackWithBoolean):

+        (WebCore::JSTestCallbackFunction::callbackRequiresThisToPass):

+        * bindings/scripts/test/JS/JSTestCallbackFunction.h: Added.

+        (WebCore::JSTestCallbackFunction::create):

+        (WebCore::JSTestCallbackFunction::scriptExecutionContext):

+        * bindings/scripts/test/JS/JSTestObj.cpp:

+        (WebCore::JSTestObjConstructor::constructJSTestObj):

+        (WebCore::JSTestObjConstructor::finishCreation):

+        (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):

+        (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):

+        (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):

+        (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionArg):

+        (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackFunctionArg):

+        (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionAndOptionalArg):

+        (WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg):

+        (WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg):

+        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):

+        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):

+        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): Deleted.

+        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod10): Deleted.

+        * bindings/scripts/test/JS/JSTestTypedefs.cpp:

+        (WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):

+        * bindings/scripts/test/ObjC/DOMTestCallbackFunction.h: Copied from Source/WebCore/html/VoidCallback.idl.

+        * bindings/scripts/test/ObjC/DOMTestCallbackFunction.mm: Added.

+        (-[DOMTestCallbackFunction dealloc]):

+        (-[DOMTestCallbackFunction finalize]):

+        (-[DOMTestCallbackFunction callbackWithNoParam]):

+        (-[DOMTestCallbackFunction callbackWithArrayParam:]):

+        (-[DOMTestCallbackFunction callbackWithSerializedScriptValueParam:strArg:]):

+        (-[DOMTestCallbackFunction callbackWithNonBoolReturnType:]):

+        (-[DOMTestCallbackFunction customCallback:class6Param:]):

+        (-[DOMTestCallbackFunction callbackWithStringList:]):

+        (-[DOMTestCallbackFunction callbackWithBoolean:]):

+        (-[DOMTestCallbackFunction callbackRequiresThisToPass:testNodeParam:]):

+        (core):

+        (kit):

+        * bindings/scripts/test/ObjC/DOMTestCallbackFunctionInternal.h: Copied from Source/WebCore/html/VoidCallback.idl.

+        * bindings/scripts/test/TestCallbackFunction.idl: Copied from Source/WebCore/Modules/webdatabase/DatabaseCallback.idl.

+        * bindings/scripts/test/TestObj.idl:

+        * css/MediaQueryListListener.idl:

+        * dom/RequestAnimationFrameCallback.idl:

+        * dom/StringCallback.idl:

+        * html/VoidCallback.idl:

+

</ins><span class="cx"> 2015-08-26  Beth Dakin  &lt;bdakin@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         REGRESSION: Safari navigates after a cancelled force click

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesgeolocationPositionCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/geolocation/PositionCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/geolocation/PositionCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/geolocation/PositionCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -24,6 +24,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=GEOLOCATION,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface PositionCallback {

</span><span class="cx">     boolean handleEvent(Geoposition position);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesgeolocationPositionErrorCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/geolocation/PositionErrorCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/geolocation/PositionErrorCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/geolocation/PositionErrorCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -24,6 +24,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=GEOLOCATION,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface PositionErrorCallback {

</span><span class="cx">     boolean handleEvent(PositionError error);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackSourcesCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackSourcesCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackSourcesCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackSourcesCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -25,7 +25,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=MEDIA_STREAM,

</span><del>-    NoInterfaceObject,

</del><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface MediaStreamTrackSourcesCallback {

</span><span class="cx">     boolean handleEvent(sequence&lt;SourceInfo&gt; sources);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamNavigatorUserMediaErrorCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaErrorCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaErrorCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaErrorCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -24,6 +24,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=MEDIA_STREAM,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface NavigatorUserMediaErrorCallback {

</span><span class="cx">     boolean handleEvent(NavigatorUserMediaError error);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamNavigatorUserMediaSuccessCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaSuccessCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaSuccessCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaSuccessCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -24,6 +24,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=MEDIA_STREAM,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface NavigatorUserMediaSuccessCallback {

</span><span class="cx">     boolean handleEvent(MediaStream stream);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamRTCPeerConnectionErrorCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnectionErrorCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnectionErrorCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnectionErrorCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -25,6 +25,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=MEDIA_STREAM,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface RTCPeerConnectionErrorCallback {

</span><span class="cx">     boolean handleEvent(DOMError error);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamRTCSessionDescriptionCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -30,6 +30,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=MEDIA_STREAM,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface RTCSessionDescriptionCallback {

</span><span class="cx">     boolean handleEvent(RTCSessionDescription sdp);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesmediastreamRTCStatsCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCStatsCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCStatsCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/mediastream/RTCStatsCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -24,6 +24,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=MEDIA_STREAM,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface RTCStatsCallback {

</span><span class="cx">     boolean handleEvent(RTCStatsResponse response);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesnotificationsNotificationPermissionCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -25,6 +25,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=NOTIFICATIONS,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface NotificationPermissionCallback {

</span><span class="cx">     boolean handleEvent(DOMString permission);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesquotaStorageErrorCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/quota/StorageErrorCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/quota/StorageErrorCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/quota/StorageErrorCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -30,6 +30,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=QUOTA,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface StorageErrorCallback {

</span><span class="cx">     boolean handleEvent(DOMCoreException error);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesquotaStorageQuotaCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/quota/StorageQuotaCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/quota/StorageQuotaCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/quota/StorageQuotaCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -30,6 +30,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=QUOTA,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface StorageQuotaCallback {

</span><span class="cx">     boolean handleEvent(unsigned long long grantedQuotaInBytes);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModulesquotaStorageUsageCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/quota/StorageUsageCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/quota/StorageUsageCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/quota/StorageUsageCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -30,6 +30,7 @@

</span><span class="cx"> 

</span><span class="cx"> [

</span><span class="cx">     Conditional=QUOTA,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface StorageUsageCallback {

</span><span class="cx">     boolean handleEvent(unsigned long long currentUsageInBytes, unsigned long long currentQuotaInBytes);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModuleswebaudioAudioBufferCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioBufferCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -25,6 +25,7 @@

</span><span class="cx"> [

</span><span class="cx">     Conditional=WEB_AUDIO,

</span><span class="cx">     JSGenerateToJSObject,

</span><ins>+    Callback=FunctionOnly,

</ins><span class="cx"> ] callback interface AudioBufferCallback {

</span><span class="cx">     boolean handleEvent(AudioBuffer audioBuffer);

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseCallbackidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseCallback.idl (188993 => 188994)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseCallback.idl        2015-08-26 22:07:18 UTC (rev 188993)

+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseCallback.idl        2015-08-26 22:09:29 UTC (rev 188994)

</span><span class="lines">@@ -26,6 +26,8 @@