<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188834] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188834">188834</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-23 03:35:19 -0700 (Sun, 23 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove style checking rule regarding OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=148360
Reviewed by Darin Adler.
OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
Removed it.
* Scripts/do-webcore-rename:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(PassPtrTest.test_pass_own_ptr_in_function): Deleted.
(PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
(PassPtrTest.test_own_ptr_parameter_value): Deleted.
(WebKitStyleTest.test_names): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsdowebcorerename">trunk/Tools/Scripts/do-webcore-rename</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerscpp_unittestpy">trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (188833 => 188834)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-08-23 04:14:44 UTC (rev 188833)
+++ trunk/Tools/ChangeLog 2015-08-23 10:35:19 UTC (rev 188834)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-08-23 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Remove style checking rule regarding OwnPtr and PassOwnPtr
+ https://bugs.webkit.org/show_bug.cgi?id=148360
+
+ Reviewed by Darin Adler.
+
+ OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
+ Removed it.
+
+ * Scripts/do-webcore-rename:
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
+ (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
+ (PassPtrTest.test_own_ptr_parameter_value): Deleted.
+ (WebKitStyleTest.test_names): Deleted.
+
</ins><span class="cx"> 2015-08-22 Timothy Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> WebKitTestRunner should use WKWebView on OS X and iOS
</span></span></pre></div>
<a id="trunkToolsScriptsdowebcorerename"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/do-webcore-rename (188833 => 188834)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/do-webcore-rename 2015-08-23 04:14:44 UTC (rev 188833)
+++ trunk/Tools/Scripts/do-webcore-rename 2015-08-23 10:35:19 UTC (rev 188834)
</span><span class="lines">@@ -103,8 +103,6 @@
</span><span class="cx">
</span><span class="cx"> my %renamesContemplatedForTheFuture = (
</span><span class="cx"> "PassRefPtr" => "DeprecatedPassRefPtr",
</span><del>- "OwnPtr" => "DeprecatedOwnPtr",
- "PassOwnPtr" => "DeprecatedPassOwnPtr",
</del><span class="cx">
</span><span class="cx"> "HTMLPlugInImageElement" => "HTMLEmbeddedObjectElement",
</span><span class="cx"> "isPlugInImageElement" => "isEmbeddedObjectElement",
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerscpp_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (188833 => 188834)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2015-08-23 04:14:44 UTC (rev 188833)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2015-08-23 10:35:19 UTC (rev 188834)
</span><span class="lines">@@ -3639,15 +3639,6 @@
</span><span class="cx"> 'Local variables should never be PassRefPtr (see '
</span><span class="cx"> 'http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]')
</span><span class="cx">
</span><del>- def test_pass_own_ptr_in_function(self):
- self.assert_pass_ptr_check(
- 'int myFunction()\n'
- '{\n'
- ' PassOwnPtr<Type1> variable = variable2;\n'
- '}',
- 'Local variables should never be PassOwnPtr (see '
- 'http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]')
-
</del><span class="cx"> def test_pass_other_type_ptr_in_function(self):
</span><span class="cx"> self.assert_pass_ptr_check(
</span><span class="cx"> 'int myFunction()\n'
</span><span class="lines">@@ -3673,18 +3664,10 @@
</span><span class="cx"> 'PassRefPtr<Type1> myFunction();\n',
</span><span class="cx"> '')
</span><span class="cx"> self.assert_pass_ptr_check(
</span><del>- 'OwnRefPtr<Type1> myFunction();\n',
- '')
- self.assert_pass_ptr_check(
</del><span class="cx"> 'RefPtr<Type1> myFunction(int)\n'
</span><span class="cx"> '{\n'
</span><span class="cx"> '}',
</span><span class="cx"> '')
</span><del>- self.assert_pass_ptr_check(
- 'OwnPtr<Type1> myFunction(int)\n'
- '{\n'
- '}',
- '')
</del><span class="cx">
</span><span class="cx"> def test_ref_ptr_parameter_value(self):
</span><span class="cx"> self.assert_pass_ptr_check(
</span><span class="lines">@@ -3708,23 +3691,6 @@
</span><span class="cx"> '}',
</span><span class="cx"> '')
</span><span class="cx">
</span><del>- def test_own_ptr_parameter_value(self):
- self.assert_pass_ptr_check(
- 'int myFunction(PassOwnPtr<Type1>)\n'
- '{\n'
- '}',
- '')
- self.assert_pass_ptr_check(
- 'int myFunction(OwnPtr<Type1>)\n'
- '{\n'
- '}',
- '')
- self.assert_pass_ptr_check(
- 'int myFunction(OwnPtr<Type1>& simple)\n'
- '{\n'
- '}',
- '')
-
</del><span class="cx"> def test_ref_ptr_member_variable(self):
</span><span class="cx"> self.assert_pass_ptr_check(
</span><span class="cx"> 'class Foo {'
</span><span class="lines">@@ -5100,12 +5066,6 @@
</span><span class="cx"> self.assert_lint('unsigned _fillRule : 1;',
</span><span class="cx"> '_fillRule' + name_underscore_error_message)
</span><span class="cx">
</span><del>- # new operators in initialization.
- self.assert_lint('OwnPtr<uint32_t> variable(new uint32_t);', '')
- self.assert_lint('OwnPtr<uint32_t> variable(new (expr) uint32_t);', '')
- self.assert_lint('OwnPtr<uint32_t> under_score(new uint32_t);',
- 'under_score' + name_underscore_error_message)
-
</del><span class="cx"> def test_parameter_names(self):
</span><span class="cx"> # Leave meaningless variable names out of function declarations.
</span><span class="cx"> meaningless_variable_name_error_message = 'The parameter name "%s" adds no information, so it should be removed. [readability/parameter_name] [5]'
</span></span></pre>
</div>
</div>
</body>
</html>