<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188759] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188759">188759</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-21 11:26:23 -0700 (Fri, 21 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Mac] accessibility/selection-states.html fails
https://bugs.webkit.org/show_bug.cgi?id=116637
Patch by Nan Wang <n_wang@apple.com> on 2015-08-21
Reviewed by Chris Fleizach.
Source/WebCore:
Added accessibilityAttributeValue callback for isMultiSelectable attribute.
Updated expectation for accessibility/selection-states.html on mac.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Implemented isSelectable() and isMultiSelectable().
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
LayoutTests:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacAccessibilityUIElementMacmm">trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundlemacAccessibilityUIElementMacmm">trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (188758 => 188759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-08-21 18:10:17 UTC (rev 188758)
+++ trunk/LayoutTests/ChangeLog 2015-08-21 18:26:23 UTC (rev 188759)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-08-21 Nan Wang <n_wang@apple.com>
+
+ [Mac] accessibility/selection-states.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=116637
+
+ Reviewed by Chris Fleizach.
+
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2015-08-20 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: add a regression test for the fix introduced in r188679
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (188758 => 188759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-08-21 18:10:17 UTC (rev 188758)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-08-21 18:26:23 UTC (rev 188759)
</span><span class="lines">@@ -37,9 +37,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/116636 accessibility/document-attributes.html [ Failure ]
</span><span class="cx">
</span><del>-# Accessibility tests with missing AccessibilityController functionality.
-webkit.org/b/116637 accessibility/selection-states.html [ Failure ]
-
</del><span class="cx"> # Accessibility tests for notifications that don't exist or aren't needed on Mac OS X.
</span><span class="cx"> accessibility/aria-checkbox-sends-notification.html
</span><span class="cx"> accessibility/aria-switch-sends-notification.html
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188758 => 188759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-21 18:10:17 UTC (rev 188758)
+++ trunk/Source/WebCore/ChangeLog 2015-08-21 18:26:23 UTC (rev 188759)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-08-21 Nan Wang <n_wang@apple.com>
+
+ [Mac] accessibility/selection-states.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=116637
+
+ Reviewed by Chris Fleizach.
+
+ Added accessibilityAttributeValue callback for isMultiSelectable attribute.
+
+ Updated expectation for accessibility/selection-states.html on mac.
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
</ins><span class="cx"> 2015-08-21 Jonathan Davis <jond@apple.com>
</span><span class="cx">
</span><span class="cx"> Fixed status features JSON formatting.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (188758 => 188759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-08-21 18:10:17 UTC (rev 188758)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-08-21 18:26:23 UTC (rev 188759)
</span><span class="lines">@@ -229,6 +229,10 @@
</span><span class="cx"> #define NSAccessibilityExpandedTextValueAttribute @"AXExpandedTextValue"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#ifndef NSAccessibilityIsMultiSelectableAttribute
+#define NSAccessibilityIsMultiSelectableAttribute @"AXIsMultiSelectable"
+#endif
+
</ins><span class="cx"> #define NSAccessibilityDOMIdentifierAttribute @"AXDOMIdentifier"
</span><span class="cx"> #define NSAccessibilityDOMClassListAttribute @"AXDOMClassList"
</span><span class="cx">
</span><span class="lines">@@ -3039,6 +3043,10 @@
</span><span class="cx"> if (m_object->isWebArea() && [attributeName isEqualToString:NSAccessibilityCaretBrowsingEnabledAttribute])
</span><span class="cx"> return [NSNumber numberWithBool:m_object->caretBrowsingEnabled()];
</span><span class="cx">
</span><ins>+ // Multi-selectable
+ if ([attributeName isEqualToString:NSAccessibilityIsMultiSelectableAttribute])
+ return [NSNumber numberWithBool:m_object->isMultiSelectable()];
+
</ins><span class="cx"> return nil;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (188758 => 188759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-08-21 18:10:17 UTC (rev 188758)
+++ trunk/Tools/ChangeLog 2015-08-21 18:26:23 UTC (rev 188759)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-08-21 Nan Wang <n_wang@apple.com>
+
+ [Mac] accessibility/selection-states.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=116637
+
+ Reviewed by Chris Fleizach.
+
+ Implemented isSelectable() and isMultiSelectable().
+
+ * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+ (AccessibilityUIElement::isSelectable):
+ (AccessibilityUIElement::isMultiSelectable):
+ (AccessibilityUIElement::isSelectedOptionActive):
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR::AccessibilityUIElement::isSelectable):
+ (WTR::AccessibilityUIElement::isMultiSelectable):
+ (WTR::AccessibilityUIElement::isVisible):
+
</ins><span class="cx"> 2015-08-21 Jason Marcell <jmarcell@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix iteration over repositories on bot watcher's dashboard.
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacAccessibilityUIElementMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (188758 => 188759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-08-21 18:10:17 UTC (rev 188758)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-08-21 18:26:23 UTC (rev 188759)
</span><span class="lines">@@ -1463,14 +1463,22 @@
</span><span class="cx">
</span><span class="cx"> bool AccessibilityUIElement::isSelectable() const
</span><span class="cx"> {
</span><del>- // FIXME: implement
- return false;
</del><ins>+ bool result = false;
+ BEGIN_AX_OBJC_EXCEPTIONS
+ result = [m_element accessibilityIsAttributeSettable:NSAccessibilitySelectedAttribute];
+ END_AX_OBJC_EXCEPTIONS
+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityUIElement::isMultiSelectable() const
</span><span class="cx"> {
</span><del>- // FIXME: implement
- return false;
</del><ins>+ BOOL result = NO;
+ BEGIN_AX_OBJC_EXCEPTIONS
+ id value = [m_element accessibilityAttributeValue:@"AXIsMultiSelectable"];
+ if ([value isKindOfClass:[NSNumber class]])
+ result = [value boolValue];
+ END_AX_OBJC_EXCEPTIONS
+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityUIElement::isSelectedOptionActive() const
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundlemacAccessibilityUIElementMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (188758 => 188759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-08-21 18:10:17 UTC (rev 188758)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-08-21 18:26:23 UTC (rev 188759)
</span><span class="lines">@@ -1504,14 +1504,22 @@
</span><span class="cx">
</span><span class="cx"> bool AccessibilityUIElement::isSelectable() const
</span><span class="cx"> {
</span><del>- // FIXME: implement
- return false;
</del><ins>+ bool result = false;
+ BEGIN_AX_OBJC_EXCEPTIONS
+ result = [m_element accessibilityIsAttributeSettable:NSAccessibilitySelectedAttribute];
+ END_AX_OBJC_EXCEPTIONS
+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityUIElement::isMultiSelectable() const
</span><span class="cx"> {
</span><del>- // FIXME: implement
- return false;
</del><ins>+ BOOL result = NO;
+ BEGIN_AX_OBJC_EXCEPTIONS
+ id value = [m_element accessibilityAttributeValue:@"AXIsMultiSelectable"];
+ if ([value isKindOfClass:[NSNumber class]])
+ result = [value boolValue];
+ END_AX_OBJC_EXCEPTIONS
+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityUIElement::isVisible() const
</span></span></pre>
</div>
</div>
</body>
</html>