<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188751] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188751">188751</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-20 21:30:47 -0700 (Thu, 20 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Revise PlatformWebView ctor according to <a href="http://trac.webkit.org/projects/webkit/changeset/188718">r188718</a>
https://bugs.webkit.org/show_bug.cgi?id=148282
Source/WebKit2:
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-08-20
Reviewed by Gyuyoung Kim.
* PlatformEfl.cmake:
Tools:
This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
instead of WKContextRef and WKPageGroupRef respectively.
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-08-20
Reviewed by Gyuyoung Kim.
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2PlatformEflcmake">trunk/Source/WebKit2/PlatformEfl.cmake</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnereflPlatformWebViewEflcpp">trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (188750 => 188751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Source/WebKit2/ChangeLog 2015-08-21 04:30:47 UTC (rev 188751)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-08-20 Joonghun Park <jh718.park@samsung.com>
+
+ [EFL] Revise PlatformWebView ctor according to r188718
+ https://bugs.webkit.org/show_bug.cgi?id=148282
+
+ Reviewed by Gyuyoung Kim.
+
+ * PlatformEfl.cmake:
+
</ins><span class="cx"> 2015-08-20 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> GTK build fix after r188693.
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformEflcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PlatformEfl.cmake (188750 => 188751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PlatformEfl.cmake 2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Source/WebKit2/PlatformEfl.cmake 2015-08-21 04:30:47 UTC (rev 188751)
</span><span class="lines">@@ -65,6 +65,8 @@
</span><span class="cx"> UIProcess/BackingStore.cpp
</span><span class="cx"> UIProcess/DefaultUndoController.cpp
</span><span class="cx">
</span><ins>+ UIProcess/API/C/WKPageConfigurationRef.cpp
+
</ins><span class="cx"> UIProcess/API/C/CoordinatedGraphics/WKView.cpp
</span><span class="cx">
</span><span class="cx"> UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (188750 => 188751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Tools/ChangeLog 2015-08-21 04:30:47 UTC (rev 188751)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-08-20 Joonghun Park <jh718.park@samsung.com>
+
+ [EFL] Revise PlatformWebView ctor according to r188718
+ https://bugs.webkit.org/show_bug.cgi?id=148282
+
+ This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
+ instead of WKContextRef and WKPageGroupRef respectively.
+
+ Reviewed by Gyuyoung Kim.
+
+ * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
+ (WTR::PlatformWebView::PlatformWebView):
+
</ins><span class="cx"> 2015-08-20 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, changed Devin Rousso's email.
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnereflPlatformWebViewEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp (188750 => 188751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2015-08-21 04:30:47 UTC (rev 188751)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> return ecoreEvas;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PlatformWebView::PlatformWebView(WKContextRef context, WKPageGroupRef pageGroup, WKPageRef /* relatedPage */, const ViewOptions& options)
</del><ins>+PlatformWebView::PlatformWebView(WKPageConfigurationRef configuration, const ViewOptions& options)
</ins><span class="cx"> : m_options(options)
</span><span class="cx"> {
</span><span class="cx"> WKRetainPtr<WKStringRef> useFixedLayoutKey(AdoptWK, WKStringCreateWithUTF8CString("UseFixedLayout"));
</span><span class="lines">@@ -61,6 +61,8 @@
</span><span class="cx">
</span><span class="cx"> m_window = initEcoreEvas();
</span><span class="cx">
</span><ins>+ WKContextRef context = WKPageConfigurationGetContext(configuration);
+ WKPageGroupRef pageGroup = WKPageConfigurationGetPageGroup(configuration);
</ins><span class="cx"> m_view = EWKViewCreate(context, pageGroup, ecore_evas_get(m_window), /* smart */ 0);
</span><span class="cx">
</span><span class="cx"> WKPageSetUseFixedLayout(WKViewGetPage(EWKViewGetWKView(m_view)), m_usingFixedLayout);
</span></span></pre>
</div>
</div>
</body>
</html>