<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188708] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188708">188708</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2015-08-20 15:07:59 -0700 (Thu, 20 Aug 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Filtered frames should be styled differently in the Rendering Frames overview graph
https://bugs.webkit.org/show_bug.cgi?id=147421

Reviewed by Timothy Hatcher.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.representedObjectWasFiltered):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
Inform derived sidebar of tree element filter state changes.

* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.recordWasFiltered):
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.updateLayout):
Update filtered frame style when a record's state changes, and during layout.

* UserInterface/Views/TimelineOverview.js:
* UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype.recordWasFiltered):
Allow setting a record's filtered state for a given timeline in the overview.

* UserInterface/Views/TimelineRecordFrame.css:
(.timeline-record-frame.filtered &gt; .frame):
New filtered frame style.

* UserInterface/Views/TimelineRecordFrame.js:
(WebInspector.TimelineRecordFrame.prototype.get filtered):
(WebInspector.TimelineRecordFrame.prototype.set filtered):

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.recordWasFiltered):

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.representedObjectWasFiltered):
(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
Apply task filters to RenderingFrameTimelineRecords and their immediate children.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsRenderingFrameTimelineOverviewGraphjs">trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewGraphjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverviewGraph.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordFramecss">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordFramejs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordingContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/ChangeLog        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -1,3 +1,41 @@
</span><ins>+2015-08-20  Matt Baker  &lt;mattbaker@apple.com&gt;
+
+        Web Inspector: Filtered frames should be styled differently in the Rendering Frames overview graph
+        https://bugs.webkit.org/show_bug.cgi?id=147421
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/NavigationSidebarPanel.js:
+        (WebInspector.NavigationSidebarPanel.prototype.representedObjectWasFiltered):
+        (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
+        Inform derived sidebar of tree element filter state changes.
+
+        * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
+        (WebInspector.RenderingFrameTimelineOverviewGraph.prototype.recordWasFiltered):
+        (WebInspector.RenderingFrameTimelineOverviewGraph.prototype.updateLayout):
+        Update filtered frame style when a record's state changes, and during layout.
+
+        * UserInterface/Views/TimelineOverview.js:
+        * UserInterface/Views/TimelineOverviewGraph.js:
+        (WebInspector.TimelineOverviewGraph.prototype.recordWasFiltered):
+        Allow setting a record's filtered state for a given timeline in the overview.
+
+        * UserInterface/Views/TimelineRecordFrame.css:
+        (.timeline-record-frame.filtered &gt; .frame):
+        New filtered frame style.
+
+        * UserInterface/Views/TimelineRecordFrame.js:
+        (WebInspector.TimelineRecordFrame.prototype.get filtered):
+        (WebInspector.TimelineRecordFrame.prototype.set filtered):
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WebInspector.TimelineRecordingContentView.prototype.recordWasFiltered):
+
+        * UserInterface/Views/TimelineSidebarPanel.js:
+        (WebInspector.TimelineSidebarPanel.prototype.representedObjectWasFiltered):
+        (WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
+        Apply task filters to RenderingFrameTimelineRecords and their immediate children.
+
</ins><span class="cx"> 2015-08-20  Brian Burg  &lt;bburg@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: console assertion when hitting breakpoint after auto-recording ends
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -421,6 +421,11 @@
</span><span class="cx"> 
</span><span class="cx">     // Protected
</span><span class="cx"> 
</span><ins>+    representedObjectWasFiltered(representedObject, filtered)
+    {
+        // Implemented by subclasses if needed.
+    }
+
</ins><span class="cx">     pruneStaleResourceTreeElements()
</span><span class="cx">     {
</span><span class="cx">         if (this._checkForStaleResourcesTimeoutIdentifier) {
</span><span class="lines">@@ -525,7 +530,11 @@
</span><span class="cx">         // Update the whole tree.
</span><span class="cx">         var currentTreeElement = this._contentTreeOutline.children[0];
</span><span class="cx">         while (currentTreeElement &amp;&amp; !currentTreeElement.root) {
</span><ins>+            const currentTreeElementWasHidden = currentTreeElement.hidden;
</ins><span class="cx">             this.applyFiltersToTreeElement(currentTreeElement);
</span><ins>+            if (currentTreeElementWasHidden !== currentTreeElement.hidden)
+                this.representedObjectWasFiltered(currentTreeElement.representedObject, currentTreeElement.hidden);
+
</ins><span class="cx">             currentTreeElement = currentTreeElement.traverseNextTreeElement(false, null, dontPopulate);
</span><span class="cx">         }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsRenderingFrameTimelineOverviewGraphjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -74,6 +74,25 @@
</span><span class="cx">         this._framesPerSecondDividerMap.clear();
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    recordWasFiltered(record, filtered)
+    {
+        super.recordWasFiltered(record, filtered);
+
+        if (!(record instanceof WebInspector.RenderingFrameTimelineRecord))
+            return;
+
+        record[WebInspector.RenderingFrameTimelineOverviewGraph.RecordWasFilteredSymbol] = filtered;
+
+        // Set filtered style if the frame element is within the visible range.
+        const startIndex = Math.floor(this.startTime);
+        const endIndex = Math.min(Math.floor(this.endTime), this._renderingFrameTimeline.records.length - 1);
+        if (record.frameIndex &lt; startIndex || record.frameIndex &gt; endIndex)
+            return;
+
+        const frameIndex = record.frameIndex - startIndex;
+        this._timelineRecordFrames[frameIndex].filtered = filtered;
+    }
+
</ins><span class="cx">     updateLayout()
</span><span class="cx">     {
</span><span class="cx">         super.updateLayout();
</span><span class="lines">@@ -98,6 +117,7 @@
</span><span class="cx">             if (!timelineRecordFrame.element.parentNode)
</span><span class="cx">                 this.element.appendChild(timelineRecordFrame.element);
</span><span class="cx"> 
</span><ins>+            timelineRecordFrame.filtered = record[WebInspector.RenderingFrameTimelineOverviewGraph.RecordWasFilteredSymbol] || false;
</ins><span class="cx">             ++recordFrameIndex;
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="lines">@@ -246,5 +266,7 @@
</span><span class="cx">     }
</span><span class="cx"> };
</span><span class="cx"> 
</span><ins>+WebInspector.RenderingFrameTimelineOverviewGraph.RecordWasFilteredSymbol = Symbol(&quot;rendering-frame-overview-graph-record-was-filtered&quot;);
+
</ins><span class="cx"> WebInspector.RenderingFrameTimelineOverviewGraph.MaximumGraphHeightSeconds = 0.037;
</span><span class="cx"> WebInspector.RenderingFrameTimelineOverviewGraph.MinimumGraphHeightSeconds = 0.0185;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -279,6 +279,18 @@
</span><span class="cx">         this.scrollStartTime = marker.time - (this.visibleDuration / 2);
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    recordWasFiltered(timeline, record, filtered)
+    {
+        console.assert(this.canShowTimeline(timeline), timeline);
+
+        let overviewGraph = this._timelineOverviewGraphsMap.get(timeline);
+        console.assert(overviewGraph, &quot;Missing overview graph for timeline type &quot; + timeline.type);
+        if (!overviewGraph)
+            return;
+
+        overviewGraph.recordWasFiltered(record, filtered);
+    }
+
</ins><span class="cx">     selectRecord(timeline, record)
</span><span class="cx">     {
</span><span class="cx">         console.assert(this.canShowTimeline(timeline), timeline);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewGraphjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverviewGraph.js (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverviewGraph.js        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverviewGraph.js        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -171,6 +171,11 @@
</span><span class="cx">         // Implemented by sub-classes if needed.
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    recordWasFiltered(record, filtered)
+    {
+        // Implemented by sub-classes if needed.
+    }
+
</ins><span class="cx">     updateLayout()
</span><span class="cx">     {
</span><span class="cx">         if (this._scheduledLayoutUpdateIdentifier) {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordFramecss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.css (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.css        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.css        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -57,6 +57,10 @@
</span><span class="cx">     background: -webkit-linear-gradient(left, hsl(0, 0%, 96%), hsl(0, 0%, 96%)) no-repeat 1px -1px;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+.timeline-record-frame.filtered &gt; .frame {
+    opacity: 0.35;
+}
+
</ins><span class="cx"> .timeline-record-frame.selected &gt; .frame {
</span><span class="cx">     box-shadow: 0 -1px 0 white;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordFramejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> 
</span><span class="cx">         this._graphDataSource = graphDataSource;
</span><span class="cx">         this._record = record || null;
</span><ins>+        this._filtered = false;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     // Public
</span><span class="lines">@@ -66,6 +67,20 @@
</span><span class="cx">         this._element.classList.toggle(&quot;selected&quot;);
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    get filtered()
+    {
+        return this._filtered;
+    }
+
+    set filtered(x)
+    {
+        if (this._filtered === x)
+            return;
+
+        this._filtered = x;
+        this._element.classList.toggle(&quot;filtered&quot;);
+    }
+
</ins><span class="cx">     refresh(graphDataSource)
</span><span class="cx">     {
</span><span class="cx">         if (!this._record)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordingContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -247,6 +247,14 @@
</span><span class="cx">         this.currentTimelineView.filterDidChange();
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    recordWasFiltered(record, filtered)
+    {
+        if (!this.currentTimelineView)
+            return;
+
+        this._currentTimelineOverview.recordWasFiltered(this.currentTimelineView.representedObject, record, filtered);
+    }
+
</ins><span class="cx">     matchTreeElementAgainstCustomFilters(treeElement)
</span><span class="cx">     {
</span><span class="cx">         if (this.currentTimelineView &amp;&amp; !this.currentTimelineView.matchTreeElementAgainstCustomFilters(treeElement))
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (188707 => 188708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js        2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js        2015-08-20 22:07:59 UTC (rev 188708)
</span><span class="lines">@@ -377,6 +377,14 @@
</span><span class="cx"> 
</span><span class="cx">     // Protected
</span><span class="cx"> 
</span><ins>+    representedObjectWasFiltered(representedObject, filtered)
+    {
+        super.representedObjectWasFiltered(representedObject, filtered);
+
+        if (representedObject instanceof WebInspector.TimelineRecord)
+            this._displayedContentView.recordWasFiltered(representedObject, filtered);
+    }
+
</ins><span class="cx">     updateFilter()
</span><span class="cx">     {
</span><span class="cx">         super.updateFilter();
</span><span class="lines">@@ -402,14 +410,18 @@
</span><span class="cx">             if (!treeElement)
</span><span class="cx">                 return false;
</span><span class="cx"> 
</span><del>-            var visible = false;
-            if (!(treeElement.record instanceof WebInspector.RenderingFrameTimelineRecord)) {
-                var taskType = WebInspector.RenderingFrameTimelineRecord.taskTypeForTimelineRecord(treeElement.record);
-                if (!this._renderingFrameTaskFilter.has(taskType))
-                    visible = true;
-            }
</del><ins>+            let records;
+            if (treeElement.record instanceof WebInspector.RenderingFrameTimelineRecord)
+                records = treeElement.record.children;
+            else
+                records = [treeElement.record];
</ins><span class="cx"> 
</span><del>-            if (!visible)
</del><ins>+            const filtered = records.every(function(record) {
+                var taskType = WebInspector.RenderingFrameTimelineRecord.taskTypeForTimelineRecord(record);
+                return this._renderingFrameTaskFilter.has(taskType);
+            }, this);
+
+            if (filtered)
</ins><span class="cx">                 return false;
</span><span class="cx">         }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>