<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188658] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188658">188658</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-08-19 16:04:52 -0700 (Wed, 19 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>outline-style: auto leaves bits behind on strava's flyby view.
https://bugs.webkit.org/show_bug.cgi?id=148178
Reviewed by Simon Fraser.
RenderView::m_maximalOutlineSize should include outline-offset.
Source/WebCore:
Test: fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html
* rendering/RenderElement.cpp:
(WebCore::RenderElement::computeMaxOutlineSize):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
LayoutTests:
* fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint-expected.txt: Added.
* fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderElementcpp">trunk/Source/WebCore/rendering/RenderElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepaintoutlineautowithwidthlessthanfocusringwidthandoffsetrepaintexpectedtxt">trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepaintoutlineautowithwidthlessthanfocusringwidthandoffsetrepainthtml">trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (188657 => 188658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-08-19 22:33:25 UTC (rev 188657)
+++ trunk/LayoutTests/ChangeLog 2015-08-19 23:04:52 UTC (rev 188658)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2015-08-19 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ outline-style: auto leaves bits behind on strava's flyby view.
+ https://bugs.webkit.org/show_bug.cgi?id=148178
+
+ Reviewed by Simon Fraser.
+
+ RenderView::m_maximalOutlineSize should include outline-offset.
+
+ * fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint-expected.txt: Added.
+ * fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html: Added.
+
+2015-08-19 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Cleanup outline-style: auto painting.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=148159
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintoutlineautowithwidthlessthanfocusringwidthandoffsetrepaintexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint-expected.txt (0 => 188658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint-expected.txt 2015-08-19 23:04:52 UTC (rev 188658)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+PASS window.internals.repaintRectsAsText().indexOf('3 5') is not -1
+PASS window.internals.repaintRectsAsText().indexOf('3 45') is not -1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepaintoutlineautowithwidthlessthanfocusringwidthandoffsetrepainthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html (0 => 188658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html 2015-08-19 23:04:52 UTC (rev 188658)
</span><span class="lines">@@ -0,0 +1,38 @@
</span><ins>+<html>
+<script>jsTestIsAsync = true;</script>
+<script src="../../resources/js-test-pre.js"></script>
+<head>
+<title>This tests that outline repaint rect for focus ring is correct.</title>
+<style>
+div {
+ position: absolute;
+ top: 10px;
+ height: 10px;
+ width: 10px;
+ outline-style: auto;
+ outline-width: 1px;
+ outline-offset: 2px;
+}
+</style>
+</head>
+<body>
+<div id=foo></div>
+</body>
+<script>
+setTimeout(
+ function() {
+ if (window.internals)
+ internals.startTrackingRepaints();
+ document.getElementById("foo").style.top = "50px";
+ document.body.offsetWidth;
+
+ if (window.internals) {
+ shouldNotBe("window.internals.repaintRectsAsText().indexOf('3 5')", "-1");
+ shouldNotBe("window.internals.repaintRectsAsText().indexOf('3 45')", "-1");
+ internals.stopTrackingRepaints();
+ }
+ finishJSTest();
+ }, 0);
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188657 => 188658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-19 22:33:25 UTC (rev 188657)
+++ trunk/Source/WebCore/ChangeLog 2015-08-19 23:04:52 UTC (rev 188658)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-08-19 Zalan Bujtas <zalan@apple.com>
+
+ outline-style: auto leaves bits behind on strava's flyby view.
+ https://bugs.webkit.org/show_bug.cgi?id=148178
+
+ Reviewed by Simon Fraser.
+
+ RenderView::m_maximalOutlineSize should include outline-offset.
+
+ Test: fast/repaint/outline-auto-with-width-less-than-focus-ring-width-and-offset-repaint.html
+
+ * rendering/RenderElement.cpp:
+ (WebCore::RenderElement::computeMaxOutlineSize):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::adjustRectForOutlineAndShadow):
+
</ins><span class="cx"> 2015-08-19 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix errors on bots.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (188657 => 188658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderElement.cpp 2015-08-19 22:33:25 UTC (rev 188657)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp 2015-08-19 23:04:52 UTC (rev 188658)
</span><span class="lines">@@ -372,7 +372,7 @@
</span><span class="cx"> return;
</span><span class="cx"> int maxOutlineSize = m_style->outlineSize();
</span><span class="cx"> if (m_style->outlineStyleIsAuto())
</span><del>- maxOutlineSize = std::max(theme().platformFocusRingWidth(), maxOutlineSize);
</del><ins>+ maxOutlineSize = std::max(theme().platformFocusRingWidth() + m_style->outlineOffset(), maxOutlineSize);
</ins><span class="cx">
</span><span class="cx"> if (maxOutlineSize < maximalOutlineSize(PaintPhaseOutline))
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (188657 => 188658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2015-08-19 22:33:25 UTC (rev 188657)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2015-08-19 23:04:52 UTC (rev 188658)
</span><span class="lines">@@ -1918,7 +1918,7 @@
</span><span class="cx"> {
</span><span class="cx"> int outlineSize = outlineStyleForRepaint().outlineSize();
</span><span class="cx"> if (outlineStyleForRepaint().outlineStyleIsAuto())
</span><del>- outlineSize = std::max(theme().platformFocusRingWidth(), outlineSize);
</del><ins>+ outlineSize = std::max(theme().platformFocusRingWidth() + outlineStyleForRepaint().outlineOffset(), outlineSize);
</ins><span class="cx"> if (const ShadowData* boxShadow = style().boxShadow()) {
</span><span class="cx"> boxShadow->adjustRectForShadow(rect, outlineSize);
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>