<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188592] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188592">188592</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-08-18 12:24:15 -0700 (Tue, 18 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>http/tests/navigation/page-cache-iframe-provisional-load.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=148133
Reviewed by Alexey Proskuryakov.
http/tests/navigation/page-cache-iframe-provisional-load.html would fail if
the slow load would finish before navigating away. To greatly reduce the
chances of it happening, increase the slow load delay from 100ms to 3s.
Also make the test faster by using page-cache-helper.html instead of
page-cache-helper-slow.html. The idea of using a slow helper was for the
load to potentially finish while the page was in the PageCache. However,
now that we've increased the slow load delay, this will no longer happen.
* http/tests/navigation/page-cache-iframe-provisional-load.html:
* http/tests/navigation/resources/page-cache-helper-slow.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationpagecacheiframeprovisionalloadhtml">trunk/LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestshttptestsnavigationresourcespagecachehelperslowhtml">trunk/LayoutTests/http/tests/navigation/resources/page-cache-helper-slow.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (188591 => 188592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-08-18 19:19:49 UTC (rev 188591)
+++ trunk/LayoutTests/ChangeLog 2015-08-18 19:24:15 UTC (rev 188592)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-08-18 Chris Dumez <cdumez@apple.com>
+
+ http/tests/navigation/page-cache-iframe-provisional-load.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=148133
+
+ Reviewed by Alexey Proskuryakov.
+
+ http/tests/navigation/page-cache-iframe-provisional-load.html would fail if
+ the slow load would finish before navigating away. To greatly reduce the
+ chances of it happening, increase the slow load delay from 100ms to 3s.
+
+ Also make the test faster by using page-cache-helper.html instead of
+ page-cache-helper-slow.html. The idea of using a slow helper was for the
+ load to potentially finish while the page was in the PageCache. However,
+ now that we've increased the slow load delay, this will no longer happen.
+
+ * http/tests/navigation/page-cache-iframe-provisional-load.html:
+ * http/tests/navigation/resources/page-cache-helper-slow.html: Removed.
+
</ins><span class="cx"> 2015-08-18 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Honor the 'trak' table by opting in via text-rendering: optimizeLegibility
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationpagecacheiframeprovisionalloadhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html (188591 => 188592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html 2015-08-18 19:19:49 UTC (rev 188591)
+++ trunk/LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html 2015-08-18 19:24:15 UTC (rev 188592)
</span><span class="lines">@@ -26,21 +26,17 @@
</span><span class="cx"> }, false);
</span><span class="cx">
</span><span class="cx"> window.addEventListener("pagehide", function(event) {
</span><del>- debug("pagehide");
</del><ins>+ testFailed("pagehide - Page went into PageCache");
</ins><span class="cx"> }, false);
</span><span class="cx">
</span><span class="cx"> function loadSubframeAndNavigateAway()
</span><span class="cx"> {
</span><span class="cx"> // Force a back navigation back to this page.
</span><span class="cx"> window.sessionStorage.page_cache_provisional_load_test_started = true;
</span><del>- window.location.href = "resources/page-cache-helper-slow.html";
</del><ins>+ window.location.href = "resources/page-cache-helper.html";
</ins><span class="cx">
</span><span class="cx"> var testFrame = document.getElementById("testFrame");
</span><del>- testFrame.src = "http://127.0.0.1:8000/navigation/resources/slow-resource.pl?delay=100";
-
- // If the page goes into the page cache and the frame keeps loading while in the cache,
- // the following will cause crashes.
- testFrame.onload = function() { document.getElementById("testFrame").remove(); };
</del><ins>+ testFrame.src = "http://127.0.0.1:8000/navigation/resources/slow-resource.pl?delay=3000";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> window.addEventListener('load', function() {
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationresourcespagecachehelperslowhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/http/tests/navigation/resources/page-cache-helper-slow.html (188591 => 188592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/resources/page-cache-helper-slow.html 2015-08-18 19:19:49 UTC (rev 188591)
+++ trunk/LayoutTests/http/tests/navigation/resources/page-cache-helper-slow.html 2015-08-18 19:24:15 UTC (rev 188592)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-This page should go back. If a test outputs the contents of this
-page, then the test page failed to enter the page cache.
-<script>
- window.addEventListener("load", function() {
- setTimeout(function() {
- history.back();
- }, 500);
- }, false);
-</script>
</del></span></pre>
</div>
</div>
</body>
</html>