<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188613] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188613">188613</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-18 17:43:48 -0700 (Tue, 18 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix a rare flakiness in svg/animations/svgPreserveAspectRatio-animation-1.html
https://bugs.webkit.org/show_bug.cgi?id=148149
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-08-18
Reviewed by Tim Horton.
Do not sample the SVG animation at the middle of the animation period. At
that time, the SVG animation test script changes the value of the animated
attribute from the from-value to the to-value. It is safer to sample
immediately before and after the middle of the animation period.
* svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:
* svg/animations/svgPreserveAspectRatio-animation-1-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestssvganimationsscripttestssvgPreserveAspectRatioanimation1js">trunk/LayoutTests/svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js</a></li>
<li><a href="#trunkLayoutTestssvganimationssvgPreserveAspectRatioanimation1expectedtxt">trunk/LayoutTests/svg/animations/svgPreserveAspectRatio-animation-1-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (188612 => 188613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-08-19 00:32:58 UTC (rev 188612)
+++ trunk/LayoutTests/ChangeLog 2015-08-19 00:43:48 UTC (rev 188613)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-08-18 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Fix a rare flakiness in svg/animations/svgPreserveAspectRatio-animation-1.html
+ https://bugs.webkit.org/show_bug.cgi?id=148149
+
+ Reviewed by Tim Horton.
+
+ Do not sample the SVG animation at the middle of the animation period. At
+ that time, the SVG animation test script changes the value of the animated
+ attribute from the from-value to the to-value. It is safer to sample
+ immediately before and after the middle of the animation period.
+
+ * svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:
+ * svg/animations/svgPreserveAspectRatio-animation-1-expected.txt:
+
</ins><span class="cx"> 2015-08-18 Wenson Hsieh <wenson_hsieh@apple.com>
</span><span class="cx">
</span><span class="cx"> Search input results and clear icons are misaligned when padding is added
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsscripttestssvgPreserveAspectRatioanimation1js"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js (188612 => 188613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js 2015-08-19 00:32:58 UTC (rev 188612)
+++ trunk/LayoutTests/svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js 2015-08-19 00:43:48 UTC (rev 188613)
</span><span class="lines">@@ -51,7 +51,8 @@
</span><span class="cx"> const expectedValues = [
</span><span class="cx"> // [animationId, time, sampleCallback]
</span><span class="cx"> ["animation", 0.0, sample1],
</span><del>- ["animation", 2.0, sample2],
</del><ins>+ ["animation", 1.999, sample2],
+ ["animation", 2.001, sample3],
</ins><span class="cx"> ["animation", 3.999, sample3],
</span><span class="cx"> ["animation", 4.001, sample1]
</span><span class="cx"> ];
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationssvgPreserveAspectRatioanimation1expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/animations/svgPreserveAspectRatio-animation-1-expected.txt (188612 => 188613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/svgPreserveAspectRatio-animation-1-expected.txt 2015-08-19 00:32:58 UTC (rev 188612)
+++ trunk/LayoutTests/svg/animations/svgPreserveAspectRatio-animation-1-expected.txt 2015-08-19 00:43:48 UTC (rev 188613)
</span><span class="lines">@@ -17,6 +17,10 @@
</span><span class="cx"> PASS rootSVGElement.preserveAspectRatio.animVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
</span><span class="cx"> PASS rootSVGElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN
</span><span class="cx"> PASS rootSVGElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
</span><ins>+PASS rootSVGElement.preserveAspectRatio.animVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMID
+PASS rootSVGElement.preserveAspectRatio.animVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS rootSVGElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN
+PASS rootSVGElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
</ins><span class="cx"> PASS rootSVGElement.preserveAspectRatio.animVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN
</span><span class="cx"> PASS rootSVGElement.preserveAspectRatio.animVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
</span><span class="cx"> PASS rootSVGElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN
</span></span></pre>
</div>
</div>
</body>
</html>