<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188542] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188542">188542</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2015-08-17 14:40:30 -0700 (Mon, 17 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Cleanup the builtin JavaScript files
https://bugs.webkit.org/show_bug.cgi?id=147382
Reviewed by Geoffrey Garen.
* builtins/Array.prototype.js:
* builtins/ArrayConstructor.js:
* builtins/ArrayIterator.prototype.js:
* builtins/Function.prototype.js:
* builtins/Iterator.prototype.js:
* builtins/ObjectConstructor.js:
* builtins/StringConstructor.js:
* builtins/StringIterator.prototype.js:
Unify the style of the built JavaScript files.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsArrayprototypejs">trunk/Source/JavaScriptCore/builtins/Array.prototype.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsArrayConstructorjs">trunk/Source/JavaScriptCore/builtins/ArrayConstructor.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsArrayIteratorprototypejs">trunk/Source/JavaScriptCore/builtins/ArrayIterator.prototype.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsFunctionprototypejs">trunk/Source/JavaScriptCore/builtins/Function.prototype.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsIteratorprototypejs">trunk/Source/JavaScriptCore/builtins/Iterator.prototype.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsObjectConstructorjs">trunk/Source/JavaScriptCore/builtins/ObjectConstructor.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsStringConstructorjs">trunk/Source/JavaScriptCore/builtins/StringConstructor.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsStringIteratorprototypejs">trunk/Source/JavaScriptCore/builtins/StringIterator.prototype.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-07-28 Sam Weinig <sam@webkit.org>
+
+ Cleanup the builtin JavaScript files
+ https://bugs.webkit.org/show_bug.cgi?id=147382
+
+ Reviewed by Geoffrey Garen.
+
+ * builtins/Array.prototype.js:
+ * builtins/ArrayConstructor.js:
+ * builtins/ArrayIterator.prototype.js:
+ * builtins/Function.prototype.js:
+ * builtins/Iterator.prototype.js:
+ * builtins/ObjectConstructor.js:
+ * builtins/StringConstructor.js:
+ * builtins/StringIterator.prototype.js:
+ Unify the style of the built JavaScript files.
+
</ins><span class="cx"> 2015-08-17 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Move some commands from ./CMakeLists.txt to Source/cmake
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsArrayprototypejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/Array.prototype.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/Array.prototype.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/Array.prototype.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> function reduce(callback /*, initialValue */)
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.reduce requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -64,6 +65,7 @@
</span><span class="cx"> function reduceRight(callback /*, initialValue */)
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.reduceRight requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -98,8 +100,10 @@
</span><span class="cx"> return accumulator;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function every(callback /*, thisArg */) {
</del><ins>+function every(callback /*, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.every requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -124,8 +128,10 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function forEach(callback /*, thisArg */) {
</del><ins>+function forEach(callback /*, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.forEach requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -146,8 +152,10 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function filter(callback /*, thisArg */) {
</del><ins>+function filter(callback /*, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.filter requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -175,8 +183,10 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function map(callback /*, thisArg */) {
</del><ins>+function map(callback /*, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.map requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -202,8 +212,10 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function some(callback /*, thisArg */) {
</del><ins>+function some(callback /*, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.some requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -229,6 +241,7 @@
</span><span class="cx"> function fill(value /* [, start [, end]] */)
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.fill requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -267,8 +280,10 @@
</span><span class="cx"> return O;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function find(callback /*, thisArg */) {
</del><ins>+function find(callback /*, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.find requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -290,8 +305,10 @@
</span><span class="cx"> return undefined;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function findIndex(callback /*, thisArg */) {
</del><ins>+function findIndex(callback /*, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.findIndex requires that |this| not be null");
</span><span class="cx">
</span><span class="lines">@@ -312,8 +329,10 @@
</span><span class="cx"> return -1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function includes(searchElement /*, fromIndex*/) {
</del><ins>+function includes(searchElement /*, fromIndex*/)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> if (this === null)
</span><span class="cx"> throw new @TypeError("Array.prototype.includes requires that |this| not be null");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsArrayConstructorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/ArrayConstructor.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/ArrayConstructor.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/ArrayConstructor.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -36,7 +36,8 @@
</span><span class="cx"> return array;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function from(items /*, mapFn, thisArg */) {
</del><ins>+function from(items /*, mapFn, thisArg */)
+{
</ins><span class="cx"> "use strict";
</span><span class="cx">
</span><span class="cx"> var thisObj = this;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsArrayIteratorprototypejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/ArrayIterator.prototype.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/ArrayIterator.prototype.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/ArrayIterator.prototype.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -23,7 +23,8 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-function next() {
</del><ins>+function next()
+{
</ins><span class="cx"> "use strict";
</span><span class="cx">
</span><span class="cx"> if (this == null)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsFunctionprototypejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/Function.prototype.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/Function.prototype.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/Function.prototype.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -23,12 +23,16 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-function call(thisArgument) {
</del><ins>+function call(thisArgument)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> return this.@call(...arguments);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function apply(thisValue, argumentValues) {
</del><ins>+function apply(thisValue, argumentValues)
+{
</ins><span class="cx"> "use strict";
</span><ins>+
</ins><span class="cx"> return this.@apply(thisValue, argumentValues);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsIteratorprototypejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/Iterator.prototype.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/Iterator.prototype.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/Iterator.prototype.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx">
</span><span class="cx"> function symbolIterator()
</span><span class="cx"> {
</span><del>- 'use strict';
</del><ins>+ "use strict";
+
</ins><span class="cx"> return this;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsObjectConstructorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/ObjectConstructor.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/ObjectConstructor.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/ObjectConstructor.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -23,7 +23,8 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-function assign(target/*[*/, /*...*/sources/*] */) {
</del><ins>+function assign(target/*[*/, /*...*/sources/*] */)
+{
</ins><span class="cx"> "use strict";
</span><span class="cx">
</span><span class="cx"> if (target == null)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsStringConstructorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/StringConstructor.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/StringConstructor.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/StringConstructor.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -23,7 +23,8 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-function raw(template) {
</del><ins>+function raw(template)
+{
</ins><span class="cx"> "use strict";
</span><span class="cx">
</span><span class="cx"> if (template === null || template === undefined)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsStringIteratorprototypejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/StringIterator.prototype.js (188541 => 188542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/StringIterator.prototype.js 2015-08-17 20:39:04 UTC (rev 188541)
+++ trunk/Source/JavaScriptCore/builtins/StringIterator.prototype.js 2015-08-17 21:40:30 UTC (rev 188542)
</span><span class="lines">@@ -23,7 +23,8 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-function next() {
</del><ins>+function next()
+{
</ins><span class="cx"> "use strict";
</span><span class="cx">
</span><span class="cx"> if (this == null)
</span></span></pre>
</div>
</div>
</body>
</html>