<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188428] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188428">188428</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-13 19:14:09 -0700 (Thu, 13 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move some commands from ./CMakeLists.txt to Source/cmake
https://bugs.webkit.org/show_bug.cgi?id=148003
Patch by Alex Christensen <achristensen@webkit.org> on 2015-08-13
Reviewed by Brent Fulgham.
* CMakeLists.txt:
.:
Moved functionality to WebKitCommon.cmake and WebKitFS.cmake and made conditional
so we can change directory structure from command line parameters.
* Source/cmake/WebKitCommon.cmake: Added.
* Source/cmake/WebKitFS.cmake:
Source/JavaScriptCore:
Added commands needed to build JSC by itself.
Source/WebCore:
Added commands needed to build WebCore by itself.
Source/WebKit:
Added some commands needed to build WebKit by itself.
Source/WTF:
Added commands needed to build WTF by itself.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkCMakeListstxt">trunk/CMakeLists.txt</a></li>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreCMakeListstxt">trunk/Source/JavaScriptCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceWTFCMakeListstxt">trunk/Source/WTF/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitCMakeListstxt">trunk/Source/WebKit/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourcecmakeWebKitFScmake">trunk/Source/cmake/WebKitFS.cmake</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourcecmakeWebKitCommoncmake">trunk/Source/cmake/WebKitCommon.cmake</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/CMakeLists.txt (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/CMakeLists.txt 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/CMakeLists.txt 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,28 +1,6 @@
</span><span class="cx"> cmake_minimum_required(VERSION 2.8.12)
</span><span class="cx"> project(WebKit)
</span><span class="cx">
</span><del>-# -----------------------------------------------------------------------------
-# Default library type
-# -----------------------------------------------------------------------------
-set(BMALLOC_DIR "${CMAKE_SOURCE_DIR}/Source/bmalloc")
-set(WTF_DIR "${CMAKE_SOURCE_DIR}/Source/WTF")
-set(JAVASCRIPTCORE_DIR "${CMAKE_SOURCE_DIR}/Source/JavaScriptCore")
-set(WEBCORE_DIR "${CMAKE_SOURCE_DIR}/Source/WebCore")
-set(WEBKIT_DIR "${CMAKE_SOURCE_DIR}/Source/WebKit")
-set(WEBKIT2_DIR "${CMAKE_SOURCE_DIR}/Source/WebKit2")
-set(THIRDPARTY_DIR "${CMAKE_SOURCE_DIR}/Source/ThirdParty")
-
-set(TOOLS_DIR "${CMAKE_SOURCE_DIR}/Tools")
-
-set(DERIVED_SOURCES_DIR "${CMAKE_BINARY_DIR}/DerivedSources")
-set(DERIVED_SOURCES_JAVASCRIPTCORE_DIR "${CMAKE_BINARY_DIR}/DerivedSources/JavaScriptCore")
-set(DERIVED_SOURCES_WEBCORE_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebCore")
-set(DERIVED_SOURCES_WEBKITLEGACY_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebKitLegacy")
-set(DERIVED_SOURCES_WEBKIT_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebKit")
-set(DERIVED_SOURCES_WEBKIT2_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebKit2")
-set(DERIVED_SOURCES_WEBINSPECTORUI_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebInspectorUI")
-set(DERIVED_SOURCES_WTF_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WTF")
-
</del><span class="cx"> set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/Source/cmake")
</span><span class="cx">
</span><span class="cx"> if (NOT DEFINED ENABLE_WEBKIT)
</span></span></pre></div>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/ChangeLog 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-08-13 Alex Christensen <achristensen@webkit.org>
+
+ Move some commands from ./CMakeLists.txt to Source/cmake
+ https://bugs.webkit.org/show_bug.cgi?id=148003
+
+ Reviewed by Brent Fulgham.
+
+ * CMakeLists.txt:
+ Moved functionality to WebKitCommon.cmake and WebKitFS.cmake and made conditional
+ so we can change directory structure from command line parameters.
+ * Source/cmake/WebKitCommon.cmake: Added.
+ * Source/cmake/WebKitFS.cmake:
+
</ins><span class="cx"> 2015-08-13 Wenson Hsieh <wenson_hsieh@apple.com>
</span><span class="cx">
</span><span class="cx"> A focused node should not be assisted when handling touch events synchronously
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/CMakeLists.txt (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/CMakeLists.txt 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/JavaScriptCore/CMakeLists.txt 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,6 @@
</span><ins>+cmake_minimum_required(VERSION 2.8.12)
+include(WebKitCommon)
+
</ins><span class="cx"> set(JavaScriptCore_INCLUDE_DIRECTORIES
</span><span class="cx"> "${CMAKE_BINARY_DIR}"
</span><span class="cx"> "${JAVASCRIPTCORE_DIR}"
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-08-13 Alex Christensen <achristensen@webkit.org>
+
+ Move some commands from ./CMakeLists.txt to Source/cmake
+ https://bugs.webkit.org/show_bug.cgi?id=148003
+
+ Reviewed by Brent Fulgham.
+
+ * CMakeLists.txt:
+ Added commands needed to build JSC by itself.
+
</ins><span class="cx"> 2015-08-13 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Unify JSParserCodeType, FunctionParseMode and ModuleParseMode into SourceParseMode
</span></span></pre></div>
<a id="trunkSourceWTFCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/CMakeLists.txt (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/CMakeLists.txt 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/WTF/CMakeLists.txt 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1 +1,4 @@
</span><ins>+cmake_minimum_required(VERSION 2.8.12)
+include(WebKitCommon)
+
</ins><span class="cx"> add_subdirectory(wtf)
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/WTF/ChangeLog 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-08-13 Alex Christensen <achristensen@webkit.org>
+
+ Move some commands from ./CMakeLists.txt to Source/cmake
+ https://bugs.webkit.org/show_bug.cgi?id=148003
+
+ Reviewed by Brent Fulgham.
+
+ * CMakeLists.txt:
+ Added commands needed to build WTF by itself.
+
</ins><span class="cx"> 2015-08-13 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> WorkQueue::dispatchAfter() on Windows fires early.
</span></span></pre></div>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/WebCore/CMakeLists.txt 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,6 @@
</span><ins>+cmake_minimum_required(VERSION 2.8.12)
+include(WebKitCommon)
+
</ins><span class="cx"> set(WebCore_INCLUDE_DIRECTORIES
</span><span class="cx"> "${WEBCORE_DIR}"
</span><span class="cx"> "${WEBCORE_DIR}/Modules/airplay"
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/WebCore/ChangeLog 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-08-13 Alex Christensen <achristensen@webkit.org>
+
+ Move some commands from ./CMakeLists.txt to Source/cmake
+ https://bugs.webkit.org/show_bug.cgi?id=148003
+
+ Reviewed by Brent Fulgham.
+
+ * CMakeLists.txt:
+ Added commands needed to build WebCore by itself.
+
</ins><span class="cx"> 2015-08-13 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Refactor and improve TextIndicator to prepare for tests
</span></span></pre></div>
<a id="trunkSourceWebKitCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/CMakeLists.txt (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/CMakeLists.txt 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/WebKit/CMakeLists.txt 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,6 @@
</span><ins>+cmake_minimum_required(VERSION 2.8.12)
+include(WebKitCommon)
+
</ins><span class="cx"> set(WebKit_SOURCES
</span><span class="cx"> )
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/WebKit/ChangeLog 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-08-13 Alex Christensen <achristensen@webkit.org>
+
+ Move some commands from ./CMakeLists.txt to Source/cmake
+ https://bugs.webkit.org/show_bug.cgi?id=148003
+
+ Reviewed by Brent Fulgham.
+
+ * CMakeLists.txt:
+ Added some commands needed to build WebKit by itself.
+
</ins><span class="cx"> 2015-08-12 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Fix Debug CMake builds on Windows
</span></span></pre></div>
<a id="trunkSourcecmakeWebKitCommoncmake"></a>
<div class="addfile"><h4>Added: trunk/Source/cmake/WebKitCommon.cmake (0 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/WebKitCommon.cmake (rev 0)
+++ trunk/Source/cmake/WebKitCommon.cmake 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+include(WebKitMacros)
+include(WebKitFS)
+include(WebKitHelpers)
+include(WebKitFeatures)
+
+include(OptionsCommon)
+include(Options${PORT})
+
+CREATE_CONFIGURATION_HEADER()
</ins></span></pre></div>
<a id="trunkSourcecmakeWebKitFScmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/WebKitFS.cmake (188427 => 188428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/WebKitFS.cmake 2015-08-14 01:51:06 UTC (rev 188427)
+++ trunk/Source/cmake/WebKitFS.cmake 2015-08-14 02:14:09 UTC (rev 188428)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+if (NOT BMALLOC_DIR)
+ set(BMALLOC_DIR "${CMAKE_SOURCE_DIR}/Source/bmalloc")
+endif ()
+if (NOT WTF_DIR)
+ set(WTF_DIR "${CMAKE_SOURCE_DIR}/Source/WTF")
+endif ()
+if (NOT JAVASCRIPTCORE_DIR)
+ set(JAVASCRIPTCORE_DIR "${CMAKE_SOURCE_DIR}/Source/JavaScriptCore")
+endif ()
+if (NOT WEBCORE_DIR)
+ set(WEBCORE_DIR "${CMAKE_SOURCE_DIR}/Source/WebCore")
+endif ()
+if (NOT WEBKIT_DIR)
+ set(WEBKIT_DIR "${CMAKE_SOURCE_DIR}/Source/WebKit")
+endif ()
+if (NOT WEBKIT2_DIR)
+ set(WEBKIT2_DIR "${CMAKE_SOURCE_DIR}/Source/WebKit2")
+endif ()
+if (NOT THIRDPARTY_DIR)
+ set(THIRDPARTY_DIR "${CMAKE_SOURCE_DIR}/Source/ThirdParty")
+endif ()
+if (NOT TOOLS_DIR)
+ set(TOOLS_DIR "${CMAKE_SOURCE_DIR}/Tools")
+endif ()
+
+set(DERIVED_SOURCES_DIR "${CMAKE_BINARY_DIR}/DerivedSources")
+set(DERIVED_SOURCES_JAVASCRIPTCORE_DIR "${CMAKE_BINARY_DIR}/DerivedSources/JavaScriptCore")
+set(DERIVED_SOURCES_WEBCORE_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebCore")
+set(DERIVED_SOURCES_WEBKITLEGACY_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebKitLegacy")
+set(DERIVED_SOURCES_WEBKIT_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebKit")
+set(DERIVED_SOURCES_WEBKIT2_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebKit2")
+set(DERIVED_SOURCES_WEBINSPECTORUI_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebInspectorUI")
+set(DERIVED_SOURCES_WTF_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WTF")
+
</ins><span class="cx"> file(MAKE_DIRECTORY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR})
</span><span class="cx"> file(MAKE_DIRECTORY ${DERIVED_SOURCES_WTF_DIR})
</span><span class="cx"> file(MAKE_DIRECTORY ${CMAKE_BINARY_DIR}/Source/JavaScriptCore/runtime)
</span></span></pre>
</div>
</div>
</body>
</html>