<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188304] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188304">188304</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-11 15:47:30 -0700 (Tue, 11 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
for internalTrac.
https://bugs.webkit.org/show_bug.cgi?id=147805
Patch by Jason Marcell <jmarcell@apple.com> on 2015-08-11
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
Dashboard.Repository.Internal.trac for internalTrac.
(BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
respectively.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
(BuildbotQueueView.prototype.revisionContentForIteration): Substituted
Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
internalTrac.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer): Ditto.
(Analyzer.prototype.analyze): Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsInitializationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (188303 => 188304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-08-11 22:47:30 UTC (rev 188304)
</span><span class="lines">@@ -38,9 +38,9 @@
</span><span class="cx"> queue.addEventListener(BuildbotQueue.Event.UnauthorizedAccess, this._unauthorizedAccess, this);
</span><span class="cx"> }.bind(this));
</span><span class="cx">
</span><del>- webkitTrac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
- if (typeof internalTrac != "undefined")
- internalTrac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
</del><ins>+ Dashboard.Repository.OpenSource.trac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
+ if (typeof Dashboard.Repository.Internal.trac != "undefined")
+ Dashboard.Repository.Internal.trac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> BaseObject.addConstructorFunctions(BuildbotQueueView);
</span><span class="lines">@@ -76,6 +76,8 @@
</span><span class="cx"> if (!latestProductiveIteration)
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ var webkitTrac = Dashboard.Repository.OpenSource.trac;
+ var internalTrac = Dashboard.Repository.Internal.trac;
</ins><span class="cx"> var latestRecordedOpenSourceRevisionNumber = webkitTrac.latestRecordedRevisionNumber;
</span><span class="cx"> if (!latestRecordedOpenSourceRevisionNumber || webkitTrac.oldestRecordedRevisionNumber > latestProductiveIteration.revision[Dashboard.Repository.OpenSource.name]) {
</span><span class="cx"> webkitTrac.loadMoreHistoricalData();
</span><span class="lines">@@ -153,6 +155,8 @@
</span><span class="cx"> var content = document.createElement("div");
</span><span class="cx"> content.className = "commit-history-popover";
</span><span class="cx">
</span><ins>+ var webkitTrac = Dashboard.Repository.OpenSource.trac;
+ var internalTrac = Dashboard.Repository.Internal.trac;
</ins><span class="cx"> var linesForOpenSource = this._popoverLinesForCommitRange(webkitTrac, queue.branch.openSource, latestProductiveIteration.revision[Dashboard.Repository.OpenSource.name] + 1, webkitTrac.latestRecordedRevisionNumber);
</span><span class="cx"> for (var i = 0; i != linesForOpenSource.length; ++i)
</span><span class="cx"> content.appendChild(linesForOpenSource[i]);
</span><span class="lines">@@ -262,12 +266,14 @@
</span><span class="cx"> {
</span><span class="cx"> console.assert(iteration.revision[Dashboard.Repository.OpenSource.name]);
</span><span class="cx">
</span><del>- var openSourceContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, Dashboard.Repository.OpenSource.name, webkitTrac);
</del><ins>+ var openSourceContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration,
+ Dashboard.Repository.OpenSource.name, Dashboard.Repository.OpenSource.trac);
</ins><span class="cx">
</span><span class="cx"> if (!iteration.revision[Dashboard.Repository.Internal.name])
</span><span class="cx"> return openSourceContent;
</span><span class="cx">
</span><del>- var internalContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, Dashboard.Repository.Internal.name, internalTrac);
</del><ins>+ var internalContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration,
+ Dashboard.Repository.Internal.name, Dashboard.Repository.Internal.trac);
</ins><span class="cx">
</span><span class="cx"> var fragment = document.createDocumentFragment();
</span><span class="cx"> fragment.appendChild(openSourceContent);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsInitializationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js (188303 => 188304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js 2015-08-11 22:47:30 UTC (rev 188304)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx">
</span><span class="cx"> var settings = new Settings;
</span><span class="cx"> var buildbots = [ new WebKitBuildbot ];
</span><del>-var webkitTrac = new Trac("https://trac.webkit.org/");
</del><ins>+Dashboard.Repository.OpenSource.trac = new Trac("https://trac.webkit.org/");
</ins><span class="cx"> if (typeof Bugzilla !== "undefined")
</span><span class="cx"> var bugzilla = new Bugzilla;
</span><span class="cx"> if (typeof BubbleQueueServer !== "undefined")
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (188303 => 188304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-08-11 22:47:30 UTC (rev 188304)
</span><span class="lines">@@ -296,8 +296,8 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-webkitTrac.startPeriodicUpdates();
-if (typeof internalTrac !== "undefined")
- internalTrac.startPeriodicUpdates();
</del><ins>+Dashboard.Repository.OpenSource.trac.startPeriodicUpdates();
+if (typeof Dashboard.Repository.Internal.trac !== "undefined")
+ Dashboard.Repository.Internal.trac.startPeriodicUpdates();
</ins><span class="cx">
</span><span class="cx"> document.addEventListener("DOMContentLoaded", documentReady);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (188303 => 188304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2015-08-11 22:47:30 UTC (rev 188304)
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx"> // Only load one queue at a time to not overload the server.
</span><span class="cx"> this._queueBeingLoaded = null;
</span><span class="cx">
</span><del>- webkitTrac.addEventListener(Trac.Event.Loaded, this._loadedFromTrac, this);
</del><ins>+ Dashboard.Repository.OpenSource.trac.addEventListener(Trac.Event.Loaded, this._loadedFromTrac, this);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> BaseObject.addConstructorFunctions(Analyzer);
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> this._queuesReadyToAnalyze.push(queue);
</span><span class="cx"> }, this);
</span><span class="cx">
</span><del>- webkitTrac.load(this._rangeStartTime, this._rangeEndTime);
</del><ins>+ Dashboard.Repository.OpenSource.trac.load(this._rangeStartTime, this._rangeEndTime);
</ins><span class="cx">
</span><span class="cx"> bubbleQueueServer.loadProcessingTimes(this._rangeStartTime, this._rangeEndTime, this._loadedBubblesTiming.bind(this));
</span><span class="cx"> },
</span><span class="lines">@@ -264,7 +264,7 @@
</span><span class="cx"> var worstTimeRevision;
</span><span class="cx"> var worstOwnTimeRevision;
</span><span class="cx">
</span><del>- webkitTrac.recordedCommits.forEach(function(revision) {
</del><ins>+ Dashboard.Repository.OpenSource.trac.recordedCommits.forEach(function(revision) {
</ins><span class="cx"> if (revision.date < this._rangeStartTime || revision.date >= this._rangeEndTime)
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (188303 => 188304)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/ChangeLog 2015-08-11 22:47:30 UTC (rev 188304)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2015-08-11 Jason Marcell <jmarcell@apple.com>
+
+ Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
+ for internalTrac.
+ https://bugs.webkit.org/show_bug.cgi?id=147805
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
+ Dashboard.Repository.Internal.trac for internalTrac.
+ (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
+ and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
+ respectively.
+ (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
+ (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
+ Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
+ internalTrac.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+ (Analyzer): Ditto.
+ (Analyzer.prototype.analyze): Ditto.
+
</ins><span class="cx"> 2015-08-11 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
</span></span></pre>
</div>
</div>
</body>
</html>