<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188289] branches/jsc-tailcall</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188289">188289</a></dd>
<dt>Author</dt> <dd>basile_clement@apple.com</dd>
<dt>Date</dt> <dd>2015-08-11 13:47:08 -0700 (Tue, 11 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>jsc-tailcall: Make tail call tests run in all tiers
https://bugs.webkit.org/show_bug.cgi?id=147895
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Make the test checking that tail calls are correctly performed
when we have a syntaxic tail call run enough to get compiled to the
upper tiers.
Also remove a bogus file that contained a duplicate of those tests.
* tests/stress/tail-call-recognize.js:
* tests/stress/tail-call-trigger.js: Removed.
Tools:
Add a runNoInline function to jsc-stress-tests to force a test to run
globally without inlining.
* Scripts/run-jsc-stress-tests:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsctailcallSourceJavaScriptCoreChangeLog">branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesjsctailcallSourceJavaScriptCoretestsstresstailcallrecognizejs">branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-recognize.js</a></li>
<li><a href="#branchesjsctailcallToolsChangeLog">branches/jsc-tailcall/Tools/ChangeLog</a></li>
<li><a href="#branchesjsctailcallToolsScriptsrunjscstresstests">branches/jsc-tailcall/Tools/Scripts/run-jsc-stress-tests</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#branchesjsctailcallSourceJavaScriptCoretestsstresstailcalltriggerjs">branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-trigger.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsctailcallSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog (188288 => 188289)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog 2015-08-11 20:47:02 UTC (rev 188288)
+++ branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog 2015-08-11 20:47:08 UTC (rev 188289)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2015-08-11 Basile Clement <basile_clement@apple.com>
</span><span class="cx">
</span><ins>+ jsc-tailcall: Make tail call tests run in all tiers
+ https://bugs.webkit.org/show_bug.cgi?id=147895
+
+ Reviewed by Michael Saboff.
+
+ Make the test checking that tail calls are correctly performed
+ when we have a syntaxic tail call run enough to get compiled to the
+ upper tiers.
+
+ Also remove a bogus file that contained a duplicate of those tests.
+
+ * tests/stress/tail-call-recognize.js:
+ * tests/stress/tail-call-trigger.js: Removed.
+
+2015-08-11 Basile Clement <basile_clement@apple.com>
+
</ins><span class="cx"> jsc-tailcall: REGRESSION: DFGByteCodeParser fails when a tail call is inside a ternary
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=147849
</span><span class="cx">
</span></span></pre></div>
<a id="branchesjsctailcallSourceJavaScriptCoretestsstresstailcallrecognizejs"></a>
<div class="modfile"><h4>Modified: branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-recognize.js (188288 => 188289)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-recognize.js 2015-08-11 20:47:02 UTC (rev 188288)
+++ branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-recognize.js 2015-08-11 20:47:08 UTC (rev 188289)
</span><span class="lines">@@ -1,3 +1,5 @@
</span><ins>+//@ runNoInline
+
</ins><span class="cx"> function callerMustBeRun() {
</span><span class="cx"> if (!Object.is(callerMustBeRun.caller, runTests))
</span><span class="cx"> throw Error("Wrong caller, expected run but got ", callerMustBeRun.caller);
</span><span class="lines">@@ -174,4 +176,5 @@
</span><span class="cx"> })();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-runTests();
</del><ins>+for (var i = 0; i < 10000; ++i)
+ runTests();
</ins></span></pre></div>
<a id="branchesjsctailcallSourceJavaScriptCoretestsstresstailcalltriggerjs"></a>
<div class="delfile"><h4>Deleted: branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-trigger.js (188288 => 188289)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-trigger.js 2015-08-11 20:47:02 UTC (rev 188288)
+++ branches/jsc-tailcall/Source/JavaScriptCore/tests/stress/tail-call-trigger.js 2015-08-11 20:47:08 UTC (rev 188289)
</span><span class="lines">@@ -1,177 +0,0 @@
</span><del>-function callerMustBeRun() {
- if (!Object.is(callerMustBeRun.caller, runTests))
- throw Error("Wrong caller, expected run but got ", callerMustBeRun.caller);
-}
-
-function callerMustBeStrict() {
- var errorThrown = false;
- try {
- callerMustBeStrict.caller;
- } catch (e) {
- errorThrown = true;
- }
- if (!errorThrown)
- throw Error("Wrong caller, expected strict caller but got ", callerMustBeStrict.caller);
-}
-
-function runTests() {
- // Statement tests
- (function simpleTailCall() {
- "use strict";
- return callerMustBeRun();
- })();
-
- (function noTailCallInTry() {
- "use strict";
- try {
- return callerMustBeStrict();
- } catch (e) {
- throw e;
- }
- })();
-
- (function tailCallInCatch() {
- "use strict";
- try { } catch (e) { return callerMustBeRun(); }
- })();
-
- (function tailCallInFinally() {
- "use strict";
- try { } finally { return callerMustBeRun(); }
- })();
-
- (function tailCallInFinallyWithCatch() {
- "use strict";
- try { } catch (e) { } finally { return callerMustBeRun(); }
- })();
-
- (function tailCallInFinallyWithCatchTaken() {
- "use strict";
- try { throw null; } catch (e) { } finally { return callerMustBeRun(); }
- })();
-
- (function noTailCallInCatchIfFinally() {
- "use strict";
- try { throw null; } catch (e) { return callerMustBeStrict(); } finally { }
- })();
-
- (function tailCallInFor() {
- "use strict";
- for (var i = 0; i < 10; ++i)
- return callerMustBeRun();
- })();
-
- (function tailCallInWhile() {
- "use strict";
- while (true)
- return callerMustBeRun();
- })();
-
- (function tailCallInDoWhile() {
- "use strict";
- do
- return callerMustBeRun();
- while (true);
- })();
-
- (function noTailCallInForIn() {
- "use strict";
- for (var x in [1, 2])
- return callerMustBeStrict();
- })();
-
- (function noTailCallInForOf() {
- "use strict";
- for (var x of [1, 2])
- return callerMustBeStrict();
- })();
-
- (function tailCallInIf() {
- "use strict";
- if (true)
- return callerMustBeRun();
- })();
-
- (function tailCallInElse() {
- "use strict";
- if (false) throw new Error("WTF");
- else return callerMustBeRun();
- })();
-
- (function tailCallInSwitchCase() {
- "use strict";
- switch (0) {
- case 0: return callerMustBeRun();
- }
- })();
-
- (function tailCallInSwitchDefault() {
- "use strict";
- switch (0) {
- default: return callerMustBeRun();
- }
- })();
-
- (function tailCallWithLabel() {
- "use strict";
- dummy: return callerMustBeRun();
- })();
-
- // Expression tests, we don't enumerate all the cases where there
- // *shouldn't* be a tail call
-
- (function tailCallComma() {
- "use strict";
- return callerMustBeStrict(), callerMustBeRun();
- })();
-
- (function tailCallTernaryLeft() {
- "use strict";
- return true ? callerMustBeRun() : unreachable();
- })();
-
- (function tailCallTernaryRight() {
- "use strict";
- return false ? unreachable() : callerMustBeRun();
- })();
-
- (function tailCallLogicalAnd() {
- "use strict";
- return true && callerMustBeRun();
- })();
-
- (function tailCallLogicalOr() {
- "use strict";
- return false || callerMustBeRun();
- })();
-
- (function memberTailCall() {
- "use strict";
- return { f: callerMustBeRun }.f();
- })();
-
- (function bindTailCall() {
- "use strict";
- return callerMustBeRun.bind()();
- })();
-
- // Function.prototype tests
-
- (function applyTailCall() {
- "use strict";
- return callerMustBeRun.apply();
- })();
-
- (function callTailCall() {
- "use strict";
- return callerMustBeRun.call();
- })();
-
- // No tail call for constructors
- (function noTailConstruct() {
- "use strict";
- return new callerMustBeStrict();
- })();
-}
-
-runTests();
</del></span></pre></div>
<a id="branchesjsctailcallToolsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsc-tailcall/Tools/ChangeLog (188288 => 188289)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Tools/ChangeLog 2015-08-11 20:47:02 UTC (rev 188288)
+++ branches/jsc-tailcall/Tools/ChangeLog 2015-08-11 20:47:08 UTC (rev 188289)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-08-11 Basile Clement <basile_clement@apple.com>
+
+ jsc-tailcall: Make tail call tests run in all tiers
+ https://bugs.webkit.org/show_bug.cgi?id=147895
+
+ Reviewed by Michael Saboff.
+
+ Add a runNoInline function to jsc-stress-tests to force a test to run
+ globally without inlining.
+
+ * Scripts/run-jsc-stress-tests:
+
</ins><span class="cx"> 2015-07-09 Devin Rousso <drousso@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. Added myself as a committer.
</span></span></pre></div>
<a id="branchesjsctailcallToolsScriptsrunjscstresstests"></a>
<div class="modfile"><h4>Modified: branches/jsc-tailcall/Tools/Scripts/run-jsc-stress-tests (188288 => 188289)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Tools/Scripts/run-jsc-stress-tests 2015-08-11 20:47:02 UTC (rev 188288)
+++ branches/jsc-tailcall/Tools/Scripts/run-jsc-stress-tests 2015-08-11 20:47:08 UTC (rev 188289)
</span><span class="lines">@@ -1043,6 +1043,11 @@
</span><span class="cx"> puts "Skipping #{$collectionName}/#{$benchmark}"
</span><span class="cx"> end
</span><span class="cx">
</span><ins>+def runNoInline
+ $didAddRunCommand = true
+ run("-no-inline", "--maximumInliningDepth=1")
+end
+
</ins><span class="cx"> def largeHeap
</span><span class="cx"> if $memoryLimited
</span><span class="cx"> $didAddRunCommand = true
</span></span></pre>
</div>
</div>
</body>
</html>