<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188210] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188210">188210</a></dd>
<dt>Author</dt> <dd>youenn.fablet@crf.canon.fr</dd>
<dt>Date</dt> <dd>2015-08-10 03:05:40 -0700 (Mon, 10 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
https://bugs.webkit.org/show_bug.cgi?id=146414
Reviewed by Darin Adler.
Source/WebCore:
No behavioral changes.
* platform/FileSystem.cpp:
(WebCore::MappedFileData::MappedFileData): Making use of convertSafely.
* platform/posix/SharedBufferPOSIX.cpp:
(WebCore::SharedBuffer::createFromReadingFile): Making use of convertSafely.
Source/WTF:
Added convertSafely routine based on isInBounds routine.
Updated BoundChecker by adding a third boolean parameter to this template giving whether Target has greater or equal precision than Source.
Removed BoundCheckElider, which is no longer necessary and had some issues.
* wtf/CheckedArithmetic.h:
(WTF::isInBounds):
(WTF::convertSafely):
Tools:
* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
(TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfCheckedArithmetich">trunk/Source/WTF/wtf/CheckedArithmetic.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformFileSystemcpp">trunk/Source/WebCore/platform/FileSystem.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformposixSharedBufferPOSIXcpp">trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFCheckedArithmeticOperationscpp">trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (188209 => 188210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2015-08-10 10:01:31 UTC (rev 188209)
+++ trunk/Source/WTF/ChangeLog 2015-08-10 10:05:40 UTC (rev 188210)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-08-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
+
+ Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=146414
+
+ Reviewed by Darin Adler.
+
+ Added convertSafely routine based on isInBounds routine.
+ Updated BoundChecker by adding a third boolean parameter to this template giving whether Target has greater or equal precision than Source.
+ Removed BoundCheckElider, which is no longer necessary and had some issues.
+
+ * wtf/CheckedArithmetic.h:
+ (WTF::isInBounds):
+ (WTF::convertSafely):
+
</ins><span class="cx"> 2015-08-07 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Lightweight locks should be adaptive
</span></span></pre></div>
<a id="trunkSourceWTFwtfCheckedArithmetich"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/CheckedArithmetic.h (188209 => 188210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/CheckedArithmetic.h 2015-08-10 10:01:31 UTC (rev 188209)
+++ trunk/Source/WTF/wtf/CheckedArithmetic.h 2015-08-10 10:05:40 UTC (rev 188210)
</span><span class="lines">@@ -122,65 +122,86 @@
</span><span class="cx"> template <typename T> struct RemoveChecked;
</span><span class="cx"> template <typename T> struct RemoveChecked<Checked<T>>;
</span><span class="cx">
</span><del>-template <typename Target, typename Source, bool targetSigned = std::numeric_limits<Target>::is_signed, bool sourceSigned = std::numeric_limits<Source>::is_signed> struct BoundsChecker;
-template <typename Target, typename Source> struct BoundsChecker<Target, Source, false, false> {
</del><ins>+template <typename Target, typename Source, bool isTargetBigger = sizeof(Target) >= sizeof(Source), bool targetSigned = std::numeric_limits<Target>::is_signed, bool sourceSigned = std::numeric_limits<Source>::is_signed> struct BoundsChecker;
+template <typename Target, typename Source> struct BoundsChecker<Target, Source, false, false, false> {
</ins><span class="cx"> static bool inBounds(Source value)
</span><span class="cx"> {
</span><del>- // Same signedness so implicit type conversion will always increase precision
- // to widest type
</del><ins>+ // Same signedness so implicit type conversion will always increase precision to widest type.
</ins><span class="cx"> return value <= std::numeric_limits<Target>::max();
</span><span class="cx"> }
</span><span class="cx"> };
</span><del>-
-template <typename Target, typename Source> struct BoundsChecker<Target, Source, true, true> {
</del><ins>+template <typename Target, typename Source> struct BoundsChecker<Target, Source, false, true, true> {
</ins><span class="cx"> static bool inBounds(Source value)
</span><span class="cx"> {
</span><del>- // Same signedness so implicit type conversion will always increase precision
- // to widest type
</del><ins>+ // Same signedness so implicit type conversion will always increase precision to widest type.
</ins><span class="cx"> return std::numeric_limits<Target>::min() <= value && value <= std::numeric_limits<Target>::max();
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-template <typename Target, typename Source> struct BoundsChecker<Target, Source, false, true> {
</del><ins>+template <typename Target, typename Source> struct BoundsChecker<Target, Source, false, false, true> {
</ins><span class="cx"> static bool inBounds(Source value)
</span><span class="cx"> {
</span><del>- // Target is unsigned so any value less than zero is clearly unsafe
- if (value < 0)
- return false;
- // If our (unsigned) Target is the same or greater width we can
- // convert value to type Target without losing precision
- if (sizeof(Target) >= sizeof(Source))
- return static_cast<Target>(value) <= std::numeric_limits<Target>::max();
- // The signed Source type has greater precision than the target so
- // max(Target) -> Source will widen.
- return value <= static_cast<Source>(std::numeric_limits<Target>::max());
</del><ins>+ // When converting value to unsigned Source, value will become a big value if value is negative.
+ // Casted value will become bigger than Target::max as Source is bigger than Target.
+ return static_cast<typename std::make_unsigned<Source>::type>(value) <= std::numeric_limits<Target>::max();
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-template <typename Target, typename Source> struct BoundsChecker<Target, Source, true, false> {
</del><ins>+template <typename Target, typename Source> struct BoundsChecker<Target, Source, false, true, false> {
</ins><span class="cx"> static bool inBounds(Source value)
</span><span class="cx"> {
</span><del>- // Signed target with an unsigned source
- if (sizeof(Target) <= sizeof(Source))
- return value <= static_cast<Source>(std::numeric_limits<Target>::max());
- // Target is Wider than Source so we're guaranteed to fit any value in
- // unsigned Source
</del><ins>+ // The unsigned Source type has greater precision than the target so max(Target) -> Source will widen.
+ return value <= static_cast<Source>(std::numeric_limits<Target>::max());
+ }
+};
+
+template <typename Target, typename Source> struct BoundsChecker<Target, Source, true, false, false> {
+ static bool inBounds(Source)
+ {
+ // Same sign, greater or same precision.
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-template <typename Target, typename Source, bool CanElide = std::is_same<Target, Source>::value || (sizeof(Target) > sizeof(Source)) > struct BoundsCheckElider;
-template <typename Target, typename Source> struct BoundsCheckElider<Target, Source, true> {
- static bool inBounds(Source) { return true; }
</del><ins>+template <typename Target, typename Source> struct BoundsChecker<Target, Source, true, true, true> {
+ static bool inBounds(Source)
+ {
+ // Same sign, greater or same precision.
+ return true;
+ }
</ins><span class="cx"> };
</span><del>-template <typename Target, typename Source> struct BoundsCheckElider<Target, Source, false> : public BoundsChecker<Target, Source> {
</del><ins>+
+template <typename Target, typename Source> struct BoundsChecker<Target, Source, true, true, false> {
+ static bool inBounds(Source value)
+ {
+ // Target is signed with greater or same precision. If strictly greater, it is always safe.
+ if (sizeof(Target) > sizeof(Source))
+ return true;
+ return value <= static_cast<Source>(std::numeric_limits<Target>::max());
+ }
</ins><span class="cx"> };
</span><span class="cx">
</span><ins>+template <typename Target, typename Source> struct BoundsChecker<Target, Source, true, false, true> {
+ static bool inBounds(Source value)
+ {
+ // Target is unsigned with greater precision.
+ return value >= 0;
+ }
+};
+
</ins><span class="cx"> template <typename Target, typename Source> static inline bool isInBounds(Source value)
</span><span class="cx"> {
</span><del>- return BoundsCheckElider<Target, Source>::inBounds(value);
</del><ins>+ return BoundsChecker<Target, Source>::inBounds(value);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+template <typename Target, typename Source> static inline bool convertSafely(Source input, Target& output)
+{
+ if (!isInBounds<Target>(input))
+ return false;
+ output = static_cast<Target>(input);
+ return true;
+}
+
</ins><span class="cx"> template <typename T> struct RemoveChecked {
</span><span class="cx"> typedef T CleanType;
</span><span class="cx"> static const CleanType DefaultValue = 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188209 => 188210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-10 10:01:31 UTC (rev 188209)
+++ trunk/Source/WebCore/ChangeLog 2015-08-10 10:05:40 UTC (rev 188210)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2015-08-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><ins>+ Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=146414
+
+ Reviewed by Darin Adler.
+
+ No behavioral changes.
+
+ * platform/FileSystem.cpp:
+ (WebCore::MappedFileData::MappedFileData): Making use of convertSafely.
+ * platform/posix/SharedBufferPOSIX.cpp:
+ (WebCore::SharedBuffer::createFromReadingFile): Making use of convertSafely.
+
+2015-08-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
+
</ins><span class="cx"> [Streams API] ReadableStreamReader closed promise should use CachedAttribute
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=147487
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformFileSystemcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/FileSystem.cpp (188209 => 188210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/FileSystem.cpp 2015-08-10 10:01:31 UTC (rev 188209)
+++ trunk/Source/WebCore/platform/FileSystem.cpp 2015-08-10 10:05:40 UTC (rev 188210)
</span><span class="lines">@@ -151,14 +151,13 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (fileStat.st_size < 0 || fileStat.st_size > std::numeric_limits<unsigned>::max()) {
</del><ins>+ unsigned size;
+ if (!WTF::convertSafely(fileStat.st_size, size)) {
</ins><span class="cx"> close(fd);
</span><span class="cx"> success = false;
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- unsigned size = static_cast<unsigned>(fileStat.st_size);
-
</del><span class="cx"> if (!size) {
</span><span class="cx"> close(fd);
</span><span class="cx"> success = true;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformposixSharedBufferPOSIXcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp (188209 => 188210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp 2015-08-10 10:01:31 UTC (rev 188209)
+++ trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp 2015-08-10 10:05:40 UTC (rev 188210)
</span><span class="lines">@@ -51,8 +51,8 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- size_t bytesToRead = fileStat.st_size;
- if (fileStat.st_size < 0 || bytesToRead != static_cast<unsigned long long>(fileStat.st_size)) {
</del><ins>+ size_t bytesToRead;
+ if (!WTF::convertSafely(fileStat.st_size, bytesToRead)) {
</ins><span class="cx"> close(fd);
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (188209 => 188210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-08-10 10:01:31 UTC (rev 188209)
+++ trunk/Tools/ChangeLog 2015-08-10 10:05:40 UTC (rev 188210)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-08-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
+
+ Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=146414
+
+ Reviewed by Darin Adler.
+
+ * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
+ (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
+
</ins><span class="cx"> 2015-08-10 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Test /webkit2/WebKitWebView/submit-form is flaky
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFCheckedArithmeticOperationscpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp (188209 => 188210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp 2015-08-10 10:01:31 UTC (rev 188209)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp 2015-08-10 10:05:40 UTC (rev 188210)
</span><span class="lines">@@ -426,4 +426,62 @@
</span><span class="cx"> CheckedArithmeticTest(int64_t, CoerceLiteralNop, IgnoreMixedSignednessTest)
</span><span class="cx"> CheckedArithmeticTest(uint64_t, CoerceLiteralToUnsigned, IgnoreMixedSignednessTest)
</span><span class="cx">
</span><ins>+TEST(CheckedArithmeticTest, IsInBounds)
+{
+ // bigger precision, signed, signed
+ EXPECT_TRUE(WTF::isInBounds<int32_t>(std::numeric_limits<int16_t>::max()));
+ EXPECT_TRUE(WTF::isInBounds<int32_t>(std::numeric_limits<int16_t>::min()));
+
+ // bigger precision, unsigned, signed
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>(std::numeric_limits<int32_t>::max()));
+ EXPECT_FALSE(WTF::isInBounds<uint32_t>(std::numeric_limits<int16_t>::min()));
+
+ EXPECT_FALSE(WTF::isInBounds<uint32_t>((int32_t)-1));
+ EXPECT_FALSE(WTF::isInBounds<uint16_t>((int32_t)-1));
+ EXPECT_FALSE(WTF::isInBounds<unsigned long>((int)-1));
+
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>((int32_t)1));
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>((int16_t)1));
+ EXPECT_TRUE(WTF::isInBounds<unsigned>((int)1));
+
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>((int32_t)0));
+ EXPECT_TRUE(WTF::isInBounds<uint16_t>((int32_t)0));
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>((int16_t)0));
+ EXPECT_TRUE(WTF::isInBounds<unsigned>((int)0));
+
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>(std::numeric_limits<int32_t>::max()));
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>(std::numeric_limits<int16_t>::max()));
+ EXPECT_TRUE(WTF::isInBounds<unsigned>(std::numeric_limits<int>::max()));
+
+ // bigger precision, signed, unsigned
+ EXPECT_TRUE(WTF::isInBounds<int32_t>(std::numeric_limits<uint16_t>::max()));
+ EXPECT_FALSE(WTF::isInBounds<int32_t>(std::numeric_limits<uint32_t>::max()));
+ EXPECT_TRUE(WTF::isInBounds<int32_t>((uint32_t)0));
+
+ // bigger precision, unsigned, unsigned
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>(std::numeric_limits<uint16_t>::max()));
+ EXPECT_TRUE(WTF::isInBounds<uint32_t>(std::numeric_limits<uint16_t>::min()));
+
+ // lower precision, signed signed
+ EXPECT_FALSE(WTF::isInBounds<int16_t>(std::numeric_limits<int32_t>::max()));
+ EXPECT_FALSE(WTF::isInBounds<int16_t>(std::numeric_limits<int32_t>::min()));
+ EXPECT_TRUE(WTF::isInBounds<int16_t>((int32_t)-1));
+ EXPECT_TRUE(WTF::isInBounds<int16_t>((int32_t)0));
+ EXPECT_TRUE(WTF::isInBounds<int16_t>((int32_t)1));
+ // lower precision, unsigned, signed
+ EXPECT_FALSE(WTF::isInBounds<uint16_t>(std::numeric_limits<int32_t>::max()));
+ EXPECT_FALSE(WTF::isInBounds<uint16_t>(std::numeric_limits<int32_t>::min()));
+ EXPECT_FALSE(WTF::isInBounds<uint16_t>((int32_t)-1));
+ EXPECT_TRUE(WTF::isInBounds<uint16_t>((int32_t)0));
+ EXPECT_TRUE(WTF::isInBounds<uint16_t>((int32_t)1));
+ // lower precision, signed, unsigned
+ EXPECT_FALSE(WTF::isInBounds<int16_t>(std::numeric_limits<uint32_t>::max()));
+ EXPECT_TRUE(WTF::isInBounds<int16_t>((uint32_t)0));
+ EXPECT_TRUE(WTF::isInBounds<int16_t>((uint32_t)1));
+ // lower precision, unsigned, unsigned
+ EXPECT_FALSE(WTF::isInBounds<uint16_t>(std::numeric_limits<uint32_t>::max()));
+ EXPECT_TRUE(WTF::isInBounds<uint16_t>((uint32_t)0));
+ EXPECT_TRUE(WTF::isInBounds<uint16_t>((uint32_t)1));
+}
+
</ins><span class="cx"> } // namespace TestWebKitAPI
</span></span></pre>
</div>
</div>
</body>
</html>