<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188252] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188252">188252</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-08-10 23:42:09 -0700 (Mon, 10 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>The 'prototype' property on interface objects should not be enumerable
https://bugs.webkit.org/show_bug.cgi?id=147861
Reviewed by Darin Adler.
Source/WebCore:
1. Make the 'prototype' property not enumerable on interface object to
comply with the Web IDL specification [1] and to align our behavior
with Firefox 38 and Chrome 44.
2. Also update the 'prototype' property on named constructors to have the
following attributes:
{ [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }
Previously, all these were true in WebKit. The new behavior complies
with the Web IDL specification [2] and aligns our behavior with
Firefox 38. On Chrome 44, the attributes are as follows:
{ [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false }
This behavior is also covered by the following W3C test suite:
http://w3c-test.org/dom/interfaces.html
[1] http://heycam.github.io/webidl/#interface-object
[2] http://heycam.github.io/webidl/#named-constructors
Test: fast/dom/prototype-property-not-enumerable.html
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
LayoutTests:
Add layout test to check that the 'prototype' property on interface
objects has the following attributes:
{ [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }
* fast/dom/prototype-property-not-enumerable-expected.txt: Added.
* fast/dom/prototype-property-not-enumerable.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomprototypepropertynotenumerableexpectedtxt">trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomprototypepropertynotenumerablehtml">trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (188251 => 188252)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-08-11 06:40:56 UTC (rev 188251)
+++ trunk/LayoutTests/ChangeLog 2015-08-11 06:42:09 UTC (rev 188252)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-08-10 Chris Dumez <cdumez@apple.com>
+
+ The 'prototype' property on interface objects should not be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=147861
+
+ Reviewed by Darin Adler.
+
+ Add layout test to check that the 'prototype' property on interface
+ objects has the following attributes:
+ { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }
+
+ * fast/dom/prototype-property-not-enumerable-expected.txt: Added.
+ * fast/dom/prototype-property-not-enumerable.html: Added.
+
</ins><span class="cx"> 2015-08-10 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomprototypepropertynotenumerableexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt (0 => 188252)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt 2015-08-11 06:42:09 UTC (rev 188252)
</span><span class="lines">@@ -0,0 +1,33 @@
</span><ins>+The 'prototype' property on interface objects should have attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* Event
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is false
+* Element
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is false
+* Document
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is false
+* Window
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is false
+* HTMLOptionElement
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is false
+* Option
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomprototypepropertynotenumerablehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html (0 => 188252)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html (rev 0)
+++ trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html 2015-08-11 06:42:09 UTC (rev 188252)
</span><span class="lines">@@ -0,0 +1,46 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("The 'prototype' property on interface objects should have attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }");
+
+debug("* Event");
+var descriptor = Object.getOwnPropertyDescriptor(Event, "prototype");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeFalse("descriptor.configurable");
+
+debug("* Element");
+var descriptor = Object.getOwnPropertyDescriptor(Element, "prototype");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeFalse("descriptor.configurable");
+
+debug("* Document");
+var descriptor = Object.getOwnPropertyDescriptor(Document, "prototype");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeFalse("descriptor.configurable");
+
+debug("* Window");
+var descriptor = Object.getOwnPropertyDescriptor(Window, "prototype");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeFalse("descriptor.configurable");
+
+debug("* HTMLOptionElement");
+var descriptor = Object.getOwnPropertyDescriptor(HTMLOptionElement, "prototype");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeFalse("descriptor.configurable");
+
+debug("* Option");
+var descriptor = Object.getOwnPropertyDescriptor(Option, "prototype");
+shouldBeFalse("descriptor.writable");
+shouldBeFalse("descriptor.enumerable");
+shouldBeFalse("descriptor.configurable");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188251 => 188252)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-11 06:40:56 UTC (rev 188251)
+++ trunk/Source/WebCore/ChangeLog 2015-08-11 06:42:09 UTC (rev 188252)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2015-08-10 Chris Dumez <cdumez@apple.com>
+
+ The 'prototype' property on interface objects should not be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=147861
+
+ Reviewed by Darin Adler.
+
+ 1. Make the 'prototype' property not enumerable on interface object to
+ comply with the Web IDL specification [1] and to align our behavior
+ with Firefox 38 and Chrome 44.
+
+ 2. Also update the 'prototype' property on named constructors to have the
+ following attributes:
+ { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }
+
+ Previously, all these were true in WebKit. The new behavior complies
+ with the Web IDL specification [2] and aligns our behavior with
+ Firefox 38. On Chrome 44, the attributes are as follows:
+ { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false }
+
+ This behavior is also covered by the following W3C test suite:
+ http://w3c-test.org/dom/interfaces.html
+
+ [1] http://heycam.github.io/webidl/#interface-object
+ [2] http://heycam.github.io/webidl/#named-constructors
+
+ Test: fast/dom/prototype-property-not-enumerable.html
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateConstructorHelperMethods):
+
</ins><span class="cx"> 2015-08-10 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Build fix after r188239.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (188251 => 188252)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-08-11 06:40:56 UTC (rev 188251)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-08-11 06:42:09 UTC (rev 188252)
</span><span class="lines">@@ -4781,15 +4781,15 @@
</span><span class="cx"> if (IsDOMGlobalObject($interface)) {
</span><span class="cx"> push(@$outputArray, " Base::finishCreation(vm);\n");
</span><span class="cx"> push(@$outputArray, " ASSERT(inherits(info()));\n");
</span><del>- push(@$outputArray, " putDirect(vm, vm.propertyNames->prototype, globalObject->prototype(), DontDelete | ReadOnly);\n");
</del><ins>+ push(@$outputArray, " putDirect(vm, vm.propertyNames->prototype, globalObject->prototype(), DontDelete | ReadOnly | DontEnum);\n");
</ins><span class="cx"> } elsif ($generatingNamedConstructor) {
</span><span class="cx"> push(@$outputArray, " Base::finishCreation(globalObject);\n");
</span><span class="cx"> push(@$outputArray, " ASSERT(inherits(info()));\n");
</span><del>- push(@$outputArray, " putDirect(vm, vm.propertyNames->prototype, ${className}::getPrototype(vm, globalObject), None);\n");
</del><ins>+ push(@$outputArray, " putDirect(vm, vm.propertyNames->prototype, ${className}::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);\n");
</ins><span class="cx"> } else {
</span><span class="cx"> push(@$outputArray, " Base::finishCreation(vm);\n");
</span><span class="cx"> push(@$outputArray, " ASSERT(inherits(info()));\n");
</span><del>- push(@$outputArray, " putDirect(vm, vm.propertyNames->prototype, ${className}::getPrototype(vm, globalObject), DontDelete | ReadOnly);\n");
</del><ins>+ push(@$outputArray, " putDirect(vm, vm.propertyNames->prototype, ${className}::getPrototype(vm, globalObject), DontDelete | ReadOnly | DontEnum);\n");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (defined $leastConstructorLength) {
</span></span></pre>
</div>
</div>
</body>
</html>