<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188213] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188213">188213</a></dd>
<dt>Author</dt> <dd>jcraig@apple.com</dd>
<dt>Date</dt> <dd>2015-08-10 09:01:19 -0700 (Mon, 10 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Address follow-up comments in bug 145684
https://bugs.webkit.org/show_bug.cgi?id=147817
Reviewed by Dean Jackson.
Minor cleanup and style updates requested by Dean.
Source/WebCore:
Updated Existing Test Expectations.
* Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-show-controls):
* Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-show-controls):
LayoutTests:
* http/tests/contentextensions/text-track-blocked-expected.txt:
* media/video-controls-show-on-kb-or-ax-event.html:
* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestscontentextensionstexttrackblockedexpectedtxt">trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediavideocontrolsshowonkboraxeventhtml">trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacmediatracktrackcuerenderinghorizontalexpectedtxt">trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsApplecss">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (188212 => 188213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/ChangeLog 2015-08-10 16:01:19 UTC (rev 188213)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-08-10 James Craig <jcraig@apple.com>
+
+ AX: Address follow-up comments in bug 145684
+ https://bugs.webkit.org/show_bug.cgi?id=147817
+
+ Reviewed by Dean Jackson.
+
+ Minor cleanup and style updates requested by Dean.
+
+ * http/tests/contentextensions/text-track-blocked-expected.txt:
+ * media/video-controls-show-on-kb-or-ax-event.html:
+ * platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:
+
</ins><span class="cx"> 2015-08-07 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Expand network cache tests to cover memory cache behavior
</span></span></pre></div>
<a id="trunkLayoutTestshttptestscontentextensionstexttrackblockedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt (188212 => 188213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-10 16:01:19 UTC (rev 188213)
</span><span class="lines">@@ -15,4 +15,4 @@
</span><span class="cx"> layer at (8,26) size 320x240
</span><span class="cx"> RenderFlexibleBox {DIV} at (0,0) size 320x240
</span><span class="cx"> layer at (8,256) size 320x10
</span><del>- RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
</del><ins>+ RenderButton {BUTTON} at (0,230) size 320x10
</ins></span></pre></div>
<a id="trunkLayoutTestsmediavideocontrolsshowonkboraxeventhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html (188212 => 188213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html 2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html 2015-08-10 16:01:19 UTC (rev 188213)
</span><span class="lines">@@ -27,9 +27,8 @@
</span><span class="cx"> if (button) {
</span><span class="cx"> button.focus();
</span><span class="cx"> eventSender.keyDown(' '); // Use keyboard to press the selected button.
</span><del>- } else {
</del><ins>+ } else
</ins><span class="cx"> result.innerHTML += 'FAIL: "Show Controls" button is not available.<br>';
</span><del>- }
</del><span class="cx">
</span><span class="cx"> // Verifies the toolbar is back in the DOM.
</span><span class="cx"> var controls = root.firstChild.querySelector('[role="toolbar"]');
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacmediatracktrackcuerenderinghorizontalexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt (188212 => 188213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt 2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt 2015-08-10 16:01:19 UTC (rev 188213)
</span><span class="lines">@@ -61,4 +61,4 @@
</span><span class="cx"> RenderText {#text} at (0,0) size 275x14
</span><span class="cx"> text run at (0,0) width 275: "Cue 6: should be on top of bottom positioned cue 5."
</span><span class="cx"> layer at (8,238) size 320x10
</span><del>- RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
</del><ins>+ RenderButton {BUTTON} at (0,230) size 320x10
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188212 => 188213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/Source/WebCore/ChangeLog 2015-08-10 16:01:19 UTC (rev 188213)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-08-10 James Craig <jcraig@apple.com>
+
+ AX: Address follow-up comments in bug 145684
+ https://bugs.webkit.org/show_bug.cgi?id=147817
+
+ Reviewed by Dean Jackson.
+
+ Minor cleanup and style updates requested by Dean.
+ Updated Existing Test Expectations.
+
+ * Modules/mediacontrols/mediaControlsApple.css:
+ (video::-webkit-media-show-controls):
+ * Modules/mediacontrols/mediaControlsiOS.css:
+ (video::-webkit-media-show-controls):
+
</ins><span class="cx"> 2015-08-07 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Expand network cache tests to cover memory cache behavior
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsApplecss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (188212 => 188213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2015-08-10 16:01:19 UTC (rev 188213)
</span><span class="lines">@@ -119,6 +119,8 @@
</span><span class="cx"> width: 100%;
</span><span class="cx"> height: 10px;
</span><span class="cx"> opacity: 0;
</span><ins>+ border: 0;
+ background: none;
</ins><span class="cx"> -webkit-appearance: none;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (188212 => 188213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2015-08-10 14:12:19 UTC (rev 188212)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2015-08-10 16:01:19 UTC (rev 188213)
</span><span class="lines">@@ -145,6 +145,8 @@
</span><span class="cx"> width: 100%;
</span><span class="cx"> height: 10px;
</span><span class="cx"> opacity: 0;
</span><ins>+ border: 0;
+ background: none;
</ins><span class="cx"> -webkit-appearance: none;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>