<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[188119] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/188119">188119</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-08-07 01:15:13 -0700 (Fri, 07 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Create [CustomBinding] extended IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=146593
Reviewed by Geoffrey Garen.
Added the [CustomBinding] IDL extended attribute. The idea is that when using this attribute, bindings generate
only the signature of the JS functions and we have to implement all the access in the Custom.cpp files, meaning
accessing the implementations at our wish.
Added customBindingMethod, customBindingMethodWithArgs to the generator tests.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skipped [CustomBinding] methods.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Consider CustomBinding as ForwardDeclareInHeader.
(GenerateImplementation): Avoid printing both header and implementation of the function.
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipFunction): Skipped [CustomBinding] methods.
* bindings/scripts/IDLAttributes.txt: Added [CustomBinding] IDL extended attribute.
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/TestObj.idl: Added customBindingMethod, customBindingMethodWithArgs and their
expectations.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLAttributestxt">trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjh">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestObjidl">trunk/Source/WebCore/bindings/scripts/test/TestObj.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2015-08-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
+ Create [CustomBinding] extended IDL attribute
+ https://bugs.webkit.org/show_bug.cgi?id=146593
+
+ Reviewed by Geoffrey Garen.
+
+ Added the [CustomBinding] IDL extended attribute. The idea is that when using this attribute, bindings generate
+ only the signature of the JS functions and we have to implement all the access in the Custom.cpp files, meaning
+ accessing the implementations at our wish.
+
+ Added customBindingMethod, customBindingMethodWithArgs to the generator tests.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (SkipFunction): Skipped [CustomBinding] methods.
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateHeader): Consider CustomBinding as ForwardDeclareInHeader.
+ (GenerateImplementation): Avoid printing both header and implementation of the function.
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (SkipFunction): Skipped [CustomBinding] methods.
+ * bindings/scripts/IDLAttributes.txt: Added [CustomBinding] IDL extended attribute.
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ * bindings/scripts/test/TestObj.idl: Added customBindingMethod, customBindingMethodWithArgs and their
+ expectations.
+
</ins><span class="cx"> 2015-08-06 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> Source/WebCore/crypto code should pass std::function<> objects through rvalue references
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -283,7 +283,7 @@
</span><span class="cx">
</span><span class="cx"> my $functionName = "webkit_dom_" . $decamelize . "_" . $prefix . decamelize($function->signature->name);
</span><span class="cx"> my $functionReturnType = $prefix eq "set_" ? "void" : $function->signature->type;
</span><del>- my $isCustomFunction = $function->signature->extendedAttributes->{"Custom"};
</del><ins>+ my $isCustomFunction = $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"CustomBinding"};
</ins><span class="cx"> my $callWith = $function->signature->extendedAttributes->{"CallWith"};
</span><span class="cx"> my $isUnsupportedCallWith = $codeGenerator->ExtendedAttributeContains($callWith, "ScriptArguments") || $codeGenerator->ExtendedAttributeContains($callWith, "CallStack");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -1092,7 +1092,7 @@
</span><span class="cx"> foreach my $function (@{$interface->functions}) {
</span><span class="cx"> $numCustomFunctions++ if HasCustomMethod($function->signature->extendedAttributes);
</span><span class="cx">
</span><del>- if ($function->signature->extendedAttributes->{"ForwardDeclareInHeader"}) {
</del><ins>+ if ($function->signature->extendedAttributes->{"ForwardDeclareInHeader"} or $function->signature->extendedAttributes->{"CustomBinding"}) {
</ins><span class="cx"> $hasForwardDeclaringFunctions = 1;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -1225,7 +1225,7 @@
</span><span class="cx"> push(@headerContent,"// Functions\n\n");
</span><span class="cx"> foreach my $function (@{$interface->functions}) {
</span><span class="cx"> next if $function->{overloadIndex} && $function->{overloadIndex} > 1;
</span><del>- next unless $function->signature->extendedAttributes->{"ForwardDeclareInHeader"};
</del><ins>+ next unless $function->signature->extendedAttributes->{"ForwardDeclareInHeader"} or $function->signature->extendedAttributes->{"CustomBinding"};
</ins><span class="cx">
</span><span class="cx"> my $needsAppleCopyright = $function->signature->extendedAttributes->{"AppleCopyright"};
</span><span class="cx"> if ($needsAppleCopyright) {
</span><span class="lines">@@ -1246,6 +1246,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> push(@headerContent, $endAppleCopyright) if $inAppleCopyright;
</span><ins>+ push(@headerContent,"\n");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ($hasForwardDeclaringAttributes) {
</span><span class="lines">@@ -1743,6 +1744,7 @@
</span><span class="cx"> foreach my $function (@{$interface->functions}) {
</span><span class="cx"> next if $function->{overloadIndex} && $function->{overloadIndex} > 1;
</span><span class="cx"> next if $function->signature->extendedAttributes->{"ForwardDeclareInHeader"};
</span><ins>+ next if $function->signature->extendedAttributes->{"CustomBinding"};
</ins><span class="cx">
</span><span class="cx"> my $needsAppleCopyright = $function->signature->extendedAttributes->{"AppleCopyright"};
</span><span class="cx"> if ($needsAppleCopyright) {
</span><span class="lines">@@ -2760,6 +2762,7 @@
</span><span class="cx"> if ($numFunctions > 0) {
</span><span class="cx"> my $inAppleCopyright = 0;
</span><span class="cx"> foreach my $function (@{$interface->functions}) {
</span><ins>+ next if $function->signature->extendedAttributes->{"CustomBinding"};
</ins><span class="cx"> my $needsAppleCopyright = $function->signature->extendedAttributes->{"AppleCopyright"};
</span><span class="cx"> if ($needsAppleCopyright) {
</span><span class="cx"> if (!$inAppleCopyright) {
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -538,6 +538,7 @@
</span><span class="cx"> return 1 if $codeGenerator->GetArrayType($function->signature->type);
</span><span class="cx">
</span><span class="cx"> return 1 if $function->signature->type eq "Promise";
</span><ins>+ return 1 if $function->signature->extendedAttributes->{"CustomBinding"};
</ins><span class="cx">
</span><span class="cx"> foreach my $param (@{$function->parameters}) {
</span><span class="cx"> return 1 if $codeGenerator->GetSequenceType($param->type);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLAttributestxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> ConstructorRaisesException
</span><span class="cx"> ConstructorTemplate=Event|TypedArray
</span><span class="cx"> Custom
</span><ins>+CustomBinding
</ins><span class="cx"> CustomCall
</span><span class="cx"> CustomConstructor
</span><span class="cx"> CustomDeleteProperty
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -598,6 +598,8 @@
</span><span class="cx"> { "methodWithException", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithException), (intptr_t) (0) },
</span><span class="cx"> { "customMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionCustomMethod), (intptr_t) (0) },
</span><span class="cx"> { "customMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionCustomMethodWithArgs), (intptr_t) (3) },
</span><ins>+ { "customBindingMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionCustomBindingMethod), (intptr_t) (0) },
+ { "customBindingMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionCustomBindingMethodWithArgs), (intptr_t) (3) },
</ins><span class="cx"> { "addEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionAddEventListener), (intptr_t) (2) },
</span><span class="cx"> { "removeEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionRemoveEventListener), (intptr_t) (2) },
</span><span class="cx"> { "withScriptStateVoid", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptStateVoid), (intptr_t) (0) },
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -101,7 +101,12 @@
</span><span class="cx"> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, TestObj*);
</span><span class="cx"> inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, TestObj& impl) { return toJS(exec, globalObject, &impl); }
</span><span class="cx">
</span><ins>+// Functions
</ins><span class="cx">
</span><ins>+JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionCustomBindingMethod(JSC::ExecState*);
+JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionCustomBindingMethodWithArgs(JSC::ExecState*);
+
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestObjidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestObj.idl (188118 => 188119)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2015-08-07 08:15:13 UTC (rev 188119)
</span><span class="lines">@@ -109,6 +109,10 @@
</span><span class="cx"> [Custom] void customMethod();
</span><span class="cx"> [Custom] void customMethodWithArgs(long longArg, DOMString strArg, TestObj objArg);
</span><span class="cx">
</span><ins>+ // 'CustomBinding' extended attribute
+ [CustomBinding] void customBindingMethod();
+ [CustomBinding] void customBindingMethodWithArgs(long longArg, DOMString strArg, TestObj objArg);
+
</ins><span class="cx"> void addEventListener(DOMString type, EventListener listener, optional boolean useCapture);
</span><span class="cx"> void removeEventListener(DOMString type, EventListener listener, optional boolean useCapture);
</span><span class="cx"> attribute EventHandler onfoo;
</span></span></pre>
</div>
</div>
</body>
</html>