<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[187975] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/187975">187975</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2015-08-05 12:54:12 -0700 (Wed, 05 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AppScale: Use https URLs for subresources and links
https://bugs.webkit.org/show_bug.cgi?id=147686
Reviewed by Ryosuke Niwa.
* QueueStatusServer/filters/webkit_extras.py:
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
* TestResultServer/static-dashboards/treemap.js:
* TestResultServer/static-dashboards/ui.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsQueueStatusServerfilterswebkit_extraspy">trunk/Tools/QueueStatusServer/filters/webkit_extras.py</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsdashboard_basejs">trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs">trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsflakiness_dashboard_unittestsjs">trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardstreemapjs">trunk/Tools/TestResultServer/static-dashboards/treemap.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsuijs">trunk/Tools/TestResultServer/static-dashboards/ui.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (187974 => 187975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-08-05 19:31:35 UTC (rev 187974)
+++ trunk/Tools/ChangeLog 2015-08-05 19:54:12 UTC (rev 187975)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-08-05 Alexey Proskuryakov <ap@apple.com>
+
+ AppScale: Use https URLs for subresources and links
+ https://bugs.webkit.org/show_bug.cgi?id=147686
+
+ Reviewed by Ryosuke Niwa.
+
+ * QueueStatusServer/filters/webkit_extras.py:
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+ * TestResultServer/static-dashboards/treemap.js:
+ * TestResultServer/static-dashboards/ui.js:
+
</ins><span class="cx"> 2015-08-04 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename Mutex to DeprecatedMutex
</span></span></pre></div>
<a id="trunkToolsQueueStatusServerfilterswebkit_extraspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/QueueStatusServer/filters/webkit_extras.py (187974 => 187975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/QueueStatusServer/filters/webkit_extras.py 2015-08-05 19:31:35 UTC (rev 187974)
+++ trunk/Tools/QueueStatusServer/filters/webkit_extras.py 2015-08-05 19:54:12 UTC (rev 187975)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> @register.filter
</span><span class="cx"> @stringfilter
</span><span class="cx"> def webkit_linkify(value):
</span><del>- value = bug_regexp.sub(r'<a href="http://webkit.org/b/\g<bug_id>">bug \g<bug_id></a>', value)
</del><ins>+ value = bug_regexp.sub(r'<a href="https://webkit.org/b/\g<bug_id>">bug \g<bug_id></a>', value)
</ins><span class="cx"> value = patch_regexp.sub(r'<a href="https://bugs.webkit.org/attachment.cgi?id=\g<patch_id>&action=prettypatch">patch \g<patch_id></a>', value)
</span><span class="cx"> return value
</span><span class="cx">
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> @register.filter
</span><span class="cx"> @stringfilter
</span><span class="cx"> def webkit_bug_id(value):
</span><del>- return '<a href="http://webkit.org/b/%s">%s</a>' % (value, value)
</del><ins>+ return '<a href="https://webkit.org/b/%s">%s</a>' % (value, value)
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> @register.filter
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsdashboard_basejs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (187974 => 187975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2015-08-05 19:31:35 UTC (rev 187974)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2015-08-05 19:54:12 UTC (rev 187975)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> var ONE_WEEK_SECONDS = ONE_DAY_SECONDS * 7;
</span><span class="cx">
</span><span class="cx"> // These should match the testtype uploaded to webkit-test-results.webkit.org.
</span><del>-// See http://webkit-test-results.webkit.org/testfile.
</del><ins>+// See https://webkit-test-results.webkit.org/testfile.
</ins><span class="cx"> var TEST_TYPES = [
</span><span class="cx"> 'layout-tests'
</span><span class="cx"> ];
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (187974 => 187975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2015-08-05 19:31:35 UTC (rev 187974)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2015-08-05 19:54:12 UTC (rev 187975)
</span><span class="lines">@@ -33,8 +33,8 @@
</span><span class="cx"> var FORWARD = 'forward';
</span><span class="cx"> var BACKWARD = 'backward';
</span><span class="cx"> var GTEST_MODIFIERS = ['FLAKY', 'FAILS', 'MAYBE', 'DISABLED'];
</span><del>-var TEST_URL_BASE_PATH_TRAC = 'http://trac.webkit.org/browser/trunk/LayoutTests/';
-var TEST_URL_BASE_PATH = "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/";
</del><ins>+var TEST_URL_BASE_PATH_TRAC = 'https://trac.webkit.org/browser/trunk/LayoutTests/';
+var TEST_URL_BASE_PATH = "https://svn.webkit.org/repository/webkit/trunk/LayoutTests/";
</ins><span class="cx"> var EXPECTATIONS_URL_BASE_PATH = TEST_URL_BASE_PATH + "platform/";
</span><span class="cx">
</span><span class="cx"> var PLATFORMS = {
</span><span class="lines">@@ -1092,7 +1092,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><del>-var BUG_URL_PREFIX = '<a href="http://';
</del><ins>+var BUG_URL_PREFIX = '<a href="https://';
</ins><span class="cx"> var BUG_URL_POSTFIX = '/$1">crbug.com/$1</a> ';
</span><span class="cx"> var WEBKIT_BUG_URL_POSTFIX = '/$1">webkit.org/b/$1</a> ';
</span><span class="cx"> var INTERNAL_BUG_REPLACE_VALUE = BUG_URL_PREFIX + 'b' + BUG_URL_POSTFIX;
</span><span class="lines">@@ -1182,7 +1182,7 @@
</span><span class="cx"> html += '<ul><li>' + linkHTMLToOpenWindow(buildBasePath, 'Build log') +
</span><span class="cx"> '</li><li>' +
</span><span class="cx"> createBlameListHTML(g_resultsByBuilder[builder].webkitRevision, index,
</span><del>- 'http://trac.webkit.org/log/?verbose=on&rev=', '&stop_rev=',
</del><ins>+ 'https://trac.webkit.org/log/?verbose=on&rev=', '&stop_rev=',
</ins><span class="cx"> 'WebKit') +
</span><span class="cx"> '</li>';
</span><span class="cx">
</span><span class="lines">@@ -1857,14 +1857,14 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> var url = base + platformPart + path;
</span><del>- if (isImage || !string.startsWith(base, 'http://svn.webkit.org')) {
</del><ins>+ if (isImage || !string.startsWith(base, 'https://svn.webkit.org')) {
</ins><span class="cx"> var dummyNode = document.createElement(isImage ? 'img' : 'script');
</span><span class="cx"> dummyNode.src = url;
</span><span class="cx"> dummyNode.onload = function() {
</span><span class="cx"> var item;
</span><span class="cx"> if (isImage) {
</span><span class="cx"> item = dummyNode;
</span><del>- if (string.startsWith(base, 'http://svn.webkit.org'))
</del><ins>+ if (string.startsWith(base, 'https://svn.webkit.org'))
</ins><span class="cx"> maybeAddPngChecksum(item, url);
</span><span class="cx"> } else {
</span><span class="cx"> item = document.createElement('iframe');
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsflakiness_dashboard_unittestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (187974 => 187975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2015-08-05 19:31:35 UTC (rev 187974)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2015-08-05 19:54:12 UTC (rev 187975)
</span><span class="lines">@@ -400,7 +400,7 @@
</span><span class="cx">
</span><span class="cx"> var tests = [test1, test2];
</span><span class="cx"> equal(htmlForIndividualTests(tests),
</span><del>- '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
</del><ins>+ '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
</ins><span class="cx"> htmlForIndividualTestOnAllBuilders(test1) +
</span><span class="cx"> '<div class=expectations test=foo/nonexistant.html>' +
</span><span class="cx"> '<div><span class=link onclick=\"g_history.setQueryParameter(\'showExpectations\', true)\">Show results</span> | ' +
</span><span class="lines">@@ -408,7 +408,7 @@
</span><span class="cx"> '<b>Only shows actual results/diffs from the most recent *failure* on each bot.</b></div>' +
</span><span class="cx"> '</div>' +
</span><span class="cx"> '<hr>' +
</span><del>- '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
</del><ins>+ '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
</ins><span class="cx"> htmlForIndividualTestOnAllBuilders(test2) +
</span><span class="cx"> '<div class=expectations test=bar/nonexistant.html>' +
</span><span class="cx"> '<div><span class=link onclick=\"g_history.setQueryParameter(\'showExpectations\', true)\">Show results</span> | ' +
</span><span class="lines">@@ -427,14 +427,14 @@
</span><span class="cx"> historyInstance.dashboardSpecificState.showChrome = true;
</span><span class="cx">
</span><span class="cx"> equal(htmlForIndividualTests(tests),
</span><del>- '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
</del><ins>+ '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
</ins><span class="cx"> htmlForIndividualTestOnAllBuildersWithResultsLinks(test1));
</span><span class="cx">
</span><span class="cx"> tests = [test1, test2];
</span><span class="cx"> equal(htmlForIndividualTests(tests),
</span><del>- '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
</del><ins>+ '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
</ins><span class="cx"> htmlForIndividualTestOnAllBuildersWithResultsLinks(test1) + '<hr>' +
</span><del>- '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
</del><ins>+ '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
</ins><span class="cx"> htmlForIndividualTestOnAllBuildersWithResultsLinks(test2));
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardstreemapjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/treemap.js (187974 => 187975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/treemap.js 2015-08-05 19:31:35 UTC (rev 187974)
+++ trunk/Tools/TestResultServer/static-dashboards/treemap.js 2015-08-05 19:54:12 UTC (rev 187975)
</span><span class="lines">@@ -97,7 +97,7 @@
</span><span class="cx"> var g_history = new history.History(treemapConfig);
</span><span class="cx"> g_history.parseCrossDashboardParameters();
</span><span class="cx">
</span><del>-var TEST_URL_BASE_PATH = "http://svn.webkit.org/repository/webkit/trunk/";
</del><ins>+var TEST_URL_BASE_PATH = "https://svn.webkit.org/repository/webkit/trunk/";
</ins><span class="cx">
</span><span class="cx"> function humanReadableTime(milliseconds)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsuijs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/ui.js (187974 => 187975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/ui.js 2015-08-05 19:31:35 UTC (rev 187974)
+++ trunk/Tools/TestResultServer/static-dashboards/ui.js 2015-08-05 19:54:12 UTC (rev 187975)
</span><span class="lines">@@ -182,8 +182,8 @@
</span><span class="cx"> results,
</span><span class="cx"> index,
</span><span class="cx"> WEBKIT_REVISIONS_KEY,
</span><del>- 'http://trac.webkit.org/changeset/<rev>',
- 'http://trac.webkit.org/log/trunk/?rev=<rev1>&stop_rev=<rev2>&limit=100&verbose=on');
</del><ins>+ 'https://trac.webkit.org/changeset/<rev>',
+ 'https://trac.webkit.org/log/trunk/?rev=<rev1>&stop_rev=<rev2>&limit=100&verbose=on');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>