<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[187934] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/187934">187934</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-04 20:33:18 -0700 (Tue, 04 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Editing tests have been broken since <a href="http://trac.webkit.org/projects/webkit/changeset/186694">r186694</a>
https://bugs.webkit.org/show_bug.cgi?id=146888
Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-08-04
Reviewed by Brent Fulgham.
Tools:
Restored some codes for the context click on GTK+ and EFL port.
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
LayoutTests:
Unskip the failure tests related with <a href="http://trac.webkit.org/projects/webkit/changeset/186694">r186694</a>.
* platform/efl/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleEventSendingControllercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (187933 => 187934)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/LayoutTests/ChangeLog 2015-08-05 03:33:18 UTC (rev 187934)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-08-04 Hunseop Jeong <hs85.jeong@samsung.com>
+
+ [EFL] Editing tests have been broken since r186694
+ https://bugs.webkit.org/show_bug.cgi?id=146888
+
+ Reviewed by Brent Fulgham.
+
+ Unskip the failure tests related with r186694.
+
+ * platform/efl/TestExpectations:
+
</ins><span class="cx"> 2015-08-04 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> El Capitan test result gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (187933 => 187934)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2015-08-05 03:33:18 UTC (rev 187934)
</span><span class="lines">@@ -2251,9 +2251,3 @@
</span><span class="cx"> webkit.org/b/146887 accessibility/table-fallback-roles-expose-element-attributes.html [ Failure ]
</span><span class="cx"> webkit.org/b/146887 accessibility/table-with-footer-section-above-body.html [ Failure ]
</span><span class="cx"> webkit.org/b/146887 accessibility/table-with-missing-aria-role-rows.html [ Failure ]
</span><del>-
-webkit.org/b/146888 editing/selection/5354455-1.html [ Failure ]
-webkit.org/b/146888 editing/selection/5354455-2.html [ Failure ]
-webkit.org/b/146888 editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ]
-webkit.org/b/146888 editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ]
-webkit.org/b/146888 editing/spelling/context-menu-suggestions.html [ Failure ]
</del></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (187933 => 187934)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/Tools/ChangeLog 2015-08-05 03:33:18 UTC (rev 187934)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-08-04 Hunseop Jeong <hs85.jeong@samsung.com>
+
+ [EFL] Editing tests have been broken since r186694
+ https://bugs.webkit.org/show_bug.cgi?id=146888
+
+ Reviewed by Brent Fulgham.
+
+ Restored some codes for the context click on GTK+ and EFL port.
+
+ * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
+ (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
+
</ins><span class="cx"> 2015-08-04 Dewei Zhu <dewei_zhu@apple.com>
</span><span class="cx">
</span><span class="cx"> Install twisted package for http server when necessary.
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleEventSendingControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp (187933 => 187934)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2015-08-05 03:33:18 UTC (rev 187934)
</span><span class="lines">@@ -475,7 +475,14 @@
</span><span class="cx"> WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
</span><span class="cx"> JSContextRef context = WKBundleFrameGetJavaScriptContext(mainFrame);
</span><span class="cx"> #if ENABLE(CONTEXT_MENUS)
</span><ins>+#if PLATFORM(GTK) || PLATFORM(EFL)
+ // Do mouse context click.
+ mouseDown(2, 0);
+ mouseUp(2, 0);
+ WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuItems(page));
+#else
</ins><span class="cx"> WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuAtPointInWindow(page, m_position));
</span><ins>+#endif
</ins><span class="cx"> JSValueRef arrayResult = JSObjectMakeArray(context, 0, 0, 0);
</span><span class="cx"> JSObjectRef arrayObj = JSValueToObject(context, arrayResult, 0);
</span><span class="cx"> size_t entriesSize = WKArrayGetSize(menuEntries.get());
</span></span></pre>
</div>
</div>
</body>
</html>