<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[187927] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/187927">187927</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2015-08-04 18:08:30 -0700 (Tue, 04 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove another unused database function
https://bugs.webkit.org/show_bug.cgi?id=147670
Reviewed by Daniel Bates.
This was used back when we had WebSQL support in workers, we can safely remove all these functions now.
* Modules/webdatabase/AbstractDatabaseServer.h:
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::interruptAllDatabasesForContext): Deleted.
* Modules/webdatabase/DatabaseManager.h:
* Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::interruptAllDatabasesForContext): Deleted.
* Modules/webdatabase/DatabaseServer.h:
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::interruptAllDatabasesForContext): Deleted.
* Modules/webdatabase/DatabaseTracker.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseAbstractDatabaseServerh">trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseManagercpp">trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseManagerh">trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseServercpp">trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseServerh">trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseTrackercpp">trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseTrackerh">trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/ChangeLog 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2015-08-04 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Remove another unused database function
+ https://bugs.webkit.org/show_bug.cgi?id=147670
+
+ Reviewed by Daniel Bates.
+
+ This was used back when we had WebSQL support in workers, we can safely remove all these functions now.
+
+ * Modules/webdatabase/AbstractDatabaseServer.h:
+ * Modules/webdatabase/DatabaseManager.cpp:
+ (WebCore::DatabaseManager::interruptAllDatabasesForContext): Deleted.
+ * Modules/webdatabase/DatabaseManager.h:
+ * Modules/webdatabase/DatabaseServer.cpp:
+ (WebCore::DatabaseServer::interruptAllDatabasesForContext): Deleted.
+ * Modules/webdatabase/DatabaseServer.h:
+ * Modules/webdatabase/DatabaseTracker.cpp:
+ (WebCore::DatabaseTracker::interruptAllDatabasesForContext): Deleted.
+ * Modules/webdatabase/DatabaseTracker.h:
+
+2015-08-04 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Remove database thread pause code
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=147669
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseAbstractDatabaseServerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -73,8 +73,6 @@
</span><span class="cx"> virtual bool deleteOrigin(SecurityOrigin*) = 0;
</span><span class="cx"> virtual bool deleteDatabase(SecurityOrigin*, const String& name) = 0;
</span><span class="cx">
</span><del>- virtual void interruptAllDatabasesForContext(const DatabaseContext*) = 0;
-
</del><span class="cx"> protected:
</span><span class="cx"> AbstractDatabaseServer() { }
</span><span class="cx"> virtual ~AbstractDatabaseServer() { }
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -402,13 +402,6 @@
</span><span class="cx"> m_server->closeAllDatabases();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseManager::interruptAllDatabasesForContext(ScriptExecutionContext* context)
-{
- RefPtr<DatabaseContext> databaseContext = existingDatabaseContextFor(context);
- if (databaseContext)
- m_server->interruptAllDatabasesForContext(databaseContext.get());
-}
-
</del><span class="cx"> void DatabaseManager::logErrorMessage(ScriptExecutionContext* context, const String& message)
</span><span class="cx"> {
</span><span class="cx"> context->addConsoleMessage(MessageSource::Storage, MessageLevel::Error, message);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseManagerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -106,8 +106,6 @@
</span><span class="cx"> WEBCORE_EXPORT bool deleteOrigin(SecurityOrigin*);
</span><span class="cx"> WEBCORE_EXPORT bool deleteDatabase(SecurityOrigin*, const String& name);
</span><span class="cx">
</span><del>- void interruptAllDatabasesForContext(ScriptExecutionContext*);
-
</del><span class="cx"> private:
</span><span class="cx"> class ProposedDatabase {
</span><span class="cx"> public:
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseServercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.cpp (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.cpp 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.cpp 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -113,11 +113,6 @@
</span><span class="cx"> DatabaseTracker::tracker().closeAllDatabases();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseServer::interruptAllDatabasesForContext(const DatabaseContext* context)
-{
- DatabaseTracker::tracker().interruptAllDatabasesForContext(context);
-}
-
</del><span class="cx"> RefPtr<DatabaseBackendBase> DatabaseServer::openDatabase(RefPtr<DatabaseContext>& backendContext, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError &error, String& errorMessage,
</span><span class="cx"> OpenAttempt attempt)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseServerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -62,8 +62,6 @@
</span><span class="cx"> bool deleteOrigin(SecurityOrigin*) override;
</span><span class="cx"> bool deleteDatabase(SecurityOrigin*, const String& name) override;
</span><span class="cx">
</span><del>- void interruptAllDatabasesForContext(const DatabaseContext*) override;
-
</del><span class="cx"> protected:
</span><span class="cx"> virtual RefPtr<DatabaseBackendBase> createDatabase(RefPtr<DatabaseContext>&, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError&, String& errorMessage);
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseTrackercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -325,31 +325,6 @@
</span><span class="cx"> database->close();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DatabaseTracker::interruptAllDatabasesForContext(const DatabaseContext* context)
-{
- Vector<RefPtr<DatabaseBackendBase>> openDatabases;
- {
- MutexLocker openDatabaseMapLock(m_openDatabaseMapGuard);
-
- if (!m_openDatabaseMap)
- return;
-
- DatabaseNameMap* nameMap = m_openDatabaseMap->get(context->securityOrigin());
- if (!nameMap)
- return;
-
- for (auto& databaseSet : nameMap->values()) {
- for (auto& database : *databaseSet) {
- if (database->databaseContext() == context)
- openDatabases.append(database);
- }
- }
- }
-
- for (auto& openDatabase : openDatabases)
- openDatabase->interrupt();
-}
-
</del><span class="cx"> String DatabaseTracker::originPath(SecurityOrigin* origin) const
</span><span class="cx"> {
</span><span class="cx"> return SQLiteFileSystem::appendDatabaseFileNameToPath(m_databaseDirectoryPath.isolatedCopy(), origin->databaseIdentifier());
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseTrackerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h (187926 => 187927)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h 2015-08-05 00:57:51 UTC (rev 187926)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h 2015-08-05 01:08:30 UTC (rev 187927)
</span><span class="lines">@@ -76,8 +76,6 @@
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void closeAllDatabases();
</span><span class="cx">
</span><del>- void interruptAllDatabasesForContext(const DatabaseContext*);
-
</del><span class="cx"> private:
</span><span class="cx"> explicit DatabaseTracker(const String& databasePath);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>