<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[187760] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/187760">187760</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-08-03 13:47:54 -0700 (Mon, 03 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up the naming for AST expression generation.
https://bugs.webkit.org/show_bug.cgi?id=147581
Patch by Keith Miller <keith_miller@apple.com> on 2015-08-03
Reviewed by Yusuke Suzuki.
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createThisExpr):
(JSC::ASTBuilder::createSuperExpr):
(JSC::ASTBuilder::createNewTargetExpr):
(JSC::ASTBuilder::thisExpr): Deleted.
(JSC::ASTBuilder::superExpr): Deleted.
(JSC::ASTBuilder::newTargetExpr): Deleted.
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createThisExpr):
(JSC::SyntaxChecker::createSuperExpr):
(JSC::SyntaxChecker::createNewTargetExpr):
(JSC::SyntaxChecker::thisExpr): Deleted.
(JSC::SyntaxChecker::superExpr): Deleted.
(JSC::SyntaxChecker::newTargetExpr): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserASTBuilderh">trunk/Source/JavaScriptCore/parser/ASTBuilder.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserParsercpp">trunk/Source/JavaScriptCore/parser/Parser.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserSyntaxCheckerh">trunk/Source/JavaScriptCore/parser/SyntaxChecker.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (187759 => 187760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-08-03 20:46:01 UTC (rev 187759)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-08-03 20:47:54 UTC (rev 187760)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2015-08-03 Keith Miller <keith_miller@apple.com>
+
+ Clean up the naming for AST expression generation.
+ https://bugs.webkit.org/show_bug.cgi?id=147581
+
+ Reviewed by Yusuke Suzuki.
+
+ * parser/ASTBuilder.h:
+ (JSC::ASTBuilder::createThisExpr):
+ (JSC::ASTBuilder::createSuperExpr):
+ (JSC::ASTBuilder::createNewTargetExpr):
+ (JSC::ASTBuilder::thisExpr): Deleted.
+ (JSC::ASTBuilder::superExpr): Deleted.
+ (JSC::ASTBuilder::newTargetExpr): Deleted.
+ * parser/Parser.cpp:
+ (JSC::Parser<LexerType>::parsePrimaryExpression):
+ (JSC::Parser<LexerType>::parseMemberExpression):
+ * parser/SyntaxChecker.h:
+ (JSC::SyntaxChecker::createThisExpr):
+ (JSC::SyntaxChecker::createSuperExpr):
+ (JSC::SyntaxChecker::createNewTargetExpr):
+ (JSC::SyntaxChecker::thisExpr): Deleted.
+ (JSC::SyntaxChecker::superExpr): Deleted.
+ (JSC::SyntaxChecker::newTargetExpr): Deleted.
+
</ins><span class="cx"> 2015-08-03 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Don't set up the callsite to operationGetByValDefault when the optimization is already done
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserASTBuilderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/ASTBuilder.h (187759 => 187760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/ASTBuilder.h 2015-08-03 20:46:01 UTC (rev 187759)
+++ trunk/Source/JavaScriptCore/parser/ASTBuilder.h 2015-08-03 20:47:54 UTC (rev 187760)
</span><span class="lines">@@ -168,16 +168,16 @@
</span><span class="cx"> incConstants();
</span><span class="cx"> return new (m_parserArena) VoidNode(location, expr);
</span><span class="cx"> }
</span><del>- ExpressionNode* thisExpr(const JSTokenLocation& location, ThisTDZMode thisTDZMode)
</del><ins>+ ExpressionNode* createThisExpr(const JSTokenLocation& location, ThisTDZMode thisTDZMode)
</ins><span class="cx"> {
</span><span class="cx"> usesThis();
</span><span class="cx"> return new (m_parserArena) ThisNode(location, thisTDZMode);
</span><span class="cx"> }
</span><del>- ExpressionNode* superExpr(const JSTokenLocation& location)
</del><ins>+ ExpressionNode* createSuperExpr(const JSTokenLocation& location)
</ins><span class="cx"> {
</span><span class="cx"> return new (m_parserArena) SuperNode(location);
</span><span class="cx"> }
</span><del>- ExpressionNode* newTargetExpr(const JSTokenLocation location)
</del><ins>+ ExpressionNode* createNewTargetExpr(const JSTokenLocation location)
</ins><span class="cx"> {
</span><span class="cx"> return new (m_parserArena) NewTargetNode(location);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Parser.cpp (187759 => 187760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Parser.cpp 2015-08-03 20:46:01 UTC (rev 187759)
+++ trunk/Source/JavaScriptCore/parser/Parser.cpp 2015-08-03 20:47:54 UTC (rev 187760)
</span><span class="lines">@@ -2766,7 +2766,7 @@
</span><span class="cx"> case THISTOKEN: {
</span><span class="cx"> JSTokenLocation location(tokenLocation());
</span><span class="cx"> next();
</span><del>- return context.thisExpr(location, m_thisTDZMode);
</del><ins>+ return context.createThisExpr(location, m_thisTDZMode);
</ins><span class="cx"> }
</span><span class="cx"> case IDENT: {
</span><span class="cx"> identifierExpression:
</span><span class="lines">@@ -2916,7 +2916,7 @@
</span><span class="cx"> if (m_vm->propertyNames->target == *ident) {
</span><span class="cx"> semanticFailIfFalse(currentScope()->isFunction(), "new.target is only valid inside functions");
</span><span class="cx"> baseIsNewTarget = true;
</span><del>- base = context.newTargetExpr(location);
</del><ins>+ base = context.createNewTargetExpr(location);
</ins><span class="cx"> newCount--;
</span><span class="cx"> next();
</span><span class="cx"> } else
</span><span class="lines">@@ -2926,7 +2926,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (baseIsSuper) {
</span><del>- base = context.superExpr(location);
</del><ins>+ base = context.createSuperExpr(location);
</ins><span class="cx"> next();
</span><span class="cx"> currentScope()->setNeedsSuperBinding();
</span><span class="cx"> } else if (!baseIsNewTarget)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserSyntaxCheckerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/SyntaxChecker.h (187759 => 187760)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/SyntaxChecker.h 2015-08-03 20:46:01 UTC (rev 187759)
+++ trunk/Source/JavaScriptCore/parser/SyntaxChecker.h 2015-08-03 20:47:54 UTC (rev 187760)
</span><span class="lines">@@ -152,9 +152,9 @@
</span><span class="cx"> ExpressionType createLogicalNot(const JSTokenLocation&, ExpressionType) { return UnaryExpr; }
</span><span class="cx"> ExpressionType createUnaryPlus(const JSTokenLocation&, ExpressionType) { return UnaryExpr; }
</span><span class="cx"> ExpressionType createVoid(const JSTokenLocation&, ExpressionType) { return UnaryExpr; }
</span><del>- ExpressionType thisExpr(const JSTokenLocation&, ThisTDZMode) { return ThisExpr; }
- ExpressionType superExpr(const JSTokenLocation&) { return SuperExpr; }
- ExpressionType newTargetExpr(const JSTokenLocation&) { return NewTargetExpr; }
</del><ins>+ ExpressionType createThisExpr(const JSTokenLocation&, ThisTDZMode) { return ThisExpr; }
+ ExpressionType createSuperExpr(const JSTokenLocation&) { return SuperExpr; }
+ ExpressionType createNewTargetExpr(const JSTokenLocation&) { return NewTargetExpr; }
</ins><span class="cx"> ExpressionType createResolve(const JSTokenLocation&, const Identifier*, int) { return ResolveExpr; }
</span><span class="cx"> ExpressionType createObjectLiteral(const JSTokenLocation&) { return ObjectLiteralExpr; }
</span><span class="cx"> ExpressionType createObjectLiteral(const JSTokenLocation&, int) { return ObjectLiteralExpr; }
</span></span></pre>
</div>
</div>
</body>
</html>