<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[187805] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/187805">187805</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2015-08-03 20:32:27 -0700 (Mon, 03 Aug 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up casts between NSFont*s and CTFontRefs
https://bugs.webkit.org/show_bug.cgi?id=147618
Source/WebCore:
Reviewed by Mitz Pettel.
For toll free bridged types, it makes more sense to do a C-style cast, than jump
through hoops for older compilers.
No new tests because there is no behavior change.
* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::nsFont):
(WebCore::FontPlatformData::hash):
Source/WebKit/mac:
Reviewed by Mitz Pettel
For toll free bridged types, it makes more sense to do a C-style cast, than jump
through hoops for older compilers.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateFontPanel]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontPlatformDatah">trunk/Source/WebCore/platform/graphics/FontPlatformData.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebHTMLViewmm">trunk/Source/WebKit/mac/WebView/WebHTMLView.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (187804 => 187805)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-08-04 03:21:43 UTC (rev 187804)
+++ trunk/Source/WebCore/ChangeLog 2015-08-04 03:32:27 UTC (rev 187805)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-08-03 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Clean up casts between NSFont*s and CTFontRefs
+ https://bugs.webkit.org/show_bug.cgi?id=147618
+
+ Reviewed by Mitz Pettel.
+
+ For toll free bridged types, it makes more sense to do a C-style cast, than jump
+ through hoops for older compilers.
+
+ No new tests because there is no behavior change.
+
+ * platform/graphics/FontPlatformData.h:
+ (WebCore::FontPlatformData::nsFont):
+ (WebCore::FontPlatformData::hash):
+
</ins><span class="cx"> 2015-08-03 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r187707, r187709, r187724, and
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsFontPlatformDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/FontPlatformData.h (187804 => 187805)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/FontPlatformData.h 2015-08-04 03:21:43 UTC (rev 187804)
+++ trunk/Source/WebCore/platform/graphics/FontPlatformData.h 2015-08-04 03:32:27 UTC (rev 187805)
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx">
</span><span class="cx"> #if USE(APPKIT)
</span><span class="cx"> // FIXME: Remove this when all NSFont usage is removed.
</span><del>- NSFont *nsFont() const { return reinterpret_cast<NSFont *>(const_cast<__CTFont*>(m_font.get())); }
</del><ins>+ NSFont *nsFont() const { return (NSFont *)m_font.get(); }
</ins><span class="cx"> void setNSFont(NSFont *font) { setFont(reinterpret_cast<CTFontRef>(font)); }
</span><span class="cx"> #endif
</span><span class="cx"> #endif
</span><span class="lines">@@ -153,7 +153,7 @@
</span><span class="cx"> ASSERT(m_font || !m_cgFont || isEmoji());
</span><span class="cx"> uintptr_t flags = static_cast<uintptr_t>(m_isHashTableDeletedValue << 4 | isEmoji() << 3 | m_orientation << 2 | m_syntheticBold << 1 | m_syntheticOblique);
</span><span class="cx"> #if USE(APPKIT)
</span><del>- uintptr_t fontHash = reinterpret_cast<uintptr_t>(const_cast<__CTFont*>(m_font.get()));
</del><ins>+ uintptr_t fontHash = (uintptr_t)m_font.get();
</ins><span class="cx"> #else
</span><span class="cx"> uintptr_t fontHash = reinterpret_cast<uintptr_t>(CFHash(m_font.get()));
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (187804 => 187805)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-08-04 03:21:43 UTC (rev 187804)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-08-04 03:32:27 UTC (rev 187805)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2015-08-03 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><ins>+ Clean up casts between NSFont*s and CTFontRefs
+ https://bugs.webkit.org/show_bug.cgi?id=147618
+
+ Reviewed by Mitz Pettel
+
+ For toll free bridged types, it makes more sense to do a C-style cast, than jump
+ through hoops for older compilers.
+
+ * WebView/WebHTMLView.mm:
+ (-[WebHTMLView _updateFontPanel]):
+
+2015-08-03 Myles C. Maxfield <mmaxfield@apple.com>
+
</ins><span class="cx"> Fix the Yosemite build after r187797
</span><span class="cx">
</span><span class="cx"> Unreviewed.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebHTMLViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (187804 => 187805)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-08-04 03:21:43 UTC (rev 187804)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-08-04 03:32:27 UTC (rev 187805)
</span><span class="lines">@@ -5485,7 +5485,7 @@
</span><span class="cx"> NSDictionary *attributes = nil;
</span><span class="cx"> if (Frame* coreFrame = core([self _frame])) {
</span><span class="cx"> if (const Font* fd = coreFrame->editor().fontForSelection(multipleFonts))
</span><del>- font = reinterpret_cast<NSFont *>(const_cast<__CTFont*>(fd->platformData().activatedFont()));
</del><ins>+ font = (NSFont *)fd->platformData().activatedFont();
</ins><span class="cx"> attributes = coreFrame->editor().fontAttributesForSelectionStart();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>