<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[187433] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/187433">187433</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-07-27 01:14:53 -0700 (Mon, 27 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Streams API] Strategy tests need sync with the reference
https://bugs.webkit.org/show_bug.cgi?id=147267
Reviewed by Sam Weinig.
The reference accepted a two new tests for the constructor and another for the size method for both strategies
that we need to bring to WebKit to ensure compliance. Expectations updated accordingly.
* streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
* streams/reference-implementation/byte-length-queuing-strategy.html:
* streams/reference-implementation/count-queuing-strategy-expected.txt:
* streams/reference-implementation/count-queuing-strategy.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbytelengthqueuingstrategyexpectedtxt">trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbytelengthqueuingstrategyhtml">trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy.html</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationcountqueuingstrategyexpectedtxt">trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationcountqueuingstrategyhtml">trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (187432 => 187433)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-07-27 08:07:28 UTC (rev 187432)
+++ trunk/LayoutTests/ChangeLog 2015-07-27 08:14:53 UTC (rev 187433)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-07-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
+ [Streams API] Strategy tests need sync with the reference
+ https://bugs.webkit.org/show_bug.cgi?id=147267
+
+ Reviewed by Sam Weinig.
+
+ The reference accepted a two new tests for the constructor and another for the size method for both strategies
+ that we need to bring to WebKit to ensure compliance. Expectations updated accordingly.
+
+ * streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
+ * streams/reference-implementation/byte-length-queuing-strategy.html:
+ * streams/reference-implementation/count-queuing-strategy-expected.txt:
+ * streams/reference-implementation/count-queuing-strategy.html:
+
</ins><span class="cx"> 2015-07-25 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r186569): media/restore-from-page-cache.html is very flaky
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbytelengthqueuingstrategyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy-expected.txt (187432 => 187433)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy-expected.txt 2015-07-27 08:07:28 UTC (rev 187432)
+++ trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy-expected.txt 2015-07-27 08:14:53 UTC (rev 187433)
</span><span class="lines">@@ -1,5 +1,7 @@
</span><span class="cx">
</span><span class="cx"> PASS Can construct a ByteLengthQueuingStrategy with a valid high water mark
</span><span class="cx"> PASS Can construct a ByteLengthQueuingStrategy with any value as its high water mark
</span><ins>+PASS ByteLengthQueuingStrategy constructor behaves as expected with wrong arguments
+PASS ByteLengthQueuingStrategy size behaves as expected with wrong arguments
</ins><span class="cx"> PASS ByteLengthQueuingStrategy instances have the correct properties
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbytelengthqueuingstrategyhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy.html (187432 => 187433)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy.html 2015-07-27 08:07:28 UTC (rev 187432)
+++ trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy.html 2015-07-27 08:14:53 UTC (rev 187433)
</span><span class="lines">@@ -16,6 +16,48 @@
</span><span class="cx"> }, 'Can construct a ByteLengthQueuingStrategy with any value as its high water mark');
</span><span class="cx">
</span><span class="cx"> test(function() {
</span><ins>+ var highWaterMark = 1;
+ var highWaterMarkObjectGetter = {
+ get highWaterMark() { return highWaterMark; },
+ };
+ var error = new Error('wow!');
+ var highWaterMarkObjectGetterThrowing = {
+ get highWaterMark() { throw error; },
+ };
+ assert_throws(new TypeError(), function() { new ByteLengthQueuingStrategy(); }, 'construction fails with undefined');
+ assert_throws(new TypeError(), function() { new ByteLengthQueuingStrategy(null); }, 'construction fails with null');
+ new ByteLengthQueuingStrategy('potato'); // Construction succeeds with a random non-object type.
+ new ByteLengthQueuingStrategy({}); // Construction succeeds with an object without a highWaterMark property.
+ new ByteLengthQueuingStrategy(highWaterMarkObjectGetter); // Construction succeeds with an object with a highWaterMark getter.
+ assert_throws(error, function() { new ByteLengthQueuingStrategy(highWaterMarkObjectGetterThrowing); },
+ 'construction fails with an object with a throwing highWaterMark getter');
+}, 'ByteLengthQueuingStrategy constructor behaves as expected with wrong arguments');
+
+test(function() {
+ var size = 1024;
+ var chunk = { byteLength: size };
+ var chunkGetter = {
+ get byteLength() { return size; },
+ }
+ var error = new Error('wow!');
+ var chunkGetterThrowing = {
+ get byteLength() { throw error; },
+ }
+ assert_throws(new TypeError(), function() { ByteLengthQueuingStrategy.prototype.size(); }, 'size fails with undefined');
+ assert_throws(new TypeError(), function() { ByteLengthQueuingStrategy.prototype.size(null); }, 'size fails with null');
+ assert_equals(ByteLengthQueuingStrategy.prototype.size('potato'), undefined,
+ 'size succeeds with undefined with a random non-object type');
+ assert_equals(ByteLengthQueuingStrategy.prototype.size({}), undefined,
+ 'size succeeds with undefined with an object without hwm property');
+ assert_equals(ByteLengthQueuingStrategy.prototype.size(chunk), size,
+ 'size succeeds with the right amount with an object with a hwm');
+ assert_equals(ByteLengthQueuingStrategy.prototype.size(chunkGetter), size,
+ 'size succeeds with the right amount with an object with a hwm getter');
+ assert_throws(error, function() { ByteLengthQueuingStrategy.prototype.size(chunkGetterThrowing); },
+ 'size fails with the error thrown by the getter');
+}, 'ByteLengthQueuingStrategy size behaves as expected with wrong arguments');
+
+test(function() {
</ins><span class="cx"> var strategy = new ByteLengthQueuingStrategy({ highWaterMark: 4 });
</span><span class="cx">
</span><span class="cx"> assert_object_equals(Object.getOwnPropertyDescriptor(strategy, 'highWaterMark'),
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationcountqueuingstrategyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt (187432 => 187433)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt 2015-07-27 08:07:28 UTC (rev 187432)
+++ trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt 2015-07-27 08:14:53 UTC (rev 187433)
</span><span class="lines">@@ -1,6 +1,8 @@
</span><span class="cx">
</span><span class="cx"> PASS Can construct a CountQueuingStrategy with a valid high water mark
</span><span class="cx"> PASS Can construct a CountQueuingStrategy with any value as its high water mark
</span><ins>+PASS CountQueuingStrategy constructor behaves as expected with wrong arguments
+PASS CountQueuingStrategy size behaves as expected with wrong arguments
</ins><span class="cx"> PASS CountQueuingStrategy instances have the correct properties
</span><span class="cx"> PASS Can construct a readable stream with a valid CountQueuingStrategy
</span><span class="cx"> PASS Correctly governs the return value of a ReadableStream's enqueue function (HWM = 0)
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationcountqueuingstrategyhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy.html (187432 => 187433)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy.html 2015-07-27 08:07:28 UTC (rev 187432)
+++ trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy.html 2015-07-27 08:14:53 UTC (rev 187433)
</span><span class="lines">@@ -16,6 +16,43 @@
</span><span class="cx"> }, 'Can construct a CountQueuingStrategy with any value as its high water mark');
</span><span class="cx">
</span><span class="cx"> test(function() {
</span><ins>+ var highWaterMark = 1;
+ var highWaterMarkObjectGetter = {
+ get highWaterMark() { return highWaterMark; },
+ };
+ var error = new Error('wow!');
+ var highWaterMarkObjectGetterThrowing = {
+ get highWaterMark() { throw error; },
+ };
+ assert_throws(new TypeError(), function() { new CountQueuingStrategy(); }, 'construction fails with undefined');
+ assert_throws(new TypeError(), function() { new CountQueuingStrategy(null); }, 'construction fails with null');
+ new CountQueuingStrategy('potato'); // Construction succeeds with a random non-object type.
+ new CountQueuingStrategy({}); // Construction succeeds with an object without a highWaterMark property.
+ new CountQueuingStrategy(highWaterMarkObjectGetter); // Construction succeeds with an object with a highWaterMark getter.
+ assert_throws(error, function() { new CountQueuingStrategy(highWaterMarkObjectGetterThrowing); },
+ 'construction fails with an object with a throwing highWaterMark getter');
+}, 'CountQueuingStrategy constructor behaves as expected with wrong arguments');
+
+test(function() {
+ var size = 1024;
+ var chunk = { byteLength: size };
+ var chunkGetter = {
+ get byteLength() { return size; },
+ }
+ var error = new Error('wow!');
+ var chunkGetterThrowing = {
+ get byteLength() { throw error; },
+ }
+ assert_equals(CountQueuingStrategy.prototype.size(), 1, 'size returns 1 with undefined');
+ assert_equals(CountQueuingStrategy.prototype.size(null), 1, 'size returns 1 with null');
+ assert_equals(CountQueuingStrategy.prototype.size('potato'), 1, 'size returns 1 with non-object type');
+ assert_equals(CountQueuingStrategy.prototype.size({}), 1, 'size returns 1 with empty object');
+ assert_equals(CountQueuingStrategy.prototype.size(chunk), 1, 'size returns 1 with a chunk');
+ assert_equals(CountQueuingStrategy.prototype.size(chunkGetter), 1, 'size returns 1 with chunk getter');
+ assert_equals(CountQueuingStrategy.prototype.size(chunkGetterThrowing), 1, 'size returns 1 with chunk getter that throws');
+}, 'CountQueuingStrategy size behaves as expected with wrong arguments');
+
+test(function() {
</ins><span class="cx"> var strategy = new CountQueuingStrategy({ highWaterMark: 4 });
</span><span class="cx">
</span><span class="cx"> assert_object_equals(Object.getOwnPropertyDescriptor(strategy, 'highWaterMark'),
</span></span></pre>
</div>
</div>
</body>
</html>