<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[187014] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/187014">187014</a></dd>
<dt>Author</dt> <dd>saambarati1@gmail.com</dd>
<dt>Date</dt> <dd>2015-07-19 12:31:36 -0700 (Sun, 19 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Parser::parseFunctionInfo hits RELEASE_ASSERT for Arrow Functions
https://bugs.webkit.org/show_bug.cgi?id=147090
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
ArrowFunction's have there ParserFunctionInfo "name" field to
be a non-null pointer. This is obviously allowed and valid except we
had a RELEASE_ASSERT that claimed otherwise. This is a mistake.
Note: ArrowFunction's will never actually have a function name;
there ParserFunctionInfo "name" field will be the empty string.
This is not be mistaken with the name field being a null pointer.
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
LayoutTests:
* js/arrowfunction-strict-mode-expected.txt: Added.
* js/arrowfunction-strict-mode.html: Added.
* js/script-tests/arrowfunction-strict-mode.js: Added.
(foo):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserParsercpp">trunk/Source/JavaScriptCore/parser/Parser.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsarrowfunctionstrictmodeexpectedtxt">trunk/LayoutTests/js/arrowfunction-strict-mode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsarrowfunctionstrictmodehtml">trunk/LayoutTests/js/arrowfunction-strict-mode.html</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsarrowfunctionstrictmodejs">trunk/LayoutTests/js/script-tests/arrowfunction-strict-mode.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (187013 => 187014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-07-19 19:14:44 UTC (rev 187013)
+++ trunk/LayoutTests/ChangeLog 2015-07-19 19:31:36 UTC (rev 187014)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-07-19 Saam barati <saambarati1@gmail.com>
+
+ Parser::parseFunctionInfo hits RELEASE_ASSERT for Arrow Functions
+ https://bugs.webkit.org/show_bug.cgi?id=147090
+
+ Reviewed by Yusuke Suzuki.
+
+ * js/arrowfunction-strict-mode-expected.txt: Added.
+ * js/arrowfunction-strict-mode.html: Added.
+ * js/script-tests/arrowfunction-strict-mode.js: Added.
+ (foo):
+
</ins><span class="cx"> 2015-07-18 Saam barati <saambarati1@gmail.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Add support for block scope const
</span></span></pre></div>
<a id="trunkLayoutTestsjsarrowfunctionstrictmodeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/arrowfunction-strict-mode-expected.txt (0 => 187014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/arrowfunction-strict-mode-expected.txt (rev 0)
+++ trunk/LayoutTests/js/arrowfunction-strict-mode-expected.txt 2015-07-19 19:31:36 UTC (rev 187014)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+Tests for ES6 arrow function, make sure parsing is OK in strict mode.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS f1(10) is 10
+PASS f2(20) is 20
+PASS f3(10, 20) is 30
+PASS f4(20, 20) is 40
+PASS foo(x => x + 1) is 11
+PASS foo((x) => x + 1) is 11
+PASS foo(x => { return x + 1; }) is 11
+PASS foo((x) => { return x + 1; }) is 11
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsjsarrowfunctionstrictmodehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/arrowfunction-strict-mode.html (0 => 187014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/arrowfunction-strict-mode.html (rev 0)
+++ trunk/LayoutTests/js/arrowfunction-strict-mode.html 2015-07-19 19:31:36 UTC (rev 187014)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="script-tests/arrowfunction-strict-mode.js"></script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsarrowfunctionstrictmodejs"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/script-tests/arrowfunction-strict-mode.js (0 => 187014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/arrowfunction-strict-mode.js (rev 0)
+++ trunk/LayoutTests/js/script-tests/arrowfunction-strict-mode.js 2015-07-19 19:31:36 UTC (rev 187014)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+"use strict";
+
+description('Tests for ES6 arrow function, make sure parsing is OK in strict mode.');
+
+var f1 = x => x;
+shouldBe("f1(10)", "10");
+
+var f2 = (x) => x;
+shouldBe("f2(20)", "20");
+
+var f3 = (x, y) => x + y;
+shouldBe("f3(10, 20)", "30");
+
+var f4 = (x, y) => { return x + y; };
+shouldBe("f4(20, 20)", "40");
+
+function foo(f) {
+ return f(10);
+}
+
+shouldBe("foo(x => x + 1)", "11");
+shouldBe("foo((x) => x + 1)", "11");
+shouldBe("foo(x => { return x + 1; })", "11");
+shouldBe("foo((x) => { return x + 1; })", "11");
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (187013 => 187014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-07-19 19:14:44 UTC (rev 187013)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-07-19 19:31:36 UTC (rev 187014)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-07-19 Saam barati <saambarati1@gmail.com>
+
+ Parser::parseFunctionInfo hits RELEASE_ASSERT for Arrow Functions
+ https://bugs.webkit.org/show_bug.cgi?id=147090
+
+ Reviewed by Yusuke Suzuki.
+
+ ArrowFunction's have there ParserFunctionInfo "name" field to
+ be a non-null pointer. This is obviously allowed and valid except we
+ had a RELEASE_ASSERT that claimed otherwise. This is a mistake.
+
+ Note: ArrowFunction's will never actually have a function name;
+ there ParserFunctionInfo "name" field will be the empty string.
+ This is not be mistaken with the name field being a null pointer.
+
+ * parser/Parser.cpp:
+ (JSC::Parser<LexerType>::parseFunctionInfo):
+
</ins><span class="cx"> 2015-07-18 Saam barati <saambarati1@gmail.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Add support for block scope const
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Parser.cpp (187013 => 187014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Parser.cpp 2015-07-19 19:14:44 UTC (rev 187013)
+++ trunk/Source/JavaScriptCore/parser/Parser.cpp 2015-07-19 19:31:36 UTC (rev 187014)
</span><span class="lines">@@ -1714,7 +1714,7 @@
</span><span class="cx"> failIfFalse(functionInfo.body, "Cannot parse the body of this ", stringForFunctionMode(mode));
</span><span class="cx"> context.setEndOffset(functionInfo.body, m_lexer->currentOffset());
</span><span class="cx"> if (functionScope->strictMode() && functionInfo.name) {
</span><del>- RELEASE_ASSERT(mode == NormalFunctionMode || mode == MethodMode);
</del><ins>+ RELEASE_ASSERT(mode == NormalFunctionMode || mode == MethodMode || mode == ArrowFunctionMode);
</ins><span class="cx"> semanticFailIfTrue(m_vm->propertyNames->arguments == *functionInfo.name, "'", functionInfo.name->impl(), "' is not a valid function name in strict mode");
</span><span class="cx"> semanticFailIfTrue(m_vm->propertyNames->eval == *functionInfo.name, "'", functionInfo.name->impl(), "' is not a valid function name in strict mode");
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>