<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186981] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186981">186981</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-07-17 20:46:22 -0700 (Fri, 17 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>(display: block)input range's thumb disappears when moved.
https://bugs.webkit.org/show_bug.cgi?id=146896
<rdar://problem/21787807>
Reviewed by Simon Fraser.
Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
issued during the layout will not cover the re-positioned thumb.
We need to issue a repaint soon after the thumb is re-positioned.
Source/WebCore:
Test: fast/repaint/block-inputrange-repaint.html
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):
LayoutTests:
* fast/repaint/block-inputrange-repaint-expected.txt: Added.
* fast/repaint/block-inputrange-repaint.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementcpp">trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepaintblockinputrangerepaintexpectedtxt">trunk/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepaintblockinputrangerepainthtml">trunk/LayoutTests/fast/repaint/block-inputrange-repaint.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (186980 => 186981)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-07-18 03:16:32 UTC (rev 186980)
+++ trunk/LayoutTests/ChangeLog 2015-07-18 03:46:22 UTC (rev 186981)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-07-17 Zalan Bujtas <zalan@apple.com>
+
+ (display: block)input range's thumb disappears when moved.
+ https://bugs.webkit.org/show_bug.cgi?id=146896
+ <rdar://problem/21787807>
+
+ Reviewed by Simon Fraser.
+
+ Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
+ issued during the layout will not cover the re-positioned thumb.
+ We need to issue a repaint soon after the thumb is re-positioned.
+
+ * fast/repaint/block-inputrange-repaint-expected.txt: Added.
+ * fast/repaint/block-inputrange-repaint.html: Added.
+
</ins><span class="cx"> 2015-07-17 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Improve rect shrink-wrapping algorithm
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintblockinputrangerepaintexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt (0 => 186981)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/repaint/block-inputrange-repaint-expected.txt 2015-07-18 03:46:22 UTC (rev 186981)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+PASS repaintRects.indexOf('495 8 15 15') is not -1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepaintblockinputrangerepainthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/block-inputrange-repaint.html (0 => 186981)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/block-inputrange-repaint.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/block-inputrange-repaint.html 2015-07-18 03:46:22 UTC (rev 186981)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<head>
+<title>This tests when input=range is block we issue correct repaint rects</title>
+<script>jsTestIsAsync = true;</script>
+<script src="../../resources/js-test-pre.js"></script>
+<style>
+ input[type="range"] {
+ display: block;
+ width: 500px;
+ }
+</style>
+</head>
+<body>
+<input id=moveme type=range>
+<script>
+ window.internals.startTrackingRepaints();
+ document.getElementById("moveme").value = 100;
+ document.body.offsetHeight;
+ if (window.internals) {
+ repaintRects = window.internals.repaintRectsAsText();
+ window.internals.stopTrackingRepaints();
+ shouldNotBe("repaintRects.indexOf('495 8 15 15')", "-1");
+ finishJSTest();
+ }
+</script>
+</body>
+<script src="../../resources/js-test-post.js"></script>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (186980 => 186981)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-07-18 03:16:32 UTC (rev 186980)
+++ trunk/Source/WebCore/ChangeLog 2015-07-18 03:46:22 UTC (rev 186981)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-07-17 Zalan Bujtas <zalan@apple.com>
+
+ (display: block)input range's thumb disappears when moved.
+ https://bugs.webkit.org/show_bug.cgi?id=146896
+ <rdar://problem/21787807>
+
+ Reviewed by Simon Fraser.
+
+ Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
+ issued during the layout will not cover the re-positioned thumb.
+ We need to issue a repaint soon after the thumb is re-positioned.
+
+ Test: fast/repaint/block-inputrange-repaint.html
+
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::RenderSliderContainer::layout):
+
</ins><span class="cx"> 2015-07-17 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Attempt to fix the build.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (186980 => 186981)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2015-07-18 03:16:32 UTC (rev 186980)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2015-07-18 03:46:22 UTC (rev 186981)
</span><span class="lines">@@ -190,6 +190,7 @@
</span><span class="cx"> else
</span><span class="cx"> thumbLocation.setX(thumbLocation.x() - offset);
</span><span class="cx"> thumb->setLocation(thumbLocation);
</span><ins>+ thumb->repaint();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // --------------------------------
</span></span></pre>
</div>
</div>
</body>
</html>