<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186848] branches/jsc-tailcall/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186848">186848</a></dd>
<dt>Author</dt> <dd>basile_clement@apple.com</dd>
<dt>Date</dt> <dd>2015-07-15 10:42:06 -0700 (Wed, 15 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>jsc-tailcall: Only non-constructors functions are candidate for tail calls
https://bugs.webkit.org/show_bug.cgi?id=146967
Reviewed by Saam Barati.
Previously, we were emitting tail calls in any ScopeNode. This is
wrong: we should only be emitting tail calls in FunctionNodes that are
not ES6 constructors.
* bytecompiler/NodesCodegen.cpp:
(JSC::ScopeNode::emitStatementsBytecode):
(JSC::FunctionNode::emitBytecode):
* parser/Nodes.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsctailcallSourceJavaScriptCoreChangeLog">branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesjsctailcallSourceJavaScriptCorebytecompilerNodesCodegencpp">branches/jsc-tailcall/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp</a></li>
<li><a href="#branchesjsctailcallSourceJavaScriptCoreparserNodesh">branches/jsc-tailcall/Source/JavaScriptCore/parser/Nodes.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsctailcallSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog (186847 => 186848)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog 2015-07-15 16:04:47 UTC (rev 186847)
+++ branches/jsc-tailcall/Source/JavaScriptCore/ChangeLog 2015-07-15 17:42:06 UTC (rev 186848)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-07-15 Basile Clement <basile_clement@apple.com>
+
+ jsc-tailcall: Only non-constructors functions are candidate for tail calls
+ https://bugs.webkit.org/show_bug.cgi?id=146967
+
+ Reviewed by Saam Barati.
+
+ Previously, we were emitting tail calls in any ScopeNode. This is
+ wrong: we should only be emitting tail calls in FunctionNodes that are
+ not ES6 constructors.
+
+ * bytecompiler/NodesCodegen.cpp:
+ (JSC::ScopeNode::emitStatementsBytecode):
+ (JSC::FunctionNode::emitBytecode):
+ * parser/Nodes.h:
+
</ins><span class="cx"> 2015-07-14 Basile Clement <basile_clement@apple.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Recognize calls in tail position
</span></span></pre></div>
<a id="branchesjsctailcallSourceJavaScriptCorebytecompilerNodesCodegencpp"></a>
<div class="modfile"><h4>Modified: branches/jsc-tailcall/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp (186847 => 186848)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp 2015-07-15 16:04:47 UTC (rev 186847)
+++ branches/jsc-tailcall/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp 2015-07-15 17:42:06 UTC (rev 186848)
</span><span class="lines">@@ -2980,11 +2980,11 @@
</span><span class="cx">
</span><span class="cx"> // ------------------------------ ScopeNode -----------------------------
</span><span class="cx">
</span><del>-inline void ScopeNode::emitStatementsBytecode(BytecodeGenerator& generator, RegisterID* dst)
</del><ins>+inline void ScopeNode::emitStatementsBytecode(BytecodeGenerator& generator, RegisterID* dst, TailCallMode tailCallMode)
</ins><span class="cx"> {
</span><span class="cx"> if (!m_statements)
</span><span class="cx"> return;
</span><del>- m_statements->emitBytecode(generator, dst, isStrictMode() ? CanHaveTailCalls : NoTailCalls);
</del><ins>+ m_statements->emitBytecode(generator, dst, tailCallMode);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // ------------------------------ ProgramNode -----------------------------
</span><span class="lines">@@ -3038,7 +3038,10 @@
</span><span class="cx">
</span><span class="cx"> generator.emitProfileControlFlow(startStartOffset());
</span><span class="cx"> generator.emitDebugHook(DidEnterCallFrame, startLine(), startStartOffset(), startLineStartOffset());
</span><del>- emitStatementsBytecode(generator, generator.ignoredResult());
</del><ins>+ if (isStrictMode() && generator.constructorKind() == ConstructorKind::None)
+ emitStatementsBytecode(generator, generator.ignoredResult(), CanHaveTailCalls);
+ else
+ emitStatementsBytecode(generator, generator.ignoredResult());
</ins><span class="cx">
</span><span class="cx"> StatementNode* singleStatement = this->singleStatement();
</span><span class="cx"> ReturnNode* returnNode = 0;
</span></span></pre></div>
<a id="branchesjsctailcallSourceJavaScriptCoreparserNodesh"></a>
<div class="modfile"><h4>Modified: branches/jsc-tailcall/Source/JavaScriptCore/parser/Nodes.h (186847 => 186848)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsc-tailcall/Source/JavaScriptCore/parser/Nodes.h 2015-07-15 16:04:47 UTC (rev 186847)
+++ branches/jsc-tailcall/Source/JavaScriptCore/parser/Nodes.h 2015-07-15 17:42:06 UTC (rev 186848)
</span><span class="lines">@@ -1582,7 +1582,7 @@
</span><span class="cx">
</span><span class="cx"> StatementNode* singleStatement() const;
</span><span class="cx">
</span><del>- void emitStatementsBytecode(BytecodeGenerator&, RegisterID* destination);
</del><ins>+ void emitStatementsBytecode(BytecodeGenerator&, RegisterID* destination, TailCallMode = NoTailCalls);
</ins><span class="cx">
</span><span class="cx"> void setClosedVariables(Vector<RefPtr<UniquedStringImpl>>&&) { }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>