<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186634] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186634">186634</a></dd>
<dt>Author</dt> <dd>drousso@apple.com</dd>
<dt>Date</dt> <dd>2015-07-09 14:54:11 -0700 (Thu, 09 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Special Logs to Console that do not have an expression should be styled differently, looks like code
https://bugs.webkit.org/show_bug.cgi?id=143840
Reviewed by Timothy Hatcher.
* UserInterface/Controllers/JavaScriptLogViewController.js:
(WebInspector.WebInspector.JavaScriptLogViewController.appendImmediateExecutionWithResult):
Now applies a class to special logs initiated by the user (log element, log object, etc).
* UserInterface/Views/ConsoleCommandView.js:
(WebInspector.ConsoleCommandView): Added className parameter.
* UserInterface/Views/ConsoleMessageView.css:
(.console-user-command.selected-element-log):
(.console-user-command.special-user-log > .console-message-text):
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
(WebInspector.DOMTreeOutline.prototype._populateContextMenu):
* UserInterface/Views/ObjectPreviewView.js:
(WebInspector.ObjectPreviewView.prototype._contextMenuHandler):
* UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WebInspector.ObjectTreeBaseTreeElement.prototype._logSymbolProperty):
(WebInspector.ObjectTreeBaseTreeElement.prototype._logValue):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersJavaScriptLogViewControllerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsConsoleCommandViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsConsoleMessageViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectPreviewViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeBaseTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (186633 => 186634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2015-07-09 21:03:46 UTC (rev 186633)
+++ trunk/Source/WebInspectorUI/ChangeLog        2015-07-09 21:54:11 UTC (rev 186634)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2015-07-09 Devin Rousso <drousso@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Special Logs to Console that do not have an expression should be styled differently, looks like code
+ https://bugs.webkit.org/show_bug.cgi?id=143840
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/JavaScriptLogViewController.js:
+ (WebInspector.WebInspector.JavaScriptLogViewController.appendImmediateExecutionWithResult):
+ Now applies a class to special logs initiated by the user (log element, log object, etc).
+ * UserInterface/Views/ConsoleCommandView.js:
+ (WebInspector.ConsoleCommandView): Added className parameter.
+ * UserInterface/Views/ConsoleMessageView.css:
+ (.console-user-command.selected-element-log):
+ (.console-user-command.special-user-log > .console-message-text):
+ * UserInterface/Views/DOMTreeOutline.js:
+ (WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
+ (WebInspector.DOMTreeOutline.prototype._populateContextMenu):
+ * UserInterface/Views/ObjectPreviewView.js:
+ (WebInspector.ObjectPreviewView.prototype._contextMenuHandler):
+ * UserInterface/Views/ObjectTreeBaseTreeElement.js:
+ (WebInspector.ObjectTreeBaseTreeElement.prototype._logSymbolProperty):
+ (WebInspector.ObjectTreeBaseTreeElement.prototype._logValue):
+
+2015-07-09 Devin Rousso <drousso@apple.com>
+
</ins><span class="cx"> Web Inspector: Checkbox disappears when unchecking CSS background style
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=146776
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersJavaScriptLogViewControllerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js (186633 => 186634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js        2015-07-09 21:03:46 UTC (rev 186633)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js        2015-07-09 21:54:11 UTC (rev 186634)
</span><span class="lines">@@ -119,11 +119,11 @@
</span><span class="cx"> consoleSession.element.scrollIntoView();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- appendImmediateExecutionWithResult(text, result)
</del><ins>+ appendImmediateExecutionWithResult(text, result, addSpecialUserLogClass)
</ins><span class="cx"> {
</span><span class="cx"> console.assert(result instanceof WebInspector.RemoteObject);
</span><span class="cx">
</span><del>- var commandMessageView = new WebInspector.ConsoleCommandView(text);
</del><ins>+ var commandMessageView = new WebInspector.ConsoleCommandView(text, addSpecialUserLogClass ? "special-user-log" : null);
</ins><span class="cx"> this._appendConsoleMessageView(commandMessageView, true);
</span><span class="cx">
</span><span class="cx"> function saveResultCallback(savedResultIndex)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsConsoleCommandViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js (186633 => 186634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js        2015-07-09 21:03:46 UTC (rev 186633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js        2015-07-09 21:54:11 UTC (rev 186634)
</span><span class="lines">@@ -29,7 +29,7 @@
</span><span class="cx">
</span><span class="cx"> WebInspector.ConsoleCommandView = class ConsoleCommandView extends WebInspector.Object
</span><span class="cx"> {
</span><del>- constructor(commandText)
</del><ins>+ constructor(commandText, className)
</ins><span class="cx"> {
</span><span class="cx"> super();
</span><span class="cx">
</span><span class="lines">@@ -39,6 +39,9 @@
</span><span class="cx"> this._element.classList.add("console-user-command");
</span><span class="cx"> this._element.setAttribute("data-labelprefix", WebInspector.UIString("Input: "));
</span><span class="cx">
</span><ins>+ if (className)
+ this._element.classList.add(className);
+
</ins><span class="cx"> this._formattedCommandElement = this._element.appendChild(document.createElement("span"));
</span><span class="cx"> this._formattedCommandElement.classList.add("console-message-text");
</span><span class="cx"> this._formattedCommandElement.textContent = this._commandText;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsConsoleMessageViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css (186633 => 186634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css        2015-07-09 21:03:46 UTC (rev 186633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css        2015-07-09 21:54:11 UTC (rev 186634)
</span><span class="lines">@@ -29,6 +29,16 @@
</span><span class="cx"> min-height: 21px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.console-user-command.special-user-log > .console-message-text {
+ padding: 1px 6px;
+ border-radius: 3px;
+ border: 1px solid transparent;
+ background-color: rgb(34, 131, 246);
+ color: white;
+ font-size: 10px;
+ -webkit-user-select: none;
+}
+
</ins><span class="cx"> .console-message .repeat-count {
</span><span class="cx"> display: inline-block;
</span><span class="cx"> float: left;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (186633 => 186634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js        2015-07-09 21:03:46 UTC (rev 186633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js        2015-07-09 21:54:11 UTC (rev 186634)
</span><span class="lines">@@ -512,7 +512,7 @@
</span><span class="cx"> if (!remoteObject)
</span><span class="cx"> return;
</span><span class="cx"> var text = WebInspector.UIString("Selected Element");
</span><del>- WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, remoteObject);
</del><ins>+ WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, remoteObject, true);
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectPreviewViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js (186633 => 186634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js        2015-07-09 21:03:46 UTC (rev 186633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js        2015-07-09 21:54:11 UTC (rev 186634)
</span><span class="lines">@@ -263,7 +263,7 @@
</span><span class="cx"> if (!isImpossible)
</span><span class="cx"> WebInspector.quickConsole.prompt.pushHistoryItem(text);
</span><span class="cx">
</span><del>- WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, this._remoteObject);
</del><ins>+ WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, this._remoteObject, isImpossible);
</ins><span class="cx"> }.bind(this));
</span><span class="cx">
</span><span class="cx"> contextMenu.show();
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeBaseTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js (186633 => 186634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js        2015-07-09 21:03:46 UTC (rev 186633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js        2015-07-09 21:54:11 UTC (rev 186634)
</span><span class="lines">@@ -161,7 +161,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> var text = WebInspector.UIString("Selected Symbol");
</span><del>- WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, symbol);
</del><ins>+ WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, symbol, true);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _logValue(value)
</span><span class="lines">@@ -177,7 +177,7 @@
</span><span class="cx"> if (!isImpossible)
</span><span class="cx"> WebInspector.quickConsole.prompt.pushHistoryItem(text);
</span><span class="cx">
</span><del>- WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, resolvedValue);
</del><ins>+ WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, resolvedValue, isImpossible);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _contextMenuHandler(event)
</span></span></pre>
</div>
</div>
</body>
</html>