<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186520] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186520">186520</a></dd>
<dt>Author</dt> <dd>timothy@apple.com</dd>
<dt>Date</dt> <dd>2015-07-08 12:27:46 -0700 (Wed, 08 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/185629">r185629</a>): Web Inspector: Filtering doesn't display any items if folders are used to organize the web page resources
https://bugs.webkit.org/show_bug.cgi?id=146675
Reviewed by Joseph Pecoraro.
* UserInterface/Views/TreeOutline.js:
(WebInspector.TreeElement.prototype.revealed): Added ignoreHidden parameter.
(WebInspector.TreeElement.prototype.traverseNextTreeElement.shouldSkip): Pass true to ignore hidden elements.
(WebInspector.TreeElement.prototype.traverseNextTreeElement): Populate up front like the old traverseNextTreeElement.
This is needed to traverse into lazy populated tree elements. Don't call shouldSkip in the loop.
(WebInspector.TreeElement.prototype.traversePreviousTreeElement.shouldSkip): Pass true to ignore hidden elements.
(WebInspector.TreeElement.prototype.traversePreviousTreeElement): Add some newlines.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (186519 => 186520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-08 18:54:34 UTC (rev 186519)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-08 19:27:46 UTC (rev 186520)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-07-08 Timothy Hatcher <timothy@apple.com>
+
+ REGRESSION (r185629): Web Inspector: Filtering doesn't display any items if folders are used to organize the web page resources
+ https://bugs.webkit.org/show_bug.cgi?id=146675
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WebInspector.TreeElement.prototype.revealed): Added ignoreHidden parameter.
+ (WebInspector.TreeElement.prototype.traverseNextTreeElement.shouldSkip): Pass true to ignore hidden elements.
+ (WebInspector.TreeElement.prototype.traverseNextTreeElement): Populate up front like the old traverseNextTreeElement.
+ This is needed to traverse into lazy populated tree elements. Don't call shouldSkip in the loop.
+ (WebInspector.TreeElement.prototype.traversePreviousTreeElement.shouldSkip): Pass true to ignore hidden elements.
+ (WebInspector.TreeElement.prototype.traversePreviousTreeElement): Add some newlines.
+
</ins><span class="cx"> 2015-07-08 Devin Rousso <drousso@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Pressing delete in the styles sidebar with no text causes text to become misaligned
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (186519 => 186520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-07-08 18:54:34 UTC (rev 186519)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-07-08 19:27:46 UTC (rev 186520)
</span><span class="lines">@@ -944,16 +944,16 @@
</span><span class="cx"> this.onreveal(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- revealed()
</del><ins>+ revealed(ignoreHidden)
</ins><span class="cx"> {
</span><del>- if (this.hidden)
</del><ins>+ if (!ignoreHidden && this.hidden)
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> var currentAncestor = this.parent;
</span><span class="cx"> while (currentAncestor && !currentAncestor.root) {
</span><span class="cx"> if (!currentAncestor.expanded)
</span><span class="cx"> return false;
</span><del>- if (currentAncestor.hidden)
</del><ins>+ if (!ignoreHidden && currentAncestor.hidden)
</ins><span class="cx"> return false;
</span><span class="cx"> currentAncestor = currentAncestor.parent;
</span><span class="cx"> }
</span><span class="lines">@@ -1038,15 +1038,17 @@
</span><span class="cx"> traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate, info)
</span><span class="cx"> {
</span><span class="cx"> function shouldSkip(element) {
</span><del>- return skipUnrevealed && !element.revealed();
</del><ins>+ return skipUnrevealed && !element.revealed(true);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var depthChange = 0;
</span><span class="cx"> var element = this;
</span><ins>+
+ if (!dontPopulate)
+ element.onpopulate();
+
</ins><span class="cx"> do {
</span><del>- if (element.hasChildren && element.expanded && !shouldSkip(element)) {
- if (!dontPopulate)
- element.onpopulate();
</del><ins>+ if (element.hasChildren && element.children[0] && (!skipUnrevealed || element.expanded)) {
</ins><span class="cx"> element = element.children[0];
</span><span class="cx"> depthChange += 1;
</span><span class="cx"> } else {
</span><span class="lines">@@ -1062,19 +1064,22 @@
</span><span class="cx">
</span><span class="cx"> if (info)
</span><span class="cx"> info.depthChange = depthChange;
</span><ins>+
</ins><span class="cx"> return element;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> traversePreviousTreeElement(skipUnrevealed, dontPopulate)
</span><span class="cx"> {
</span><span class="cx"> function shouldSkip(element) {
</span><del>- return skipUnrevealed && !element.revealed();
</del><ins>+ return skipUnrevealed && !element.revealed(true);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var element = this;
</span><ins>+
</ins><span class="cx"> do {
</span><span class="cx"> if (element.previousSibling) {
</span><span class="cx"> element = element.previousSibling;
</span><ins>+
</ins><span class="cx"> while (element && element.hasChildren && element.expanded && !shouldSkip(element)) {
</span><span class="cx"> if (!dontPopulate)
</span><span class="cx"> element.onpopulate();
</span></span></pre>
</div>
</div>
</body>
</html>