<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186545] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186545">186545</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-07-08 17:17:13 -0700 (Wed, 08 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix asynchronous function calls for scroll snap animation tests
https://bugs.webkit.org/show_bug.cgi?id=146753
Patch by Wenson Hsieh <whsieh@berkeley.edu> on 2015-07-08
Reviewed by Brent Fulgham.
Fixes unintended use of setTimeout in several scroll snap tests.
* platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html: Fixed asynchronous Javascript invocations.
* platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html: See above.
* platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html: See above.
* platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html: See above.
* platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html: See above.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapiframehtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatorybordershtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatoryoverflowhtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatorypaddinghtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatoryrotatedhtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (186544 => 186545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-07-09 00:16:03 UTC (rev 186544)
+++ trunk/LayoutTests/ChangeLog 2015-07-09 00:17:13 UTC (rev 186545)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-07-08 Wenson Hsieh <whsieh@berkeley.edu>
+
+ Fix asynchronous function calls for scroll snap animation tests
+ https://bugs.webkit.org/show_bug.cgi?id=146753
+
+ Reviewed by Brent Fulgham.
+
+ Fixes unintended use of setTimeout in several scroll snap tests.
+
+ * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html: Fixed asynchronous Javascript invocations.
+ * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html: See above.
+ * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html: See above.
+ * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html: See above.
+ * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html: See above.
+
</ins><span class="cx"> 2015-07-08 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Now that PingLoaders work in the NetworkProcess, re-enable http/tests/navigation/ping-cookie.html
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapiframehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html (186544 => 186545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html 2015-07-09 00:16:03 UTC (rev 186544)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html 2015-07-09 00:17:13 UTC (rev 186545)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> testPassed("div honored snap points.");
</span><span class="cx">
</span><span class="cx"> if (targetLabel == 'horizontalTarget')
</span><del>- setTimeout(scrollGlideTest('verticalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('verticalTarget') }, 0);
</ins><span class="cx"> else
</span><span class="cx"> finishTest();
</span><span class="cx"> }
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx"> else
</span><span class="cx"> testFailed("div did not honor snap points. Expected " + expectedPosition + ", but got " + actualPosition);
</span><span class="cx">
</span><del>- setTimeout(scrollSnapTest(targetLabel), 0);
</del><ins>+ setTimeout(function() { scrollSnapTest(targetLabel) }, 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function scrollGlideTest(targetLabel)
</span><span class="lines">@@ -158,7 +158,7 @@
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx">
</span><span class="cx"> eventSender.monitorWheelEvents();
</span><del>- setTimeout(scrollGlideTest('horizontalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('horizontalTarget') }, 0);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatorybordershtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html (186544 => 186545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html 2015-07-09 00:16:03 UTC (rev 186544)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html 2015-07-09 00:17:13 UTC (rev 186545)
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> testPassed("div honored snap points.");
</span><span class="cx">
</span><span class="cx"> if (targetLabel == 'horizontalTarget')
</span><del>- setTimeout(scrollGlideTest('verticalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('verticalTarget') }, 0);
</ins><span class="cx"> else
</span><span class="cx"> finishTest();
</span><span class="cx"> }
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx"> else
</span><span class="cx"> testFailed("div did not honor snap points. Expected " + expectedPosition + ", but got " + actualPosition);
</span><span class="cx">
</span><del>- setTimeout(scrollSnapTest(targetLabel), 0);
</del><ins>+ setTimeout(function() { scrollSnapTest(targetLabel) }, 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function scrollGlideTest(targetLabel)
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx">
</span><span class="cx"> eventSender.monitorWheelEvents();
</span><del>- setTimeout(scrollGlideTest('horizontalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('horizontalTarget') }, 0);
</ins><span class="cx"> } else {
</span><span class="cx"> var messageLocationH = document.getElementById('itemH0');
</span><span class="cx"> var message = document.createElement('div');
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatoryoverflowhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html (186544 => 186545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html 2015-07-09 00:16:03 UTC (rev 186544)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html 2015-07-09 00:17:13 UTC (rev 186545)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> testPassed("div honored snap points.");
</span><span class="cx">
</span><span class="cx"> if (targetLabel == 'horizontalTarget')
</span><del>- setTimeout(scrollGlideTest('verticalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('verticalTarget') }, 0);
</ins><span class="cx"> else
</span><span class="cx"> finishTest();
</span><span class="cx"> }
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx"> else
</span><span class="cx"> testFailed("div did not honor snap points. Expected " + expectedPosition + ", but got " + actualPosition);
</span><span class="cx">
</span><del>- setTimeout(scrollSnapTest(targetLabel), 0);
</del><ins>+ setTimeout(function() { scrollSnapTest(targetLabel) }, 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function scrollGlideTest(targetLabel)
</span><span class="lines">@@ -179,7 +179,7 @@
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx">
</span><span class="cx"> eventSender.monitorWheelEvents();
</span><del>- setTimeout(scrollGlideTest('horizontalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('horizontalTarget') }, 0);
</ins><span class="cx"> } else {
</span><span class="cx"> var messageLocationH = document.getElementById('itemH0');
</span><span class="cx"> var message = document.createElement('div');
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatorypaddinghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html (186544 => 186545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html 2015-07-09 00:16:03 UTC (rev 186544)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html 2015-07-09 00:17:13 UTC (rev 186545)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx"> testPassed("div honored snap points.");
</span><span class="cx">
</span><span class="cx"> if (targetLabel == 'horizontalTarget')
</span><del>- setTimeout(scrollGlideTest('verticalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('verticalTarget') }, 0);
</ins><span class="cx"> else
</span><span class="cx"> finishTest();
</span><span class="cx"> }
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx"> else
</span><span class="cx"> testFailed("div did not honor snap points. Expected " + expectedPosition + ", but got " + actualPosition);
</span><span class="cx">
</span><del>- setTimeout(scrollSnapTest(targetLabel), 0);
</del><ins>+ setTimeout(function() { scrollSnapTest(targetLabel) }, 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function scrollGlideTest(targetLabel)
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx">
</span><span class="cx"> eventSender.monitorWheelEvents();
</span><del>- setTimeout(scrollGlideTest('horizontalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('horizontalTarget') }, 0);
</ins><span class="cx"> } else {
</span><span class="cx"> var messageLocationH = document.getElementById('itemH0');
</span><span class="cx"> var message = document.createElement('div');
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingscrollingscrollsnapscrollsnapmandatoryrotatedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html (186544 => 186545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html 2015-07-09 00:16:03 UTC (rev 186544)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html 2015-07-09 00:17:13 UTC (rev 186545)
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> testPassed("div honored snap points.");
</span><span class="cx">
</span><span class="cx"> if (targetLabel == 'horizontalTarget')
</span><del>- setTimeout(scrollGlideTest('verticalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('verticalTarget') }, 0);
</ins><span class="cx"> else
</span><span class="cx"> finishTest();
</span><span class="cx"> }
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> else
</span><span class="cx"> testFailed("div did not honor snap points. Expected " + expectedPosition + ", but got " + actualPosition);
</span><span class="cx">
</span><del>- setTimeout(scrollSnapTest(targetLabel), 0);
</del><ins>+ setTimeout(function() { scrollSnapTest(targetLabel) }, 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function scrollGlideTest(targetLabel)
</span><span class="lines">@@ -181,7 +181,7 @@
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx">
</span><span class="cx"> eventSender.monitorWheelEvents();
</span><del>- setTimeout(scrollGlideTest('horizontalTarget'), 0);
</del><ins>+ setTimeout(function() { scrollGlideTest('horizontalTarget') }, 0);
</ins><span class="cx"> } else {
</span><span class="cx"> var messageLocationH = document.getElementById('itemH0');
</span><span class="cx"> var message = document.createElement('div');
</span></span></pre>
</div>
</div>
</body>
</html>