<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186334] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186334">186334</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-07-06 02:55:36 -0700 (Mon, 06 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/184874">r184874</a> - SVG fragment identifier rendering issue
https://bugs.webkit.org/show_bug.cgi?id=137328
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-05-26
Reviewed by Darin Adler.
Source/WebCore:
This is a follow up for http://trac.webkit.org/changeset/164983. In this
changeset, scrolling to the fragment should have been added before the
the paint to guarantee setting the proper display position for the SVG
fragment.
Test: svg/css/svg-resource-fragment-identifier-order.html
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw): Move view->scrollToFragment() before calling
view->paint().
LayoutTests:
* svg/css/svg-resource-fragment-identifier-order-expected.html: Added.
* svg/css/svg-resource-fragment-identifier-order.html: Added.
Ensure the SVG fragment is drawn correctly when the same SVG image is
referenced multiple times.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoresvggraphicsSVGImagecpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/svg/graphics/SVGImage.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestssvgcsssvgresourcefragmentidentifierorderexpectedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestssvgcsssvgresourcefragmentidentifierorderhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (186333 => 186334)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog        2015-07-06 09:48:38 UTC (rev 186333)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog        2015-07-06 09:55:36 UTC (rev 186334)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-05-26 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ SVG fragment identifier rendering issue
+ https://bugs.webkit.org/show_bug.cgi?id=137328
+
+ Reviewed by Darin Adler.
+
+ * svg/css/svg-resource-fragment-identifier-order-expected.html: Added.
+ * svg/css/svg-resource-fragment-identifier-order.html: Added.
+ Ensure the SVG fragment is drawn correctly when the same SVG image is
+ referenced multiple times.
+
</ins><span class="cx"> 2015-05-21 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> SVG as image uses very tiny default font-size
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestssvgcsssvgresourcefragmentidentifierorderexpectedhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order-expected.html (0 => 186334)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order-expected.html         (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order-expected.html        2015-07-06 09:55:36 UTC (rev 186334)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+<html>
+<head>
+<style>
+ div {
+ width: 100px;
+ height: 100px;
+ display: inline-block;
+ }
+</style>
+</head>
+<body>
+ <div style="background-color: red"></div>
+ <div style="background-color: red"></div>
+ <div style="background-color: green"></div>
+ <div style="background-color: green"></div>
+ <div style="background-color: blue"></div>
+ <div style="background-color: blue"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestssvgcsssvgresourcefragmentidentifierorderhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order.html (0 => 186334)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order.html         (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/svg/css/svg-resource-fragment-identifier-order.html        2015-07-06 09:55:36 UTC (rev 186334)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<html>
+<head>
+<style>
+ img {
+ width: 100px;
+ height: 100px;
+ }
+</style>
+</head>
+<body>
+ <img src="resources/fragment-identifiers.svg#red">
+ <img src="resources/fragment-identifiers.svg#red">
+ <img src="resources/fragment-identifiers.svg#green">
+ <img src="resources/fragment-identifiers.svg#green">
+ <img src="resources/fragment-identifiers.svg#blue">
+ <img src="resources/fragment-identifiers.svg#blue">
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (186333 => 186334)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog        2015-07-06 09:48:38 UTC (rev 186333)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog        2015-07-06 09:55:36 UTC (rev 186334)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-05-26 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ SVG fragment identifier rendering issue
+ https://bugs.webkit.org/show_bug.cgi?id=137328
+
+ Reviewed by Darin Adler.
+
+ This is a follow up for http://trac.webkit.org/changeset/164983. In this
+ changeset, scrolling to the fragment should have been added before the
+ the paint to guarantee setting the proper display position for the SVG
+ fragment.
+
+ Test: svg/css/svg-resource-fragment-identifier-order.html
+
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::draw): Move view->scrollToFragment() before calling
+ view->paint().
+
</ins><span class="cx"> 2015-05-26 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> [ARM] Build SVGPathElement.cpp with -O2 due to a GCC bug
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoresvggraphicsSVGImagecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/svg/graphics/SVGImage.cpp (186333 => 186334)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/svg/graphics/SVGImage.cpp        2015-07-06 09:48:38 UTC (rev 186333)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/svg/graphics/SVGImage.cpp        2015-07-06 09:55:36 UTC (rev 186334)
</span><span class="lines">@@ -249,6 +249,9 @@
</span><span class="cx">
</span><span class="cx"> view->resize(containerSize());
</span><span class="cx">
</span><ins>+ if (!m_url.isEmpty())
+ view->scrollToFragment(m_url);
+
</ins><span class="cx"> if (view->needsLayout())
</span><span class="cx"> view->layout();
</span><span class="cx">
</span><span class="lines">@@ -259,9 +262,6 @@
</span><span class="cx">
</span><span class="cx"> stateSaver.restore();
</span><span class="cx">
</span><del>- if (!m_url.isEmpty())
- view->scrollToFragment(m_url);
-
</del><span class="cx"> if (imageObserver())
</span><span class="cx"> imageObserver()->didDraw(this);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>