<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186255] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186255">186255</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-07-02 20:08:44 -0700 (Thu, 02 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] test_ewk2_application_cache_manager has been failed since <a href="http://trac.webkit.org/projects/webkit/changeset/185527">r185527</a>
https://bugs.webkit.org/show_bug.cgi?id=146016
Patch by Przemek Piorkowski <piorkowskiprzemyslaw@gmail.com> on 2015-07-02
Reviewed by Gyuyoung Kim.
In order to handle properly WebApplicationCacheManagerProxy implementation which use
.:
WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
* Source/cmake/OptionsEfl.cmake: set ENABLE_PUBLIC_SUFFIX_LIST to ON for EFL.
Source/WebCore:
WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
* PlatformEfl.cmake: PublicSuffixSoup.cpp added to source files.
Source/WebKit2:
WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
* UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
(TEST_F): enable ewk_application_cache_manager as it is passing now.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorePlatformEflcmake">trunk/Source/WebCore/PlatformEfl.cmake</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIeflteststest_ewk2_application_cache_managercpp">trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp</a></li>
<li><a href="#trunkSourcecmakeOptionsEflcmake">trunk/Source/cmake/OptionsEfl.cmake</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (186254 => 186255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/ChangeLog 2015-07-03 03:08:44 UTC (rev 186255)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-07-02 Przemek Piorkowski <piorkowskiprzemyslaw@gmail.com>
+
+ [EFL] test_ewk2_application_cache_manager has been failed since r185527
+ https://bugs.webkit.org/show_bug.cgi?id=146016
+
+ Reviewed by Gyuyoung Kim.
+
+ In order to handle properly WebApplicationCacheManagerProxy implementation which use
+ WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
+ Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
+
+ * Source/cmake/OptionsEfl.cmake: set ENABLE_PUBLIC_SUFFIX_LIST to ON for EFL.
+
</ins><span class="cx"> 2015-06-30 Andy VanWagoner <thetalecrafter@gmail.com>
</span><span class="cx">
</span><span class="cx"> Implement ECMAScript Internationalization API
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (186254 => 186255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebCore/ChangeLog 2015-07-03 03:08:44 UTC (rev 186255)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-07-02 Przemek Piorkowski <piorkowskiprzemyslaw@gmail.com>
+
+ [EFL] test_ewk2_application_cache_manager has been failed since r185527
+ https://bugs.webkit.org/show_bug.cgi?id=146016
+
+ Reviewed by Gyuyoung Kim.
+
+ In order to handle properly WebApplicationCacheManagerProxy implementation which use
+ WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
+ Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
+
+ * PlatformEfl.cmake: PublicSuffixSoup.cpp added to source files.
+
</ins><span class="cx"> 2015-07-02 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r186251.
</span></span></pre></div>
<a id="trunkSourceWebCorePlatformEflcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/PlatformEfl.cmake (186254 => 186255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/PlatformEfl.cmake 2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebCore/PlatformEfl.cmake 2015-07-03 03:08:44 UTC (rev 186255)
</span><span class="lines">@@ -248,6 +248,7 @@
</span><span class="cx"> platform/posix/FileSystemPOSIX.cpp
</span><span class="cx"> platform/posix/SharedBufferPOSIX.cpp
</span><span class="cx">
</span><ins>+ platform/soup/PublicSuffixSoup.cpp
</ins><span class="cx"> platform/soup/SharedBufferSoup.cpp
</span><span class="cx"> platform/soup/URLSoup.cpp
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (186254 => 186255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-03 03:08:44 UTC (rev 186255)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-07-02 Przemek Piorkowski <piorkowskiprzemyslaw@gmail.com>
+
+ [EFL] test_ewk2_application_cache_manager has been failed since r185527
+ https://bugs.webkit.org/show_bug.cgi?id=146016
+
+ Reviewed by Gyuyoung Kim.
+
+ In order to handle properly WebApplicationCacheManagerProxy implementation which use
+ WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
+ Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
+
+ * UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
+ (TEST_F): enable ewk_application_cache_manager as it is passing now.
+
</ins><span class="cx"> 2015-07-02 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r186247 and r186250.
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIeflteststest_ewk2_application_cache_managercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp (186254 => 186255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp 2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp 2015-07-03 03:08:44 UTC (rev 186255)
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> return ECORE_CALLBACK_CANCEL;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-TEST_F(EWK2UnitTestBase, DISABLED_ewk_application_cache_manager)
</del><ins>+TEST_F(EWK2UnitTestBase, ewk_application_cache_manager)
</ins><span class="cx"> {
</span><span class="cx"> std::unique_ptr<EWK2UnitTestServer> httpServer = std::make_unique<EWK2UnitTestServer>();
</span><span class="cx"> httpServer->run(serverCallback);
</span></span></pre></div>
<a id="trunkSourcecmakeOptionsEflcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/OptionsEfl.cmake (186254 => 186255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/OptionsEfl.cmake 2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/cmake/OptionsEfl.cmake 2015-07-03 03:08:44 UTC (rev 186255)
</span><span class="lines">@@ -107,6 +107,7 @@
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETWORK_PROCESS PUBLIC ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOSNIFF PUBLIC ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PICTURE_SIZES PUBLIC ON)
</span><ins>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PUBLIC_SUFFIX_LIST PRIVATE ON)
</ins><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOLUTION_MEDIA_QUERY PUBLIC ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REQUEST_ANIMATION_FRAME PUBLIC ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SECCOMP_FILTERS PUBLIC OFF)
</span></span></pre>
</div>
</div>
</body>
</html>