<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186204] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186204">186204</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2015-07-01 17:00:12 -0700 (Wed, 01 Jul 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove code to recompute rounded window corners
https://bugs.webkit.org/show_bug.cgi?id=146534
Reviewed by Simon Fraser.
This code is no longer needed since we're always layer-backed now.
* UIProcess/API/mac/WKView.mm:
(-[WKView displayIfNeeded]): Deleted.
(-[WKView _cacheWindowBottomCornerRect]): Deleted.
* UIProcess/API/mac/WKViewInternal.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewmm">trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewInternalh">trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (186203 => 186204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-07-01 23:36:53 UTC (rev 186203)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 00:00:12 UTC (rev 186204)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-07-01 Anders Carlsson <andersca@apple.com>
+
+ Remove code to recompute rounded window corners
+ https://bugs.webkit.org/show_bug.cgi?id=146534
+
+ Reviewed by Simon Fraser.
+
+ This code is no longer needed since we're always layer-backed now.
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView displayIfNeeded]): Deleted.
+ (-[WKView _cacheWindowBottomCornerRect]): Deleted.
+ * UIProcess/API/mac/WKViewInternal.h:
+
</ins><span class="cx"> 2015-07-01 Yongjun Zhang <yongjun_zhang@apple.com>
</span><span class="cx">
</span><span class="cx"> Web page doesn't update its loading state when web process becomes suspended if there are pending network requests (XHR).
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (186203 => 186204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-07-01 23:36:53 UTC (rev 186203)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-07-02 00:00:12 UTC (rev 186204)
</span><span class="lines">@@ -126,8 +126,6 @@
</span><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @interface NSWindow (WKNSWindowDetails)
</span><del>-- (NSRect)_intersectBottomCornersWithRect:(NSRect)viewRect;
-- (void)_maskRoundedBottomCorners:(NSRect)clipRect;
</del><span class="cx"> - (id)_newFirstResponderAfterResigning;
</span><span class="cx"> @end
</span><span class="cx">
</span><span class="lines">@@ -236,8 +234,6 @@
</span><span class="cx">
</span><span class="cx"> BOOL _inSecureInputState;
</span><span class="cx">
</span><del>- NSRect _windowBottomCornerIntersectionRect;
-
</del><span class="cx"> BOOL _shouldDeferViewInWindowChanges;
</span><span class="cx"> NSWindow *_targetWindowForMovePreparation;
</span><span class="cx">
</span><span class="lines">@@ -1201,25 +1197,6 @@
</span><span class="cx"> _data->_page->capitalizeWord();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)displayIfNeeded
-{
- // FIXME: We should remove this code when <rdar://problem/9362085> is resolved. In the meantime,
- // it is necessary to disable scren updates so we get a chance to redraw the corners before this
- // display is visible.
- NSWindow *window = [self window];
- BOOL shouldMaskWindow = window && !NSIsEmptyRect(_data->_windowBottomCornerIntersectionRect);
- if (shouldMaskWindow)
- NSDisableScreenUpdates();
-
- [super displayIfNeeded];
-
- if (shouldMaskWindow) {
- [window _maskRoundedBottomCorners:_data->_windowBottomCornerIntersectionRect];
- NSEnableScreenUpdates();
- _data->_windowBottomCornerIntersectionRect = NSZeroRect;
- }
-}
-
</del><span class="cx"> // Events
</span><span class="cx">
</span><span class="cx"> // Override this so that AppKit will send us arrow keys as key down events so we can
</span><span class="lines">@@ -3728,18 +3705,6 @@
</span><span class="cx"> [self invalidateIntrinsicContentSize];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)_cacheWindowBottomCornerRect
-{
- // FIXME: We should remove this code when <rdar://problem/9362085> is resolved.
- NSWindow *window = [self window];
- if (!window)
- return;
-
- _data->_windowBottomCornerIntersectionRect = [window _intersectBottomCornersWithRect:[self convertRect:[self visibleRect] toView:nil]];
- if (!NSIsEmptyRect(_data->_windowBottomCornerIntersectionRect))
- [self setNeedsDisplayInRect:[self convertRect:_data->_windowBottomCornerIntersectionRect fromView:nil]];
-}
-
</del><span class="cx"> - (NSInteger)spellCheckerDocumentTag
</span><span class="cx"> {
</span><span class="cx"> if (!_data->_hasSpellCheckerDocumentTag) {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h (186203 => 186204)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2015-07-01 23:36:53 UTC (rev 186203)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2015-07-02 00:00:12 UTC (rev 186204)
</span><span class="lines">@@ -112,8 +112,6 @@
</span><span class="cx">
</span><span class="cx"> - (WebKit::ColorSpaceData)_colorSpace;
</span><span class="cx">
</span><del>-- (void)_cacheWindowBottomCornerRect;
-
</del><span class="cx"> - (NSInteger)spellCheckerDocumentTag;
</span><span class="cx"> - (void)handleAcceptedAlternativeText:(NSString*)text;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>