<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[186107] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/186107">186107</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2015-06-29 22:33:11 -0700 (Mon, 29 Jun 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>[iOS WK2] WKWebViews in Facebook app start off black
https://bugs.webkit.org/show_bug.cgi?id=146445
rdar://problem/21600433

Reviewed by Tim Horton.

If -isOpaque is toggled on a WKWebView, we failed to make the page tiles non-opaque
for a while. After <a href="http://trac.webkit.org/projects/webkit/changeset/183775">r183775</a>, RenderLayerCompositor::rootBackgroundTransparencyChanged() was called,
but only considered the computed document background color, and not the view transparency.

Fix by having rootBackgroundTransparencyChanged() simply use viewHasTransparentBackground(),
which checks the FrameView transparency. Now we just need to store a transparency bool rather
than the old color (we only checked its alpha anyway).

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorcpp">trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorh">trunk/Source/WebCore/rendering/RenderLayerCompositor.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (186106 => 186107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-06-30 02:38:36 UTC (rev 186106)
+++ trunk/Source/WebCore/ChangeLog        2015-06-30 05:33:11 UTC (rev 186107)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-06-29  Simon Fraser  &lt;simon.fraser@apple.com&gt;
+
+        [iOS WK2] WKWebViews in Facebook app start off black
+        https://bugs.webkit.org/show_bug.cgi?id=146445
+        rdar://problem/21600433
+
+        Reviewed by Tim Horton.
+
+        If -isOpaque is toggled on a WKWebView, we failed to make the page tiles non-opaque
+        for a while. After r183775, RenderLayerCompositor::rootBackgroundTransparencyChanged() was called,
+        but only considered the computed document background color, and not the view transparency.
+        
+        Fix by having rootBackgroundTransparencyChanged() simply use viewHasTransparentBackground(),
+        which checks the FrameView transparency. Now we just need to store a transparency bool rather
+        than the old color (we only checked its alpha anyway).
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):
+
</ins><span class="cx"> 2015-06-29  Dean Jackson  &lt;dino@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         WebKit should use 80% black background for PiP indicator
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (186106 => 186107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp        2015-06-30 02:38:36 UTC (rev 186106)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp        2015-06-30 05:33:11 UTC (rev 186107)
</span><span class="lines">@@ -3198,12 +3198,12 @@
</span><span class="cx">     if (!inCompositingMode())
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    Color documentBackgroundColor = m_renderView.frameView().documentBackgroundColor();
-    Color lastDocumentBackgroundColor = m_lastDocumentBackgroundColor;
-    m_lastDocumentBackgroundColor = documentBackgroundColor;
-    if (lastDocumentBackgroundColor.isValid() &amp;&amp; lastDocumentBackgroundColor.hasAlpha() == documentBackgroundColor.hasAlpha())
</del><ins>+    bool isTransparent = viewHasTransparentBackground();
+    if (m_viewBackgroundIsTransparent == isTransparent)
</ins><span class="cx">         return;
</span><span class="cx"> 
</span><ins>+    m_viewBackgroundIsTransparent = isTransparent;
+
</ins><span class="cx">     // FIXME: We should do something less expensive than a full layer rebuild.
</span><span class="cx">     setCompositingLayersNeedRebuild();
</span><span class="cx">     scheduleCompositingLayerUpdate();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.h (186106 => 186107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.h        2015-06-30 02:38:36 UTC (rev 186106)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.h        2015-06-30 05:33:11 UTC (rev 186107)
</span><span class="lines">@@ -545,6 +545,7 @@
</span><span class="cx">     bool m_layerFlushThrottlingTemporarilyDisabledForInteraction;
</span><span class="cx">     bool m_hasPendingLayerFlush;
</span><span class="cx">     bool m_layerNeedsCompositingUpdate { false };
</span><ins>+    bool m_viewBackgroundIsTransparent { false };
</ins><span class="cx"> 
</span><span class="cx">     Timer m_paintRelatedMilestonesTimer;
</span><span class="cx"> 
</span><span class="lines">@@ -557,7 +558,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">     Color m_rootExtendedBackgroundColor;
</span><del>-    Color m_lastDocumentBackgroundColor;
</del><span class="cx"> 
</span><span class="cx">     HashMap&lt;ScrollingNodeID, RenderLayer*&gt; m_scrollingNodeToLayerMap;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>

</body>
</html>