<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185933] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185933">185933</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2015-06-24 16:44:33 -0700 (Wed, 24 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: console.group looks poor in console
https://bugs.webkit.org/show_bug.cgi?id=146295
Reviewed by Timothy Hatcher.
* Localizations/en.lproj/localizedStrings.js:
String for the default group name if you use console.group() without a name parameter.
* UserInterface/Views/LogContentView.css:
(.console-group-title::before):
Tweak the positioning and eliminate the log level ::before image.
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView):
Reorder a bit to reduce a couple branches.
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
Take a very straightforward approach for group names.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsConsoleMessageViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (185932 => 185933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-24 22:50:44 UTC (rev 185932)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-24 23:44:33 UTC (rev 185933)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2015-06-24 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: console.group looks poor in console
+ https://bugs.webkit.org/show_bug.cgi?id=146295
+
+ Reviewed by Timothy Hatcher.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ String for the default group name if you use console.group() without a name parameter.
+
+ * UserInterface/Views/LogContentView.css:
+ (.console-group-title::before):
+ Tweak the positioning and eliminate the log level ::before image.
+
+ * UserInterface/Views/ConsoleMessageView.js:
+ (WebInspector.ConsoleMessageView):
+ Reorder a bit to reduce a couple branches.
+
+ (WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
+ Take a very straightforward approach for group names.
+
</ins><span class="cx"> 2015-06-24 Devin Rousso <drousso@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Show warning icon for invalid CSS properties and/or values
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (185932 => 185933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-06-24 22:50:44 UTC (rev 185932)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-06-24 23:44:33 UTC (rev 185933)
</span><span class="lines">@@ -250,6 +250,7 @@
</span><span class="cx"> localizedStrings["Global Breakpoints"] = "Global Breakpoints";
</span><span class="cx"> localizedStrings["Global Variables"] = "Global Variables";
</span><span class="cx"> localizedStrings["Grammar"] = "Grammar";
</span><ins>+localizedStrings["Group"] = "Group";
</ins><span class="cx"> localizedStrings["HTML Attributes"] = "HTML Attributes";
</span><span class="cx"> localizedStrings["HTTP"] = "HTTP";
</span><span class="cx"> localizedStrings["Height"] = "Height";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsConsoleMessageViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (185932 => 185933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-06-24 22:50:44 UTC (rev 185932)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-06-24 23:44:33 UTC (rev 185933)
</span><span class="lines">@@ -47,6 +47,12 @@
</span><span class="cx"> this._element.__message = this._message;
</span><span class="cx"> this._element.__messageView = this;
</span><span class="cx">
</span><ins>+ if (this._message.type === WebInspector.ConsoleMessage.MessageType.Result) {
+ this._element.classList.add("console-user-command-result");
+ this._element.setAttribute("data-labelprefix", WebInspector.UIString("Output: "));
+ } else if (this._message.type === WebInspector.ConsoleMessage.MessageType.StartGroup || this._message.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed)
+ this._element.classList.add("console-group-title");
+
</ins><span class="cx"> switch (this._message.level) {
</span><span class="cx"> case WebInspector.ConsoleMessage.MessageLevel.Log:
</span><span class="cx"> this._element.classList.add("console-log-level");
</span><span class="lines">@@ -70,15 +76,6 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (this._message.type === WebInspector.ConsoleMessage.MessageType.Result) {
- this._element.classList.add("console-user-command-result");
- if (!this._element.getAttribute("data-labelprefix"))
- this._element.setAttribute("data-labelprefix", WebInspector.UIString("Output: "));
- }
-
- if (this._message.type === WebInspector.ConsoleMessage.MessageType.StartGroup || this._message.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed)
- this._element.classList.add("console-group-title");
-
</del><span class="cx"> // These are the parameters unused by the messages's optional format string.
</span><span class="cx"> // Any extra parameters will be displayed as children of this message.
</span><span class="cx"> this._extraParameters = this._message.parameters;
</span><span class="lines">@@ -252,6 +249,13 @@
</span><span class="cx"> this._extraParameters = null;
</span><span class="cx"> break;
</span><span class="cx">
</span><ins>+ case WebInspector.ConsoleMessage.MessageType.StartGroup:
+ case WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed:
+ var groupName = this._message.messageText || WebInspector.UIString("Group");
+ element.appendChild(document.createTextNode(groupName));
+ this._extraParameters = null;
+ break;
+
</ins><span class="cx"> default:
</span><span class="cx"> var args = this._message.parameters || [this._message.messageText];
</span><span class="cx"> this._appendFormattedArguments(element, args);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (185932 => 185933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-06-24 22:50:44 UTC (rev 185932)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-06-24 23:44:33 UTC (rev 185933)
</span><span class="lines">@@ -107,12 +107,13 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .console-group-title::before {
</span><ins>+ content: "";
</ins><span class="cx"> background-image: -webkit-canvas(disclosure-triangle-small-open-normal);
</span><span class="cx"> background-size: 13px 13px;
</span><del>- top: 6px;
</del><ins>+ top: 4px;
+ left: 4px;
</ins><span class="cx"> width: 13px;
</span><span class="cx"> height: 13px;
</span><del>- left: 3px;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .console-group.collapsed .console-group-title::before {
</span></span></pre>
</div>
</div>
</body>
</html>