<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185847] trunk/Source/WTF</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185847">185847</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2015-06-22 15:07:20 -0700 (Mon, 22 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get rid of the Windows specific BinarySemaphore implementation
https://bugs.webkit.org/show_bug.cgi?id=146216
Reviewed by Andreas Kling.
The fact that the Windows implementation uses a HEVENT internally was only useful
to the Windows port of WebKit2; we can get rid of it now.
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* wtf/threads/BinarySemaphore.h:
(WTF::BinarySemaphore::event): Deleted.
* wtf/threads/win/BinarySemaphoreWin.cpp: Removed.
(WTF::BinarySemaphore::BinarySemaphore): Deleted.
(WTF::BinarySemaphore::~BinarySemaphore): Deleted.
(WTF::BinarySemaphore::signal): Deleted.
(WTF::BinarySemaphore::wait): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFWTFvcxprojWTFvcxproj">trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj</a></li>
<li><a href="#trunkSourceWTFWTFvcxprojWTFvcxprojfilters">trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters</a></li>
<li><a href="#trunkSourceWTFwtfthreadsBinarySemaphoreh">trunk/Source/WTF/wtf/threads/BinarySemaphore.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li>trunk/Source/WTF/wtf/threads/win/</li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (185846 => 185847)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/ChangeLog 2015-06-22 22:07:20 UTC (rev 185847)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-06-22 Anders Carlsson <andersca@apple.com>
+
+ Get rid of the Windows specific BinarySemaphore implementation
+ https://bugs.webkit.org/show_bug.cgi?id=146216
+
+ Reviewed by Andreas Kling.
+
+ The fact that the Windows implementation uses a HEVENT internally was only useful
+ to the Windows port of WebKit2; we can get rid of it now.
+
+ * WTF.vcxproj/WTF.vcxproj:
+ * WTF.vcxproj/WTF.vcxproj.filters:
+ * wtf/threads/BinarySemaphore.h:
+ (WTF::BinarySemaphore::event): Deleted.
+ * wtf/threads/win/BinarySemaphoreWin.cpp: Removed.
+ (WTF::BinarySemaphore::BinarySemaphore): Deleted.
+ (WTF::BinarySemaphore::~BinarySemaphore): Deleted.
+ (WTF::BinarySemaphore::signal): Deleted.
+ (WTF::BinarySemaphore::wait): Deleted.
+
</ins><span class="cx"> 2015-06-21 Gavin Barraclough <barraclough@apple.com>
</span><span class="cx">
</span><span class="cx"> Page load performance regression due to bugs.webkit.org/show_bug.cgi?id=145542
</span></span></pre></div>
<a id="trunkSourceWTFWTFvcxprojWTFvcxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj (185846 => 185847)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2015-06-22 22:07:20 UTC (rev 185847)
</span><span class="lines">@@ -145,7 +145,6 @@
</span><span class="cx"> <ClCompile Include="..\wtf\ThreadingWin.cpp" />
</span><span class="cx"> <ClCompile Include="..\wtf\threadspecificWin.cpp" />
</span><span class="cx"> <ClCompile Include="..\wtf\threads\BinarySemaphore.cpp" />
</span><del>- <ClCompile Include="..\wtf\threads\win\BinarySemaphoreWin.cpp" />
</del><span class="cx"> <ClCompile Include="..\wtf\unicode\icu\CollatorICU.cpp" />
</span><span class="cx"> <ClCompile Include="..\wtf\unicode\UTF8.cpp" />
</span><span class="cx"> <ClCompile Include="..\wtf\win\MainThreadWin.cpp" />
</span></span></pre></div>
<a id="trunkSourceWTFWTFvcxprojWTFvcxprojfilters"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters (185846 => 185847)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters 2015-06-22 22:07:20 UTC (rev 185847)
</span><span class="lines">@@ -102,9 +102,6 @@
</span><span class="cx"> <ClCompile Include="..\wtf\win\MainThreadWin.cpp">
</span><span class="cx"> <Filter>wtf\win</Filter>
</span><span class="cx"> </ClCompile>
</span><del>- <ClCompile Include="..\wtf\threads\win\BinarySemaphoreWin.cpp">
- <Filter>threads\win</Filter>
- </ClCompile>
</del><span class="cx"> <ClCompile Include="..\wtf\threads\BinarySemaphore.cpp">
</span><span class="cx"> <Filter>threads</Filter>
</span><span class="cx"> </ClCompile>
</span></span></pre></div>
<a id="trunkSourceWTFwtfthreadsBinarySemaphoreh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/threads/BinarySemaphore.h (185846 => 185847)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/threads/BinarySemaphore.h 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/wtf/threads/BinarySemaphore.h 2015-06-22 22:07:20 UTC (rev 185847)
</span><span class="lines">@@ -41,19 +41,11 @@
</span><span class="cx"> WTF_EXPORT_PRIVATE void signal();
</span><span class="cx"> WTF_EXPORT_PRIVATE bool wait(double absoluteTime);
</span><span class="cx">
</span><del>-#if PLATFORM(WIN)
- HANDLE event() const { return m_event; }
-#endif
-
</del><span class="cx"> private:
</span><del>-#if PLATFORM(WIN)
- HANDLE m_event;
-#else
</del><span class="cx"> bool m_isSet;
</span><span class="cx">
</span><span class="cx"> Mutex m_mutex;
</span><span class="cx"> ThreadCondition m_condition;
</span><del>-#endif
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WTF
</span></span></pre>
</div>
</div>
</body>
</html>