<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185813] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185813">185813</a></dd>
<dt>Author</dt> <dd>aestes@apple.com</dd>
<dt>Date</dt> <dd>2015-06-21 14:14:51 -0700 (Sun, 21 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Give Node::didNotifySubtreeInsertions() a better name
https://bugs.webkit.org/show_bug.cgi?id=146170
Reviewed by Darin Adler.
didNotifySubtreeInsertions() is not a good name. It sounds like we are notifying the subtree insertions, which doesn't make sense.
This function is really about notifying the Node that the subtree it's a part of has finished being inserted into the DOM
(i.e. all nodes have received their call to insertedInto()). Change the name to finishedInsertingSubtree() to better reflect this.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::notifyChildInserted):
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
* dom/Element.cpp:
(WebCore::Element::addShadowRoot):
* dom/Node.h:
(WebCore::Node::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::Node::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::ScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* dom/ScriptElement.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore::HTMLFrameElementBase::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* html/HTMLFrameElementBase.h:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
(WebCore::HTMLScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::HTMLScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* html/HTMLScriptElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGFEImageElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* svg/SVGFEImageElement.h:
* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::insertedInto):
(WebCore::SVGMPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGMPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* svg/SVGMPathElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
(WebCore::SVGScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* svg/SVGScriptElement.h:
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGTRefElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* svg/SVGTRefElement.h:
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
(WebCore::SVGTextPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGTextPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* svg/SVGTextPathElement.h:
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGSMILElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
* svg/animation/SVGSMILElement.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodecpp">trunk/Source/WebCore/dom/ContainerNode.cpp</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodeAlgorithmsh">trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodeh">trunk/Source/WebCore/dom/Node.h</a></li>
<li><a href="#trunkSourceWebCoredomScriptElementcpp">trunk/Source/WebCore/dom/ScriptElement.cpp</a></li>
<li><a href="#trunkSourceWebCoredomScriptElementh">trunk/Source/WebCore/dom/ScriptElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFrameElementBasecpp">trunk/Source/WebCore/html/HTMLFrameElementBase.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFrameElementBaseh">trunk/Source/WebCore/html/HTMLFrameElementBase.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLScriptElementcpp">trunk/Source/WebCore/html/HTMLScriptElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLScriptElementh">trunk/Source/WebCore/html/HTMLScriptElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFEImageElementcpp">trunk/Source/WebCore/svg/SVGFEImageElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFEImageElementh">trunk/Source/WebCore/svg/SVGFEImageElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGMPathElementcpp">trunk/Source/WebCore/svg/SVGMPathElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGMPathElementh">trunk/Source/WebCore/svg/SVGMPathElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGScriptElementcpp">trunk/Source/WebCore/svg/SVGScriptElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGScriptElementh">trunk/Source/WebCore/svg/SVGScriptElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTRefElementcpp">trunk/Source/WebCore/svg/SVGTRefElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTRefElementh">trunk/Source/WebCore/svg/SVGTRefElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTextPathElementcpp">trunk/Source/WebCore/svg/SVGTextPathElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTextPathElementh">trunk/Source/WebCore/svg/SVGTextPathElement.h</a></li>
<li><a href="#trunkSourceWebCoresvganimationSVGSMILElementcpp">trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvganimationSVGSMILElementh">trunk/Source/WebCore/svg/animation/SVGSMILElement.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/ChangeLog 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -1,3 +1,70 @@
</span><ins>+2015-06-19 Andy Estes <aestes@apple.com>
+
+ Give Node::didNotifySubtreeInsertions() a better name
+ https://bugs.webkit.org/show_bug.cgi?id=146170
+
+ Reviewed by Darin Adler.
+
+ didNotifySubtreeInsertions() is not a good name. It sounds like we are notifying the subtree insertions, which doesn't make sense.
+
+ This function is really about notifying the Node that the subtree it's a part of has finished being inserted into the DOM
+ (i.e. all nodes have received their call to insertedInto()). Change the name to finishedInsertingSubtree() to better reflect this.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::notifyChildInserted):
+ * dom/ContainerNodeAlgorithms.h:
+ (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
+ (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
+ * dom/Element.cpp:
+ (WebCore::Element::addShadowRoot):
+ * dom/Node.h:
+ (WebCore::Node::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::Node::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::ScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * dom/ScriptElement.h:
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::insertedInto):
+ (WebCore::HTMLFrameElementBase::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * html/HTMLFrameElementBase.h:
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::insertedInto):
+ (WebCore::HTMLScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::HTMLScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * html/HTMLScriptElement.h:
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::insertedInto):
+ (WebCore::SVGFEImageElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::SVGFEImageElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * svg/SVGFEImageElement.h:
+ * svg/SVGMPathElement.cpp:
+ (WebCore::SVGMPathElement::insertedInto):
+ (WebCore::SVGMPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::SVGMPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * svg/SVGMPathElement.h:
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::insertedInto):
+ (WebCore::SVGScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::SVGScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * svg/SVGScriptElement.h:
+ * svg/SVGTRefElement.cpp:
+ (WebCore::SVGTRefElement::insertedInto):
+ (WebCore::SVGTRefElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::SVGTRefElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * svg/SVGTRefElement.h:
+ * svg/SVGTextPathElement.cpp:
+ (WebCore::SVGTextPathElement::insertedInto):
+ (WebCore::SVGTextPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::SVGTextPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * svg/SVGTextPathElement.h:
+ * svg/animation/SVGSMILElement.cpp:
+ (WebCore::SVGSMILElement::insertedInto):
+ (WebCore::SVGSMILElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
+ (WebCore::SVGSMILElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
+ * svg/animation/SVGSMILElement.h:
+
</ins><span class="cx"> 2015-06-21 Philip Chimento <philip.chimento@gmail.com>
</span><span class="cx">
</span><span class="cx"> libwebkit2gtk fails to link without opengl
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -347,7 +347,7 @@
</span><span class="cx"> childrenChanged(change);
</span><span class="cx">
</span><span class="cx"> for (auto& target : postInsertionNotificationTargets)
</span><del>- target->didNotifySubtreeInsertions();
</del><ins>+ target->finishedInsertingSubtree();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ContainerNode::notifyChildRemoved(Node& child, Node* previousSibling, Node* nextSibling, ChildChangeSource source)
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodeAlgorithmsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -195,7 +195,7 @@
</span><span class="cx"> inline void ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument(Node& node, NodeVector& postInsertionNotificationTargets)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_insertionPoint.inDocument());
</span><del>- if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node.insertedInto(m_insertionPoint))
</del><ins>+ if (Node::InsertionShouldCallFinishedInsertingSubtree == node.insertedInto(m_insertionPoint))
</ins><span class="cx"> postInsertionNotificationTargets.append(node);
</span><span class="cx"> if (is<ContainerNode>(node))
</span><span class="cx"> notifyDescendantInsertedIntoDocument(downcast<ContainerNode>(node), postInsertionNotificationTargets);
</span><span class="lines">@@ -206,7 +206,7 @@
</span><span class="cx"> NoEventDispatchAssertion assertNoEventDispatch;
</span><span class="cx"> ASSERT(!m_insertionPoint.inDocument());
</span><span class="cx">
</span><del>- if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node.insertedInto(m_insertionPoint))
</del><ins>+ if (Node::InsertionShouldCallFinishedInsertingSubtree == node.insertedInto(m_insertionPoint))
</ins><span class="cx"> postInsertionNotificationTargets.append(node);
</span><span class="cx"> notifyDescendantInsertedIntoTree(node, postInsertionNotificationTargets);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/dom/Element.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -1636,7 +1636,7 @@
</span><span class="cx"> ChildNodeInsertionNotifier(*this).notify(shadowRoot, postInsertionNotificationTargets);
</span><span class="cx">
</span><span class="cx"> for (auto& target : postInsertionNotificationTargets)
</span><del>- target->didNotifySubtreeInsertions();
</del><ins>+ target->finishedInsertingSubtree();
</ins><span class="cx">
</span><span class="cx"> resetNeedsNodeRenderingTraversalSlowPath();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/dom/Node.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -468,17 +468,17 @@
</span><span class="cx"> // Implementation can determine the type of subtree by seeing insertionPoint->inDocument().
</span><span class="cx"> // For a performance reason, notifications are delivered only to ContainerNode subclasses if the insertionPoint is out of document.
</span><span class="cx"> //
</span><del>- // There are another callback named didNotifyDescendantInsertions(), which is called after all the descendant is notified.
- // Only a few subclasses actually need this. To utilize this, the node should return InsertionShouldCallDidNotifyDescendantInsertions
</del><ins>+ // There is another callback named finishedInsertingSubtree(), which is called after all descendants are notified.
+ // Only a few subclasses actually need this. To utilize this, the node should return InsertionShouldCallFinishedInsertingSubtree
</ins><span class="cx"> // from insrtedInto().
</span><span class="cx"> //
</span><span class="cx"> enum InsertionNotificationRequest {
</span><span class="cx"> InsertionDone,
</span><del>- InsertionShouldCallDidNotifySubtreeInsertions
</del><ins>+ InsertionShouldCallFinishedInsertingSubtree
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> virtual InsertionNotificationRequest insertedInto(ContainerNode& insertionPoint);
</span><del>- virtual void didNotifySubtreeInsertions() { }
</del><ins>+ virtual void finishedInsertingSubtree() { }
</ins><span class="cx">
</span><span class="cx"> // Notifies the node that it is no longer part of the tree.
</span><span class="cx"> //
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/dom/ScriptElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -79,12 +79,12 @@
</span><span class="cx"> stopLoadRequest();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool ScriptElement::shouldNotifySubtreeInsertions(ContainerNode& insertionPoint)
</del><ins>+bool ScriptElement::shouldCallFinishedInsertingSubtree(ContainerNode& insertionPoint)
</ins><span class="cx"> {
</span><span class="cx"> return insertionPoint.inDocument() && !m_parserInserted;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ScriptElement::didNotifySubtreeInsertions()
</del><ins>+void ScriptElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!m_parserInserted);
</span><span class="cx"> prepareScript(); // FIXME: Provide a real starting line number here.
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/dom/ScriptElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -69,8 +69,8 @@
</span><span class="cx"> bool forceAsync() const { return m_forceAsync; }
</span><span class="cx">
</span><span class="cx"> // Helper functions used by our parent classes.
</span><del>- bool shouldNotifySubtreeInsertions(ContainerNode&);
- void didNotifySubtreeInsertions();
</del><ins>+ bool shouldCallFinishedInsertingSubtree(ContainerNode&);
+ void finishedInsertingSubtree();
</ins><span class="cx"> void childrenChanged();
</span><span class="cx"> void handleSourceAttribute(const String& sourceUrl);
</span><span class="cx"> void handleAsyncAttribute();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFrameElementBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -133,11 +133,11 @@
</span><span class="cx"> {
</span><span class="cx"> HTMLFrameOwnerElement::insertedInto(insertionPoint);
</span><span class="cx"> if (insertionPoint.inDocument())
</span><del>- return InsertionShouldCallDidNotifySubtreeInsertions;
</del><ins>+ return InsertionShouldCallFinishedInsertingSubtree;
</ins><span class="cx"> return InsertionDone;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLFrameElementBase::didNotifySubtreeInsertions()
</del><ins>+void HTMLFrameElementBase::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><span class="cx"> if (!inDocument())
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFrameElementBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFrameElementBase.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
</span><span class="cx"> virtual InsertionNotificationRequest insertedInto(ContainerNode&) override final;
</span><del>- virtual void didNotifySubtreeInsertions() override final;
</del><ins>+ virtual void finishedInsertingSubtree() override final;
</ins><span class="cx"> virtual void didAttachRenderers() override;
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLScriptElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLScriptElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLScriptElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/html/HTMLScriptElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -70,12 +70,12 @@
</span><span class="cx"> Node::InsertionNotificationRequest HTMLScriptElement::insertedInto(ContainerNode& insertionPoint)
</span><span class="cx"> {
</span><span class="cx"> HTMLElement::insertedInto(insertionPoint);
</span><del>- return shouldNotifySubtreeInsertions(insertionPoint) ? InsertionShouldCallDidNotifySubtreeInsertions : InsertionDone;
</del><ins>+ return shouldCallFinishedInsertingSubtree(insertionPoint) ? InsertionShouldCallFinishedInsertingSubtree : InsertionDone;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLScriptElement::didNotifySubtreeInsertions()
</del><ins>+void HTMLScriptElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><del>- ScriptElement::didNotifySubtreeInsertions();
</del><ins>+ ScriptElement::finishedInsertingSubtree();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLScriptElement::setText(const String &value)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLScriptElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLScriptElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLScriptElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/html/HTMLScriptElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
</span><span class="cx"> virtual InsertionNotificationRequest insertedInto(ContainerNode&) override;
</span><del>- virtual void didNotifySubtreeInsertions() override;
</del><ins>+ virtual void finishedInsertingSubtree() override;
</ins><span class="cx"> virtual void childrenChanged(const ChildChange&) override;
</span><span class="cx">
</span><span class="cx"> virtual bool isURLAttribute(const Attribute&) const override;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFEImageElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFEImageElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFEImageElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGFEImageElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -143,10 +143,10 @@
</span><span class="cx"> Node::InsertionNotificationRequest SVGFEImageElement::insertedInto(ContainerNode& rootParent)
</span><span class="cx"> {
</span><span class="cx"> SVGFilterPrimitiveStandardAttributes::insertedInto(rootParent);
</span><del>- return InsertionShouldCallDidNotifySubtreeInsertions;
</del><ins>+ return InsertionShouldCallFinishedInsertingSubtree;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGFEImageElement::didNotifySubtreeInsertions()
</del><ins>+void SVGFEImageElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><span class="cx"> buildPendingResource();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFEImageElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFEImageElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFEImageElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGFEImageElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> private:
</span><span class="cx"> SVGFEImageElement(const QualifiedName&, Document&);
</span><span class="cx">
</span><del>- virtual void didNotifySubtreeInsertions() override;
</del><ins>+ virtual void finishedInsertingSubtree() override;
</ins><span class="cx">
</span><span class="cx"> virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
</span><span class="cx"> virtual void svgAttributeChanged(const QualifiedName&) override;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGMPathElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGMPathElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGMPathElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGMPathElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -90,11 +90,11 @@
</span><span class="cx"> {
</span><span class="cx"> SVGElement::insertedInto(rootParent);
</span><span class="cx"> if (rootParent.inDocument())
</span><del>- return InsertionShouldCallDidNotifySubtreeInsertions;
</del><ins>+ return InsertionShouldCallFinishedInsertingSubtree;
</ins><span class="cx"> return InsertionDone;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGMPathElement::didNotifySubtreeInsertions()
</del><ins>+void SVGMPathElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><span class="cx"> buildPendingResource();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGMPathElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGMPathElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGMPathElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGMPathElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> virtual void svgAttributeChanged(const QualifiedName&) override;
</span><span class="cx">
</span><span class="cx"> virtual bool rendererIsNeeded(const RenderStyle&) override { return false; }
</span><del>- virtual void didNotifySubtreeInsertions() override;
</del><ins>+ virtual void finishedInsertingSubtree() override;
</ins><span class="cx">
</span><span class="cx"> void notifyParentOfPathChange(ContainerNode*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGScriptElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGScriptElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGScriptElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGScriptElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -79,12 +79,12 @@
</span><span class="cx"> SVGElement::insertedInto(rootParent);
</span><span class="cx"> if (rootParent.inDocument())
</span><span class="cx"> SVGExternalResourcesRequired::insertedIntoDocument(this);
</span><del>- return shouldNotifySubtreeInsertions(rootParent) ? InsertionShouldCallDidNotifySubtreeInsertions : InsertionDone;
</del><ins>+ return shouldCallFinishedInsertingSubtree(rootParent) ? InsertionShouldCallFinishedInsertingSubtree : InsertionDone;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGScriptElement::didNotifySubtreeInsertions()
</del><ins>+void SVGScriptElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><del>- ScriptElement::didNotifySubtreeInsertions();
</del><ins>+ ScriptElement::finishedInsertingSubtree();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SVGScriptElement::childrenChanged(const ChildChange& change)
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGScriptElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGScriptElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGScriptElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGScriptElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
</span><span class="cx"> virtual InsertionNotificationRequest insertedInto(ContainerNode&) override;
</span><del>- virtual void didNotifySubtreeInsertions() override;
</del><ins>+ virtual void finishedInsertingSubtree() override;
</ins><span class="cx"> virtual void childrenChanged(const ChildChange&) override;
</span><span class="cx">
</span><span class="cx"> virtual void svgAttributeChanged(const QualifiedName&) override;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTRefElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTRefElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTRefElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGTRefElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -258,11 +258,11 @@
</span><span class="cx"> {
</span><span class="cx"> SVGElement::insertedInto(rootParent);
</span><span class="cx"> if (rootParent.inDocument())
</span><del>- return InsertionShouldCallDidNotifySubtreeInsertions;
</del><ins>+ return InsertionShouldCallFinishedInsertingSubtree;
</ins><span class="cx"> return InsertionDone;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGTRefElement::didNotifySubtreeInsertions()
</del><ins>+void SVGTRefElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><span class="cx"> buildPendingResource();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTRefElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTRefElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTRefElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGTRefElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx">
</span><span class="cx"> virtual InsertionNotificationRequest insertedInto(ContainerNode&) override;
</span><span class="cx"> virtual void removedFrom(ContainerNode&) override;
</span><del>- virtual void didNotifySubtreeInsertions() override;
</del><ins>+ virtual void finishedInsertingSubtree() override;
</ins><span class="cx">
</span><span class="cx"> virtual void clearTarget() override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTextPathElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTextPathElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTextPathElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGTextPathElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -176,10 +176,10 @@
</span><span class="cx"> Node::InsertionNotificationRequest SVGTextPathElement::insertedInto(ContainerNode& rootParent)
</span><span class="cx"> {
</span><span class="cx"> SVGTextContentElement::insertedInto(rootParent);
</span><del>- return InsertionShouldCallDidNotifySubtreeInsertions;
</del><ins>+ return InsertionShouldCallFinishedInsertingSubtree;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGTextPathElement::didNotifySubtreeInsertions()
</del><ins>+void SVGTextPathElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><span class="cx"> buildPendingResource();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTextPathElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTextPathElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTextPathElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/SVGTextPathElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx"> static Ref<SVGTextPathElement> create(const QualifiedName&, Document&);
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void didNotifySubtreeInsertions() override;
</del><ins>+ virtual void finishedInsertingSubtree() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> SVGTextPathElement(const QualifiedName&, Document&);
</span></span></pre></div>
<a id="trunkSourceWebCoresvganimationSVGSMILElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -260,10 +260,10 @@
</span><span class="cx"> if (m_timeContainer)
</span><span class="cx"> m_timeContainer->notifyIntervalsChanged();
</span><span class="cx">
</span><del>- return InsertionShouldCallDidNotifySubtreeInsertions;
</del><ins>+ return InsertionShouldCallFinishedInsertingSubtree;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGSMILElement::didNotifySubtreeInsertions()
</del><ins>+void SVGSMILElement::finishedInsertingSubtree()
</ins><span class="cx"> {
</span><span class="cx"> buildPendingResource();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvganimationSVGSMILElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.h (185812 => 185813)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/animation/SVGSMILElement.h 2015-06-21 16:44:41 UTC (rev 185812)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.h 2015-06-21 21:14:51 UTC (rev 185813)
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx"> virtual void setTargetElement(SVGElement*);
</span><span class="cx"> virtual void setAttributeName(const QualifiedName&);
</span><span class="cx">
</span><del>- virtual void didNotifySubtreeInsertions() override;
</del><ins>+ virtual void finishedInsertingSubtree() override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void buildPendingResource() override;
</span></span></pre>
</div>
</div>
</body>
</html>