<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185697] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185697">185697</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-06-18 01:58:18 -0700 (Thu, 18 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Streams API] Implement ReadableStreamReader.releaseLock
https://bugs.webkit.org/show_bug.cgi?id=145299
Reviewed by Darin Adler.
Source/WebCore:
Covered by rebased tests.
* Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::close): Moving some close code to newly added releaseReader.
(WebCore::ReadableStream::releaseReader): Implements reader release and callbacks finalization.
(WebCore::ReadableStream::changeStateToErrored): Calls releaseReader.
* Modules/streams/ReadableStream.h:
(WebCore::ReadableStream::hasReadPendingRequests): Added to enable reader.releaseLock throwing if read requests are pending.
* Modules/streams/ReadableStreamReader.cpp:
(WebCore::ReadableStreamReader::releaseLock): Implementation of releaseLock
* Modules/streams/ReadableStreamReader.h:
* Modules/streams/ReadableStreamReader.idl:
(WebCore::releaseLock): Deleted.
LayoutTests:
* streams/reference-implementation/readable-stream-expected.txt: Rebasing expectations.
* streams/reference-implementation/readable-stream-reader-expected.txt: Ditto.
* streams/reference-implementation/readable-stream-templated-expected.txt: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationreadablestreamexpectedtxt">trunk/LayoutTests/streams/reference-implementation/readable-stream-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationreadablestreamreaderexpectedtxt">trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationreadablestreamtemplatedexpectedtxt">trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamcpp">trunk/Source/WebCore/Modules/streams/ReadableStream.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamh">trunk/Source/WebCore/Modules/streams/ReadableStream.h</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamReadercpp">trunk/Source/WebCore/Modules/streams/ReadableStreamReader.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamReaderh">trunk/Source/WebCore/Modules/streams/ReadableStreamReader.h</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamReaderidl">trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSReadableStreamReaderCustomcpp">trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/LayoutTests/ChangeLog 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2015-06-18 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
</span><span class="cx">
</span><ins>+ [Streams API] Implement ReadableStreamReader.releaseLock
+ https://bugs.webkit.org/show_bug.cgi?id=145299
+
+ Reviewed by Darin Adler.
+
+ * streams/reference-implementation/readable-stream-expected.txt: Rebasing expectations.
+ * streams/reference-implementation/readable-stream-reader-expected.txt: Ditto.
+ * streams/reference-implementation/readable-stream-templated-expected.txt: Ditto.
+
+2015-06-18 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
+
</ins><span class="cx"> [Streams API] Rejected start promise test does not timeout anymore
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=146065
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationreadablestreamexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-expected.txt (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/readable-stream-expected.txt 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-expected.txt 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx"> PASS ReadableStream: enqueue should throw when the stream is readable but draining
</span><span class="cx"> PASS ReadableStream: enqueue should throw when the stream is closed
</span><span class="cx"> PASS ReadableStream: enqueue should throw the stored error when the stream is errored
</span><del>-FAIL ReadableStream: should call underlying source methods as methods releaseLock is not implemented
</del><ins>+FAIL ReadableStream: should call underlying source methods as methods cancel is not implemented
</ins><span class="cx"> FAIL ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue assert_equals: expected (number) 1 but got (undefined) undefined
</span><span class="cx"> FAIL ReadableStream strategies: the default strategy should continue giving desiredSize of 1 if the chunks are read immediately assert_equals: desiredSize should start at 1 expected (number) 1 but got (undefined) undefined
</span><span class="cx"> PASS ReadableStream integration test: adapting a random push source
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationreadablestreamreaderexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -12,10 +12,10 @@
</span><span class="cx"> PASS Reading from a reader for an empty stream will wait until a chunk is available
</span><span class="cx"> FAIL cancel() on a reader releases the reader before calling through cancel is not implemented
</span><span class="cx"> PASS closed should be fulfilled after stream is closed (.closed access before acquiring)
</span><del>-FAIL closed should be fulfilled after reader releases its lock (multiple stream locks) releaseLock is not implemented
-FAIL Multiple readers can access the stream in sequence releaseLock is not implemented
-FAIL Cannot use an already-released reader to unlock a stream again releaseLock is not implemented
-FAIL cancel() on a released reader is a no-op and does not pass through releaseLock is not implemented
</del><ins>+PASS closed should be fulfilled after reader releases its lock (multiple stream locks)
+PASS Multiple readers can access the stream in sequence
+PASS Cannot use an already-released reader to unlock a stream again
+FAIL cancel() on a released reader is a no-op and does not pass through cancel is not implemented
</ins><span class="cx"> PASS Getting a second reader after erroring the stream should succeed
</span><span class="cx"> PASS Garbage-collecting a ReadableStreamReader should not unlock its stream
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationreadablestreamtemplatedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -8,10 +8,10 @@
</span><span class="cx"> PASS two read()s should both never settle
</span><span class="cx"> PASS read() should return distinct promises each time
</span><span class="cx"> PASS getReader() again on the stream should fail
</span><del>-FAIL releasing the lock with pending read requests should throw but the read requests should stay pending releaseLock is not implemented
-FAIL releasing the lock should cause further read() calls to resolve as if the stream is closed releaseLock is not implemented
-FAIL releasing the lock should cause closed to fulfill releaseLock is not implemented
-FAIL releasing the lock should cause locked to become false releaseLock is not implemented
</del><ins>+FAIL releasing the lock with pending read requests should throw but the read requests should stay pending Type error
+PASS releasing the lock should cause further read() calls to resolve as if the stream is closed
+PASS releasing the lock should cause closed to fulfill
+PASS releasing the lock should cause locked to become false
</ins><span class="cx"> FAIL canceling via the reader should cause the reader to act closed cancel is not implemented
</span><span class="cx"> FAIL canceling via the stream should fail cancel is not implemented
</span><span class="cx"> PASS Running templatedRSClosed with ReadableStream (closed via call in start)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> PASS third read(), without waiting, should give { value: undefined, done: true }
</span><span class="cx"> PASS third read, with waiting, should give { value: undefined, done: true }
</span><span class="cx"> PASS draining the stream via read() should cause the reader closed promise to fulfill and locked to be false
</span><del>-FAIL releasing the lock after the stream is closed should do nothing releaseLock is not implemented
-FAIL releasing the lock should cause read() to act as if the stream is closed releaseLock is not implemented
-FAIL reader's closed property always returns the same promise releaseLock is not implemented
</del><ins>+PASS releasing the lock after the stream is closed should do nothing
+PASS releasing the lock should cause read() to act as if the stream is closed
+PASS reader's closed property always returns the same promise
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/Source/WebCore/ChangeLog 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2015-06-18 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
+
+ [Streams API] Implement ReadableStreamReader.releaseLock
+ https://bugs.webkit.org/show_bug.cgi?id=145299
+
+ Reviewed by Darin Adler.
+
+ Covered by rebased tests.
+
+ * Modules/streams/ReadableStream.cpp:
+ (WebCore::ReadableStream::close): Moving some close code to newly added releaseReader.
+ (WebCore::ReadableStream::releaseReader): Implements reader release and callbacks finalization.
+ (WebCore::ReadableStream::changeStateToErrored): Calls releaseReader.
+ * Modules/streams/ReadableStream.h:
+ (WebCore::ReadableStream::hasReadPendingRequests): Added to enable reader.releaseLock throwing if read requests are pending.
+ * Modules/streams/ReadableStreamReader.cpp:
+ (WebCore::ReadableStreamReader::releaseLock): Implementation of releaseLock
+ * Modules/streams/ReadableStreamReader.h:
+ * Modules/streams/ReadableStreamReader.idl:
+ (WebCore::releaseLock): Deleted.
+
</ins><span class="cx"> 2015-06-18 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> GObject and ObjC bindings generator should not generate code for promise-based APIs
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStream.cpp (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStream.cpp 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/Source/WebCore/Modules/streams/ReadableStream.cpp 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -79,10 +79,11 @@
</span><span class="cx"> void ReadableStream::close()
</span><span class="cx"> {
</span><span class="cx"> m_state = State::Closed;
</span><ins>+ releaseReader();
+}
</ins><span class="cx">
</span><del>- if (m_reader)
- m_releasedReaders.append(WTF::move(m_reader));
-
</del><ins>+void ReadableStream::releaseReader()
+{
</ins><span class="cx"> if (m_closedSuccessCallback)
</span><span class="cx"> m_closedSuccessCallback();
</span><span class="cx">
</span><span class="lines">@@ -90,6 +91,8 @@
</span><span class="cx"> request.endCallback();
</span><span class="cx">
</span><span class="cx"> clearCallbacks();
</span><ins>+ if (m_reader)
+ m_releasedReaders.append(WTF::move(m_reader));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ReadableStream::changeStateToErrored()
</span><span class="lines">@@ -98,9 +101,6 @@
</span><span class="cx"> return;
</span><span class="cx"> m_state = State::Errored;
</span><span class="cx">
</span><del>- if (m_reader)
- m_releasedReaders.append(WTF::move(m_reader));
-
</del><span class="cx"> JSC::JSValue error = this->error();
</span><span class="cx"> if (m_closedFailureCallback)
</span><span class="cx"> m_closedFailureCallback(error);
</span><span class="lines">@@ -109,6 +109,8 @@
</span><span class="cx"> request.failureCallback(error);
</span><span class="cx">
</span><span class="cx"> clearCallbacks();
</span><ins>+ if (m_reader)
+ releaseReader();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ReadableStream::start()
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStream.h (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStream.h 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/Source/WebCore/Modules/streams/ReadableStream.h 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -67,6 +67,9 @@
</span><span class="cx">
</span><span class="cx"> bool locked() const { return !!m_reader; }
</span><span class="cx">
</span><ins>+ void releaseReader();
+ bool hasReadPendingRequests() { return !m_readRequests.isEmpty(); }
+
</ins><span class="cx"> bool isErrored() const { return m_state == State::Errored; }
</span><span class="cx"> bool isReadable() const { return m_state == State::Readable; }
</span><span class="cx"> bool isCloseRequested() const { return m_closeRequested; }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamReadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamReader.cpp (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStreamReader.cpp 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamReader.cpp 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "ReadableStreamReader.h"
</span><span class="cx">
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include <runtime/JSCJSValueInlines.h>
</span><span class="cx">
</span><span class="cx"> #if ENABLE(STREAMS_API)
</span><span class="lines">@@ -54,6 +55,17 @@
</span><span class="cx"> m_stream.read(WTF::move(successCallback), WTF::move(endCallback), WTF::move(failureCallback));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void ReadableStreamReader::releaseLock(ExceptionCode& ec)
+{
+ if (m_stream.reader() != this)
+ return;
+ if (m_stream.hasReadPendingRequests()) {
+ ec = TypeError;
+ return;
+ }
+ m_stream.releaseReader();
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+}
+
</ins><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamReaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamReader.h (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStreamReader.h 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamReader.h 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -41,6 +41,8 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><ins>+typedef int ExceptionCode;
+
</ins><span class="cx"> // ReadableStreamReader implements access to ReadableStream from JavaScript.
</span><span class="cx"> // It basically allows access to the ReadableStream iff the ReadableStreamReader instance is the active reader
</span><span class="cx"> // of the ReadableStream.
</span><span class="lines">@@ -53,6 +55,7 @@
</span><span class="cx">
</span><span class="cx"> void closed(ReadableStream::ClosedSuccessCallback&&, ReadableStream::FailureCallback&&);
</span><span class="cx"> void read(ReadableStream::ReadSuccessCallback&&, ReadableStream::ReadEndCallback&&, ReadableStream::FailureCallback&&);
</span><ins>+ void releaseLock(ExceptionCode&);
</ins><span class="cx">
</span><span class="cx"> void ref() { m_stream.ref(); }
</span><span class="cx"> void deref() { m_stream.deref(); }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamReaderidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> // FIXME: Remove RaisesException once methods are implemented.
</span><span class="cx"> [Custom, RaisesException] Object read();
</span><span class="cx"> [Custom, RaisesException] Promise cancel(DOMString reason);
</span><del>- [Custom, RaisesException] void releaseLock();
</del><ins>+ [RaisesException] void releaseLock();
</ins><span class="cx">
</span><span class="cx"> [CustomGetter] readonly attribute Promise closed;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSReadableStreamReaderCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp (185696 => 185697)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp 2015-06-18 08:57:09 UTC (rev 185696)
+++ trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp 2015-06-18 08:58:18 UTC (rev 185697)
</span><span class="lines">@@ -92,12 +92,6 @@
</span><span class="cx"> return exec->vm().throwException(exec, error);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-JSValue JSReadableStreamReader::releaseLock(ExecState* exec)
-{
- JSValue error = createError(exec, ASCIILiteral("releaseLock is not implemented"));
- return exec->vm().throwException(exec, error);
-}
-
</del><span class="cx"> EncodedJSValue JSC_HOST_CALL constructJSReadableStreamReader(ExecState* exec)
</span><span class="cx"> {
</span><span class="cx"> if (!exec->argumentCount())
</span></span></pre>
</div>
</div>
</body>
</html>