<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185540] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185540">185540</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-06-13 13:42:04 -0700 (Sat, 13 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: console.table() with a list of objects no longer works
https://bugs.webkit.org/show_bug.cgi?id=145952
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-13
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
* inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._generatePreview):
Calling generatePreview again was actually starting with a preview
of the current object instead of the sub-value. Go down the other
path that correctly generates sub-previews. Leave filtering on the
backend unimplemented, which we were already ignoring.
Source/WebInspectorUI:
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsTable):
Don't allow expanding a cosole.table message, and don't output the total
object even if the table preview was lossless, as the experience is poor.
LayoutTests:
* inspector/console/console-api.html:
* inspector/console/console-table-expected.txt: Added.
* inspector/console/console-table.html:
Add a similiar console API test all about console.table().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectorconsoleconsoleapihtml">trunk/LayoutTests/inspector/console/console-api.html</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorInjectedScriptSourcejs">trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsConsoleMessageViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsinspectorconsoleconsoletableexpectedtxt">trunk/LayoutTests/inspector/console/console-table-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorconsoleconsoletablehtml">trunk/LayoutTests/inspector/console/console-table.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (185539 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-06-13 19:28:38 UTC (rev 185539)
+++ trunk/LayoutTests/ChangeLog 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-06-13 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: console.table() with a list of objects no longer works
+ https://bugs.webkit.org/show_bug.cgi?id=145952
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/console/console-api.html:
+ * inspector/console/console-table-expected.txt: Added.
+ * inspector/console/console-table.html:
+ Add a similiar console API test all about console.table().
+
</ins><span class="cx"> 2015-06-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> [EFL] Mark fast/forms/select-element-focus-ring.html to Missing
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorconsoleconsoleapihtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/console/console-api.html (185539 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/console/console-api.html 2015-06-13 19:28:38 UTC (rev 185539)
+++ trunk/LayoutTests/inspector/console/console-api.html 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</span><del>-<script type="text/javascript" src="../../http/tests/inspector/inspector-test.js"></script>
</del><ins>+<script src="../../http/tests/inspector/inspector-test.js"></script>
</ins><span class="cx"> <script>
</span><span class="cx"> var string = "string";
</span><span class="cx"> var object = {a:1};
</span><span class="lines">@@ -37,7 +37,6 @@
</span><span class="cx"> {
</span><span class="cx"> if (key === "_objectId" || key === "_stackTrace")
</span><span class="cx"> return "<filtered>";
</span><del>-
</del><span class="cx"> return value;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorconsoleconsoletableexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/inspector/console/console-table-expected.txt (0 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/console/console-table-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/console/console-table-expected.txt 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -0,0 +1,477 @@
</span><ins>+CONSOLE MESSAGE: line 1:
+CONSOLE MESSAGE: line 1: apple,orange,banana
+CONSOLE MESSAGE: line 1: [object Object]
+CONSOLE MESSAGE: line 1: John,Smith,Jane,Doe,Emily,Jones
+CONSOLE MESSAGE: line 1: [object Object],[object Object],[object Object]
+CONSOLE MESSAGE: line 1: [object Object],[object Object],[object Object]
+
+STEP: console.table([])
+{
+ "_source": "console-api",
+ "_level": "log",
+ "_messageText": "",
+ "_type": "table",
+ "_url": null,
+ "_line": 1,
+ "_column": 14,
+ "_repeatCount": 1,
+ "_parameters": [
+ {
+ "_type": "object",
+ "_subtype": "array",
+ "_objectId": "<filtered>",
+ "_description": "Array",
+ "_hasChildren": true,
+ "_size": 0,
+ "_preview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 0,
+ "_properties": [],
+ "_entries": null
+ }
+ }
+ ],
+ "_stackTrace": "<filtered>",
+ "_request": null
+}
+
+STEP: console.table(['apple', 'orange', 'banana'])
+{
+ "_source": "console-api",
+ "_level": "log",
+ "_messageText": "apple,orange,banana",
+ "_type": "table",
+ "_url": null,
+ "_line": 1,
+ "_column": 14,
+ "_repeatCount": 1,
+ "_parameters": [
+ {
+ "_type": "object",
+ "_subtype": "array",
+ "_objectId": "<filtered>",
+ "_description": "Array",
+ "_hasChildren": true,
+ "_size": 3,
+ "_preview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 3,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "string",
+ "_value": "apple"
+ },
+ {
+ "_name": "1",
+ "_type": "string",
+ "_value": "orange"
+ },
+ {
+ "_name": "2",
+ "_type": "string",
+ "_value": "banana"
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_stackTrace": "<filtered>",
+ "_request": null
+}
+
+STEP: console.table({firstName: 'John', lastName: 'Smith'})
+{
+ "_source": "console-api",
+ "_level": "log",
+ "_messageText": "[object Object]",
+ "_type": "table",
+ "_url": null,
+ "_line": 1,
+ "_column": 14,
+ "_repeatCount": 1,
+ "_parameters": [
+ {
+ "_type": "object",
+ "_objectId": "<filtered>",
+ "_description": "Object",
+ "_hasChildren": true,
+ "_preview": {
+ "_type": "object",
+ "_description": "Object",
+ "_lossless": true,
+ "_overflow": false,
+ "_properties": [
+ {
+ "_name": "firstName",
+ "_type": "string",
+ "_value": "John"
+ },
+ {
+ "_name": "lastName",
+ "_type": "string",
+ "_value": "Smith"
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_stackTrace": "<filtered>",
+ "_request": null
+}
+
+STEP: console.table([['John', 'Smith'], ['Jane', 'Doe'], ['Emily', 'Jones']])
+{
+ "_source": "console-api",
+ "_level": "log",
+ "_messageText": "John,Smith,Jane,Doe,Emily,Jones",
+ "_type": "table",
+ "_url": null,
+ "_line": 1,
+ "_column": 14,
+ "_repeatCount": 1,
+ "_parameters": [
+ {
+ "_type": "object",
+ "_subtype": "array",
+ "_objectId": "<filtered>",
+ "_description": "Array",
+ "_hasChildren": true,
+ "_size": 3,
+ "_preview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 3,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "object",
+ "_subtype": "array",
+ "_valuePreview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 2,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "string",
+ "_value": "John"
+ },
+ {
+ "_name": "1",
+ "_type": "string",
+ "_value": "Smith"
+ }
+ ],
+ "_entries": null
+ }
+ },
+ {
+ "_name": "1",
+ "_type": "object",
+ "_subtype": "array",
+ "_valuePreview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 2,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "string",
+ "_value": "Jane"
+ },
+ {
+ "_name": "1",
+ "_type": "string",
+ "_value": "Doe"
+ }
+ ],
+ "_entries": null
+ }
+ },
+ {
+ "_name": "2",
+ "_type": "object",
+ "_subtype": "array",
+ "_valuePreview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 2,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "string",
+ "_value": "Emily"
+ },
+ {
+ "_name": "1",
+ "_type": "string",
+ "_value": "Jones"
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_stackTrace": "<filtered>",
+ "_request": null
+}
+
+STEP: console.table([john, jane, emily])
+{
+ "_source": "console-api",
+ "_level": "log",
+ "_messageText": "[object Object],[object Object],[object Object]",
+ "_type": "table",
+ "_url": null,
+ "_line": 1,
+ "_column": 14,
+ "_repeatCount": 1,
+ "_parameters": [
+ {
+ "_type": "object",
+ "_subtype": "array",
+ "_objectId": "<filtered>",
+ "_description": "Array",
+ "_hasChildren": true,
+ "_size": 3,
+ "_preview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 3,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "object",
+ "_valuePreview": {
+ "_type": "object",
+ "_description": "Person",
+ "_lossless": true,
+ "_overflow": false,
+ "_properties": [
+ {
+ "_name": "firstName",
+ "_type": "string",
+ "_value": "John"
+ },
+ {
+ "_name": "lastName",
+ "_type": "string",
+ "_value": "Smith"
+ }
+ ],
+ "_entries": null
+ }
+ },
+ {
+ "_name": "1",
+ "_type": "object",
+ "_valuePreview": {
+ "_type": "object",
+ "_description": "Person",
+ "_lossless": true,
+ "_overflow": false,
+ "_properties": [
+ {
+ "_name": "firstName",
+ "_type": "string",
+ "_value": "Jane"
+ },
+ {
+ "_name": "lastName",
+ "_type": "string",
+ "_value": "Doe"
+ }
+ ],
+ "_entries": null
+ }
+ },
+ {
+ "_name": "2",
+ "_type": "object",
+ "_valuePreview": {
+ "_type": "object",
+ "_description": "Person",
+ "_lossless": true,
+ "_overflow": false,
+ "_properties": [
+ {
+ "_name": "firstName",
+ "_type": "string",
+ "_value": "Emily"
+ },
+ {
+ "_name": "lastName",
+ "_type": "string",
+ "_value": "Jones"
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_stackTrace": "<filtered>",
+ "_request": null
+}
+
+STEP: console.table([john, jane, emily], ['firstName'])
+{
+ "_source": "console-api",
+ "_level": "log",
+ "_messageText": "[object Object],[object Object],[object Object]",
+ "_type": "table",
+ "_url": null,
+ "_line": 1,
+ "_column": 14,
+ "_repeatCount": 1,
+ "_parameters": [
+ {
+ "_type": "object",
+ "_subtype": "array",
+ "_objectId": "<filtered>",
+ "_description": "Array",
+ "_hasChildren": true,
+ "_size": 3,
+ "_preview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 3,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "object",
+ "_valuePreview": {
+ "_type": "object",
+ "_description": "Person",
+ "_lossless": true,
+ "_overflow": false,
+ "_properties": [
+ {
+ "_name": "firstName",
+ "_type": "string",
+ "_value": "John"
+ },
+ {
+ "_name": "lastName",
+ "_type": "string",
+ "_value": "Smith"
+ }
+ ],
+ "_entries": null
+ }
+ },
+ {
+ "_name": "1",
+ "_type": "object",
+ "_valuePreview": {
+ "_type": "object",
+ "_description": "Person",
+ "_lossless": true,
+ "_overflow": false,
+ "_properties": [
+ {
+ "_name": "firstName",
+ "_type": "string",
+ "_value": "Jane"
+ },
+ {
+ "_name": "lastName",
+ "_type": "string",
+ "_value": "Doe"
+ }
+ ],
+ "_entries": null
+ }
+ },
+ {
+ "_name": "2",
+ "_type": "object",
+ "_valuePreview": {
+ "_type": "object",
+ "_description": "Person",
+ "_lossless": true,
+ "_overflow": false,
+ "_properties": [
+ {
+ "_name": "firstName",
+ "_type": "string",
+ "_value": "Emily"
+ },
+ {
+ "_name": "lastName",
+ "_type": "string",
+ "_value": "Jones"
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_entries": null
+ }
+ },
+ {
+ "_type": "object",
+ "_subtype": "array",
+ "_objectId": "<filtered>",
+ "_description": "Array",
+ "_hasChildren": true,
+ "_size": 1,
+ "_preview": {
+ "_type": "object",
+ "_subtype": "array",
+ "_description": "Array",
+ "_lossless": true,
+ "_overflow": false,
+ "_size": 1,
+ "_properties": [
+ {
+ "_name": "0",
+ "_type": "string",
+ "_value": "firstName"
+ }
+ ],
+ "_entries": null
+ }
+ }
+ ],
+ "_stackTrace": "<filtered>",
+ "_request": null
+}
+
</ins></span></pre></div>
<a id="trunkLayoutTestsinspectorconsoleconsoletablehtmlfromrev185539trunkLayoutTestsinspectorconsoleconsoleapihtml"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/inspector/console/console-table.html (from rev 185539, trunk/LayoutTests/inspector/console/console-api.html) (0 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/console/console-table.html (rev 0)
+++ trunk/LayoutTests/inspector/console/console-table.html 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -0,0 +1,52 @@
</span><ins>+<!doctype html>
+<html>
+<head>
+<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
+<script src="../../http/tests/inspector/inspector-test.js"></script>
+<script>
+function Person(firstName, lastName) {
+ this.firstName = firstName;
+ this.lastName = lastName;
+}
+
+var john = new Person("John", "Smith");
+var jane = new Person("Jane", "Doe");
+var emily = new Person("Emily", "Jones");
+
+function test()
+{
+ var currentStepIndex = 0;
+ var steps = [
+ "console.table([])", // Empty.
+ "console.table(['apple', 'orange', 'banana'])", // Index (array index), Value
+ "console.table({firstName: 'John', lastName: 'Smith'})", // Index (property name), Value (property value)
+ "console.table([['John', 'Smith'], ['Jane', 'Doe'], ['Emily', 'Jones']])", // Index, 0, 1
+ "console.table([john, jane, emily])", // Index, firstName, lastName
+ "console.table([john, jane, emily], ['firstName'])", // Index, firstName (at least).
+ ];
+
+ function remoteObjectJSONFilter(key, value)
+ {
+ if (key === "_objectId" || key === "_stackTrace")
+ return "<filtered>";
+ return value;
+ }
+
+ WebInspector.logManager.addEventListener(WebInspector.LogManager.Event.MessageAdded, function(event) {
+ var message = event.data.message;
+ InspectorTest.assert(message instanceof WebInspector.ConsoleMessage);
+ InspectorTest.log("\nSTEP: " + steps[currentStepIndex]);
+ InspectorTest.log(JSON.stringify(message, remoteObjectJSONFilter, " "));
+
+ if (++currentStepIndex >= steps.length)
+ InspectorTest.completeTest();
+ });
+
+ for (var step of steps)
+ WebInspector.runtimeManager.evaluateInInspectedWindow(step, "test", false, true, false, true, false, function(){});
+}
+</script>
+</head>
+<body onload="runTest();">
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (185539 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-06-13 19:28:38 UTC (rev 185539)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-06-13 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: console.table() with a list of objects no longer works
+ https://bugs.webkit.org/show_bug.cgi?id=145952
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/InjectedScriptSource.js:
+ (InjectedScript.RemoteObject.prototype._generatePreview):
+ Calling generatePreview again was actually starting with a preview
+ of the current object instead of the sub-value. Go down the other
+ path that correctly generates sub-previews. Leave filtering on the
+ backend unimplemented, which we were already ignoring.
+
</ins><span class="cx"> 2015-06-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> [Streams API] ReadableJSStream should handle promises returned by JS source start callback
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorInjectedScriptSourcejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js (185539 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js 2015-06-13 19:28:38 UTC (rev 185539)
+++ trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -1102,7 +1102,8 @@
</span><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> // If we have a filter, only show properties in the filter.
</span><del>- if (firstLevelKeys && firstLevelKeys.indexOf(name) === -1)
</del><ins>+ // FIXME: Currently these filters do nothing on the backend.
+ if (firstLevelKeys && !firstLevelKeys.includes(name))
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> // Getter/setter.
</span><span class="lines">@@ -1157,14 +1158,8 @@
</span><span class="cx"> property.subtype = subtype;
</span><span class="cx">
</span><span class="cx"> // Second level.
</span><del>- if (secondLevelKeys === null || secondLevelKeys) {
- var subPreview = this._generatePreview(value, secondLevelKeys || undefined, undefined);
- property.valuePreview = subPreview;
- if (!subPreview.lossless)
- preview.lossless = false;
- if (subPreview.overflow)
- preview.overflow = true;
- } else if (this._isPreviewableObject(value)) {
</del><ins>+ if ((secondLevelKeys === null || secondLevelKeys) || this._isPreviewableObject(value)) {
+ // FIXME: If we want secondLevelKeys filter to continue we would need some refactoring.
</ins><span class="cx"> var subPreview = this._createObjectPreviewForValue(value);
</span><span class="cx"> property.valuePreview = subPreview;
</span><span class="cx"> if (!subPreview.lossless)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (185539 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-13 19:28:38 UTC (rev 185539)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-06-13 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: console.table() with a list of objects no longer works
+ https://bugs.webkit.org/show_bug.cgi?id=145952
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ConsoleMessageView.js:
+ (WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
+ (WebInspector.ConsoleMessageView.prototype._formatParameterAsTable):
+ Don't allow expanding a cosole.table message, and don't output the total
+ object even if the table preview was lossless, as the experience is poor.
+
</ins><span class="cx"> 2015-06-11 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: CSS Regions not displaying DOM Trees in inspector
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsConsoleMessageViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (185539 => 185540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-06-13 19:28:38 UTC (rev 185539)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-06-13 20:42:04 UTC (rev 185540)
</span><span class="lines">@@ -243,9 +243,9 @@
</span><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> case WebInspector.ConsoleMessage.MessageType.Table:
</span><del>- // FIXME: Remove messageText?
- var args = this._message.parameters || [this._message.messageText];
</del><ins>+ var args = this._message.parameters;
</ins><span class="cx"> element.appendChild(this._formatParameterAsTable(args));
</span><ins>+ this._extraParameters = null;
</ins><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> default:
</span><span class="lines">@@ -735,13 +735,12 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // If lossless or not table data, output the object so full data can be gotten.
- if (!preview.lossless || !flatValues.length) {
- element.appendChild(this._formatParameter(table));
- if (!flatValues.length)
- return element;
- }
</del><ins>+ // If no table data show nothing.
+ if (!flatValues.length)
+ return element;
</ins><span class="cx">
</span><ins>+ // FIXME: Should we output something extra if the preview is lossless?
+
</ins><span class="cx"> var dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, flatValues);
</span><span class="cx"> dataGrid.element.classList.add("inline");
</span><span class="cx"> element.appendChild(dataGrid.element);
</span></span></pre>
</div>
</div>
</body>
</html>