<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185532] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185532">185532</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-06-12 20:52:06 -0700 (Fri, 12 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Purge PassRefPtr in JavaScriptCore - 2
https://bugs.webkit.org/show_bug.cgi?id=145834
Reviewed by Darin Adler.
Source/JavaScriptCore:
As a step to remove PassRefPtr, this patch cleans up PassRefPtr as much as possible
in JavaScriptCore.
* API/JSClassRef.cpp:
(OpaqueJSClass::create):
* API/JSClassRef.h:
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::callerFrame):
* debugger/DebuggerCallFrame.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::jitCode):
* inspector/ScriptCallStackFactory.cpp:
(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
(Inspector::createScriptCallStackFromException):
(Inspector::createScriptArguments):
* inspector/ScriptCallStackFactory.h:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
* profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::stopProfiling):
* profiler/LegacyProfiler.h:
* runtime/DateInstanceCache.h:
* runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
* runtime/Executable.h:
* runtime/GenericTypedArrayView.h:
* runtime/GenericTypedArrayViewInlines.h:
(JSC::GenericTypedArrayView<Adaptor>::create):
(JSC::GenericTypedArrayView<Adaptor>::createUninitialized):
Source/WebCore:
Fix call sites depends on changing of JSC.
* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getParameter):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getParameter):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::getVertexAttrib):
(WebCore::WebGLRenderingContextBase::getWebGLFloatArrayParameter):
(WebCore::WebGLRenderingContextBase::getWebGLIntArrayParameter):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreAPIJSClassRefcpp">trunk/Source/JavaScriptCore/API/JSClassRef.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSClassRefh">trunk/Source/JavaScriptCore/API/JSClassRef.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggerCallFramecpp">trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggerCallFrameh">trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGJITCompilerh">trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorScriptCallStackFactorycpp">trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorScriptCallStackFactoryh">trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitExecutableAllocatorcpp">trunk/Source/JavaScriptCore/jit/ExecutableAllocator.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitExecutableAllocatorh">trunk/Source/JavaScriptCore/jit/ExecutableAllocator.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitExecutableAllocatorFixedVMPoolcpp">trunk/Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreprofilerLegacyProfilercpp">trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreprofilerLegacyProfilerh">trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeDateInstanceCacheh">trunk/Source/JavaScriptCore/runtime/DateInstanceCache.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExecutablecpp">trunk/Source/JavaScriptCore/runtime/Executable.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExecutableh">trunk/Source/JavaScriptCore/runtime/Executable.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeGenericTypedArrayViewh">trunk/Source/JavaScriptCore/runtime/GenericTypedArrayView.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeGenericTypedArrayViewInlinesh">trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGL2RenderingContextcpp">trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLRenderingContextcpp">trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLRenderingContextBasecpp">trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreAPIJSClassRefcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSClassRef.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSClassRef.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/API/JSClassRef.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -113,7 +113,7 @@
</span><span class="cx"> return adoptRef(*new OpaqueJSClass(definition, 0));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<OpaqueJSClass> OpaqueJSClass::create(const JSClassDefinition* clientDefinition)
</del><ins>+Ref<OpaqueJSClass> OpaqueJSClass::create(const JSClassDefinition* clientDefinition)
</ins><span class="cx"> {
</span><span class="cx"> JSClassDefinition definition = *clientDefinition; // Avoid modifying client copy.
</span><span class="cx">
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> // We are supposed to use JSClassRetain/Release but since we know that we currently have
</span><span class="cx"> // the only reference to this class object we cheat and use a RefPtr instead.
</span><span class="cx"> RefPtr<OpaqueJSClass> protoClass = adoptRef(new OpaqueJSClass(&protoDefinition, 0));
</span><del>- return adoptRef(new OpaqueJSClass(&definition, protoClass.get()));
</del><ins>+ return adoptRef(*new OpaqueJSClass(&definition, protoClass.get()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> OpaqueJSClassContextData::OpaqueJSClassContextData(JSC::VM&, OpaqueJSClass* jsClass)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSClassRefh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSClassRef.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSClassRef.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/API/JSClassRef.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> struct OpaqueJSClass : public ThreadSafeRefCounted<OpaqueJSClass> {
</span><del>- static PassRefPtr<OpaqueJSClass> create(const JSClassDefinition*);
</del><ins>+ static Ref<OpaqueJSClass> create(const JSClassDefinition*);
</ins><span class="cx"> static Ref<OpaqueJSClass> createNoAutomaticPrototype(const JSClassDefinition*);
</span><span class="cx"> JS_EXPORT_PRIVATE ~OpaqueJSClass();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2015-06-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Purge PassRefPtr in JavaScriptCore - 2
+ https://bugs.webkit.org/show_bug.cgi?id=145834
+
+ Reviewed by Darin Adler.
+
+ As a step to remove PassRefPtr, this patch cleans up PassRefPtr as much as possible
+ in JavaScriptCore.
+
+ * API/JSClassRef.cpp:
+ (OpaqueJSClass::create):
+ * API/JSClassRef.h:
+ * debugger/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::callerFrame):
+ * debugger/DebuggerCallFrame.h:
+ * dfg/DFGJITCompiler.h:
+ (JSC::DFG::JITCompiler::jitCode):
+ * inspector/ScriptCallStackFactory.cpp:
+ (Inspector::createScriptCallStack):
+ (Inspector::createScriptCallStackForConsole):
+ (Inspector::createScriptCallStackFromException):
+ (Inspector::createScriptArguments):
+ * inspector/ScriptCallStackFactory.h:
+ * jit/ExecutableAllocator.cpp:
+ (JSC::ExecutableAllocator::allocate):
+ * jit/ExecutableAllocator.h:
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::ExecutableAllocator::allocate):
+ * profiler/LegacyProfiler.cpp:
+ (JSC::LegacyProfiler::stopProfiling):
+ * profiler/LegacyProfiler.h:
+ * runtime/DateInstanceCache.h:
+ * runtime/Executable.cpp:
+ (JSC::ScriptExecutable::newCodeBlockFor):
+ * runtime/Executable.h:
+ * runtime/GenericTypedArrayView.h:
+ * runtime/GenericTypedArrayViewInlines.h:
+ (JSC::GenericTypedArrayView<Adaptor>::create):
+ (JSC::GenericTypedArrayView<Adaptor>::createUninitialized):
+
</ins><span class="cx"> 2015-06-12 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix minor ES6 compliance issue in RegExp.prototype.toString and optimize performance a little
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggerCallFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -88,7 +88,7 @@
</span><span class="cx"> m_position = positionForCallFrame(m_callFrame);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<DebuggerCallFrame> DebuggerCallFrame::callerFrame()
</del><ins>+RefPtr<DebuggerCallFrame> DebuggerCallFrame::callerFrame()
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(isValid());
</span><span class="cx"> if (!isValid())
</span><span class="lines">@@ -102,7 +102,7 @@
</span><span class="cx">
</span><span class="cx"> CallFrame* callerFrame = functor.getCallerFrame();
</span><span class="cx"> if (!callerFrame)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> m_caller = DebuggerCallFrame::create(callerFrame);
</span><span class="cx"> return m_caller;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggerCallFrameh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> JS_EXPORT_PRIVATE explicit DebuggerCallFrame(CallFrame*);
</span><span class="cx">
</span><del>- JS_EXPORT_PRIVATE PassRefPtr<DebuggerCallFrame> callerFrame();
</del><ins>+ JS_EXPORT_PRIVATE RefPtr<DebuggerCallFrame> callerFrame();
</ins><span class="cx"> ExecState* exec() const { return m_callFrame; }
</span><span class="cx"> JS_EXPORT_PRIVATE SourceID sourceID() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGJITCompilerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -313,7 +313,7 @@
</span><span class="cx"> entry->m_reshufflings.shrinkToFit();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- PassRefPtr<JITCode> jitCode() { return m_jitCode; }
</del><ins>+ RefPtr<JITCode> jitCode() { return m_jitCode; }
</ins><span class="cx">
</span><span class="cx"> Vector<Label>& blockHeads() { return m_blockHeads; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorScriptCallStackFactorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> size_t m_remainingCapacityForFrameCapture;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-PassRefPtr<ScriptCallStack> createScriptCallStack(JSC::ExecState* exec, size_t maxStackSize)
</del><ins>+Ref<ScriptCallStack> createScriptCallStack(JSC::ExecState* exec, size_t maxStackSize)
</ins><span class="cx"> {
</span><span class="cx"> if (!exec)
</span><span class="cx"> return ScriptCallStack::create();
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> return ScriptCallStack::create(frames);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ScriptCallStack> createScriptCallStackForConsole(JSC::ExecState* exec, size_t maxStackSize)
</del><ins>+Ref<ScriptCallStack> createScriptCallStackForConsole(JSC::ExecState* exec, size_t maxStackSize)
</ins><span class="cx"> {
</span><span class="cx"> if (!exec)
</span><span class="cx"> return ScriptCallStack::create();
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> exec->clearException();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ScriptCallStack> createScriptCallStackFromException(JSC::ExecState* exec, JSC::Exception* exception, size_t maxStackSize)
</del><ins>+Ref<ScriptCallStack> createScriptCallStackFromException(JSC::ExecState* exec, JSC::Exception* exception, size_t maxStackSize)
</ins><span class="cx"> {
</span><span class="cx"> Vector<ScriptCallFrame> frames;
</span><span class="cx"> RefCountedArray<StackFrame> stackTrace = exception->stack();
</span><span class="lines">@@ -162,7 +162,7 @@
</span><span class="cx"> return ScriptCallStack::create(frames);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ScriptArguments> createScriptArguments(JSC::ExecState* exec, unsigned skipArgumentCount)
</del><ins>+Ref<ScriptArguments> createScriptArguments(JSC::ExecState* exec, unsigned skipArgumentCount)
</ins><span class="cx"> {
</span><span class="cx"> Vector<Deprecated::ScriptValue> arguments;
</span><span class="cx"> size_t argumentCount = exec->argumentCount();
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorScriptCallStackFactoryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/inspector/ScriptCallStackFactory.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -46,10 +46,10 @@
</span><span class="cx"> class ScriptCallStack;
</span><span class="cx">
</span><span class="cx"> // FIXME: The subtle differences between these should be eliminated.
</span><del>-JS_EXPORT_PRIVATE PassRefPtr<ScriptCallStack> createScriptCallStack(JSC::ExecState*, size_t maxStackSize);
-JS_EXPORT_PRIVATE PassRefPtr<ScriptCallStack> createScriptCallStackForConsole(JSC::ExecState*, size_t maxStackSize);
-JS_EXPORT_PRIVATE PassRefPtr<ScriptCallStack> createScriptCallStackFromException(JSC::ExecState*, JSC::Exception*, size_t maxStackSize);
-JS_EXPORT_PRIVATE PassRefPtr<ScriptArguments> createScriptArguments(JSC::ExecState*, unsigned skipArgumentCount);
</del><ins>+JS_EXPORT_PRIVATE Ref<ScriptCallStack> createScriptCallStack(JSC::ExecState*, size_t maxStackSize);
+JS_EXPORT_PRIVATE Ref<ScriptCallStack> createScriptCallStackForConsole(JSC::ExecState*, size_t maxStackSize);
+JS_EXPORT_PRIVATE Ref<ScriptCallStack> createScriptCallStackFromException(JSC::ExecState*, JSC::Exception*, size_t maxStackSize);
+JS_EXPORT_PRIVATE Ref<ScriptArguments> createScriptArguments(JSC::ExecState*, unsigned skipArgumentCount);
</ins><span class="cx">
</span><span class="cx"> } // namespace Inspector
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitExecutableAllocatorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/ExecutableAllocator.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/ExecutableAllocator.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/jit/ExecutableAllocator.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -213,11 +213,11 @@
</span><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ExecutableMemoryHandle> ExecutableAllocator::allocate(VM&, size_t sizeInBytes, void* ownerUID, JITCompilationEffort effort)
</del><ins>+RefPtr<ExecutableMemoryHandle> ExecutableAllocator::allocate(VM&, size_t sizeInBytes, void* ownerUID, JITCompilationEffort effort)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<ExecutableMemoryHandle> result = allocator()->allocate(sizeInBytes, ownerUID);
</span><span class="cx"> RELEASE_ASSERT(result || effort != JITCompilationMustSucceed);
</span><del>- return result.release();
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> size_t ExecutableAllocator::committedByteCount()
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitExecutableAllocatorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/ExecutableAllocator.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/ExecutableAllocator.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/jit/ExecutableAllocator.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -32,7 +32,6 @@
</span><span class="cx"> #include <wtf/MetaAllocatorHandle.h>
</span><span class="cx"> #include <wtf/MetaAllocator.h>
</span><span class="cx"> #include <wtf/PageAllocation.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><span class="lines">@@ -113,7 +112,7 @@
</span><span class="cx"> static void dumpProfile() { }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- PassRefPtr<ExecutableMemoryHandle> allocate(VM&, size_t sizeInBytes, void* ownerUID, JITCompilationEffort);
</del><ins>+ RefPtr<ExecutableMemoryHandle> allocate(VM&, size_t sizeInBytes, void* ownerUID, JITCompilationEffort);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(ASSEMBLER_WX_EXCLUSIVE)
</span><span class="cx"> static void makeWritable(void* start, size_t size)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitExecutableAllocatorFixedVMPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ExecutableMemoryHandle> ExecutableAllocator::allocate(VM&, size_t sizeInBytes, void* ownerUID, JITCompilationEffort effort)
</del><ins>+RefPtr<ExecutableMemoryHandle> ExecutableAllocator::allocate(VM&, size_t sizeInBytes, void* ownerUID, JITCompilationEffort effort)
</ins><span class="cx"> {
</span><span class="cx"> if (effort != JITCompilationCanFail && Options::reportMustSucceedExecutableAllocations()) {
</span><span class="cx"> dataLog("Allocating ", sizeInBytes, " bytes of executable memory with JITCompilationMustSucceed.\n");
</span><span class="lines">@@ -178,7 +178,7 @@
</span><span class="cx"> }
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><del>- return result.release();
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> size_t ExecutableAllocator::committedByteCount()
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreprofilerLegacyProfilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> m_currentProfiles.append(profileGenerator);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Profile> LegacyProfiler::stopProfiling(ExecState* exec, const String& title)
</del><ins>+RefPtr<Profile> LegacyProfiler::stopProfiling(ExecState* exec, const String& title)
</ins><span class="cx"> {
</span><span class="cx"> if (!exec)
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreprofilerLegacyProfilerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> static CallIdentifier createCallIdentifier(ExecState*, JSValue, const WTF::String& sourceURL, unsigned defaultLineNumber, unsigned defaultColumnNumber);
</span><span class="cx">
</span><span class="cx"> JS_EXPORT_PRIVATE void startProfiling(ExecState*, const WTF::String& title, PassRefPtr<Stopwatch>);
</span><del>- JS_EXPORT_PRIVATE PassRefPtr<Profile> stopProfiling(ExecState*, const WTF::String& title);
</del><ins>+ JS_EXPORT_PRIVATE RefPtr<Profile> stopProfiling(ExecState*, const WTF::String& title);
</ins><span class="cx"> void stopProfiling(JSGlobalObject*);
</span><span class="cx">
</span><span class="cx"> // Used to ignore profile node subtrees rooted at InjectedScript calls.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeDateInstanceCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/DateInstanceCache.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/DateInstanceCache.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/runtime/DateInstanceCache.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx"> #include "JSDateMath.h"
</span><span class="cx"> #include <array>
</span><span class="cx"> #include <wtf/HashFunctions.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace JSC {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExecutablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Executable.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Executable.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/runtime/Executable.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -199,7 +199,7 @@
</span><span class="cx"> Heap::heap(this)->writeBarrier(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CodeBlock> ScriptExecutable::newCodeBlockFor(
</del><ins>+RefPtr<CodeBlock> ScriptExecutable::newCodeBlockFor(
</ins><span class="cx"> CodeSpecializationKind kind, JSFunction* function, JSScope* scope, JSObject*& exception)
</span><span class="cx"> {
</span><span class="cx"> VM* vm = scope->vm();
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx"> exception = vm->throwException(
</span><span class="cx"> globalObject->globalExec(),
</span><span class="cx"> error.toErrorObject(globalObject, executable->m_source));
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Parsing reveals whether our function uses features that require a separate function name object in the scope chain.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExecutableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Executable.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Executable.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/runtime/Executable.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -398,7 +398,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void installCode(CodeBlock*);
</span><del>- PassRefPtr<CodeBlock> newCodeBlockFor(CodeSpecializationKind, JSFunction*, JSScope*, JSObject*& exception);
</del><ins>+ RefPtr<CodeBlock> newCodeBlockFor(CodeSpecializationKind, JSFunction*, JSScope*, JSObject*& exception);
</ins><span class="cx"> PassRefPtr<CodeBlock> newReplacementCodeBlockFor(CodeSpecializationKind);
</span><span class="cx">
</span><span class="cx"> JSObject* prepareForExecution(ExecState* exec, JSFunction* function, JSScope* scope, CodeSpecializationKind kind)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeGenericTypedArrayViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/GenericTypedArrayView.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/GenericTypedArrayView.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/runtime/GenericTypedArrayView.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -37,11 +37,11 @@
</span><span class="cx"> GenericTypedArrayView(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned length);
</span><span class="cx">
</span><span class="cx"> public:
</span><del>- static PassRefPtr<GenericTypedArrayView> create(unsigned length);
- static PassRefPtr<GenericTypedArrayView> create(const typename Adaptor::Type* array, unsigned length);
- static PassRefPtr<GenericTypedArrayView> create(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned length);
</del><ins>+ static RefPtr<GenericTypedArrayView> create(unsigned length);
+ static RefPtr<GenericTypedArrayView> create(const typename Adaptor::Type* array, unsigned length);
+ static RefPtr<GenericTypedArrayView> create(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned length);
</ins><span class="cx">
</span><del>- static PassRefPtr<GenericTypedArrayView> createUninitialized(unsigned length);
</del><ins>+ static RefPtr<GenericTypedArrayView> createUninitialized(unsigned length);
</ins><span class="cx">
</span><span class="cx"> typename Adaptor::Type* data() const { return static_cast<typename Adaptor::Type*>(baseAddress()); }
</span><span class="cx">
</span><span class="lines">@@ -98,8 +98,8 @@
</span><span class="cx"> && offset + pos >= offset);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- PassRefPtr<GenericTypedArrayView> subarray(int start) const;
- PassRefPtr<GenericTypedArrayView> subarray(int start, int end) const;
</del><ins>+ RefPtr<GenericTypedArrayView> subarray(int start) const;
+ RefPtr<GenericTypedArrayView> subarray(int start, int end) const;
</ins><span class="cx">
</span><span class="cx"> virtual TypedArrayType getType() const override
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeGenericTypedArrayViewInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -40,25 +40,25 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><del>-PassRefPtr<GenericTypedArrayView<Adaptor>> GenericTypedArrayView<Adaptor>::create(unsigned length)
</del><ins>+RefPtr<GenericTypedArrayView<Adaptor>> GenericTypedArrayView<Adaptor>::create(unsigned length)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<ArrayBuffer> buffer = ArrayBuffer::create(length, sizeof(typename Adaptor::Type));
</span><span class="cx"> if (!buffer)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> return create(buffer.release(), 0, length);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><del>-PassRefPtr<GenericTypedArrayView<Adaptor>> GenericTypedArrayView<Adaptor>::create(
</del><ins>+RefPtr<GenericTypedArrayView<Adaptor>> GenericTypedArrayView<Adaptor>::create(
</ins><span class="cx"> const typename Adaptor::Type* array, unsigned length)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<GenericTypedArrayView> result = create(length);
</span><span class="cx"> memcpy(result->data(), array, length * sizeof(typename Adaptor::Type));
</span><del>- return result.release();
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><del>-PassRefPtr<GenericTypedArrayView<Adaptor>> GenericTypedArrayView<Adaptor>::create(
</del><ins>+RefPtr<GenericTypedArrayView<Adaptor>> GenericTypedArrayView<Adaptor>::create(
</ins><span class="cx"> PassRefPtr<ArrayBuffer> passedBuffer, unsigned byteOffset, unsigned length)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<ArrayBuffer> buffer = passedBuffer;
</span><span class="lines">@@ -71,25 +71,25 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><del>-PassRefPtr<GenericTypedArrayView<Adaptor>>
</del><ins>+RefPtr<GenericTypedArrayView<Adaptor>>
</ins><span class="cx"> GenericTypedArrayView<Adaptor>::createUninitialized(unsigned length)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<ArrayBuffer> buffer =
</span><span class="cx"> ArrayBuffer::createUninitialized(length, sizeof(typename Adaptor::Type));
</span><span class="cx"> if (!buffer)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> return create(buffer.release(), 0, length);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><del>-PassRefPtr<GenericTypedArrayView<Adaptor>>
</del><ins>+RefPtr<GenericTypedArrayView<Adaptor>>
</ins><span class="cx"> GenericTypedArrayView<Adaptor>::subarray(int start) const
</span><span class="cx"> {
</span><span class="cx"> return subarray(start, length());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><del>-PassRefPtr<GenericTypedArrayView<Adaptor>>
</del><ins>+RefPtr<GenericTypedArrayView<Adaptor>>
</ins><span class="cx"> GenericTypedArrayView<Adaptor>::subarray(int start, int end) const
</span><span class="cx"> {
</span><span class="cx"> unsigned offset, length;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/WebCore/ChangeLog 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-06-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Purge PassRefPtr in JavaScriptCore - 2
+ https://bugs.webkit.org/show_bug.cgi?id=145834
+
+ Reviewed by Darin Adler.
+
+ Fix call sites depends on changing of JSC.
+
+ * html/canvas/WebGL2RenderingContext.cpp:
+ (WebCore::WebGL2RenderingContext::getParameter):
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::getParameter):
+ * html/canvas/WebGLRenderingContextBase.cpp:
+ (WebCore::WebGLRenderingContextBase::getUniform):
+ (WebCore::WebGLRenderingContextBase::getVertexAttrib):
+ (WebCore::WebGLRenderingContextBase::getWebGLFloatArrayParameter):
+ (WebCore::WebGLRenderingContextBase::getWebGLIntArrayParameter):
+
</ins><span class="cx"> 2015-06-12 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Be more defensive at renderer type checking when initializing flow segments.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGL2RenderingContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -2117,7 +2117,7 @@
</span><span class="cx"> case GraphicsContext3D::COLOR_WRITEMASK:
</span><span class="cx"> return getBooleanArrayParameter(pname);
</span><span class="cx"> case GraphicsContext3D::COMPRESSED_TEXTURE_FORMATS:
</span><del>- return WebGLGetInfo(Uint32Array::create(m_compressedTextureFormats.data(), m_compressedTextureFormats.size()));
</del><ins>+ return WebGLGetInfo(Uint32Array::create(m_compressedTextureFormats.data(), m_compressedTextureFormats.size()).release());
</ins><span class="cx"> case GraphicsContext3D::CULL_FACE:
</span><span class="cx"> return getBooleanParameter(pname);
</span><span class="cx"> case GraphicsContext3D::CULL_FACE_MODE:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLRenderingContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -953,7 +953,7 @@
</span><span class="cx"> case GraphicsContext3D::COLOR_WRITEMASK:
</span><span class="cx"> return getBooleanArrayParameter(pname);
</span><span class="cx"> case GraphicsContext3D::COMPRESSED_TEXTURE_FORMATS:
</span><del>- return WebGLGetInfo(Uint32Array::create(m_compressedTextureFormats.data(), m_compressedTextureFormats.size()));
</del><ins>+ return WebGLGetInfo(Uint32Array::create(m_compressedTextureFormats.data(), m_compressedTextureFormats.size()).release());
</ins><span class="cx"> case GraphicsContext3D::CULL_FACE:
</span><span class="cx"> return getBooleanParameter(pname);
</span><span class="cx"> case GraphicsContext3D::CULL_FACE_MODE:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLRenderingContextBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (185531 => 185532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2015-06-13 03:25:00 UTC (rev 185531)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2015-06-13 03:52:06 UTC (rev 185532)
</span><span class="lines">@@ -2498,7 +2498,7 @@
</span><span class="cx"> m_context->getUniformfv(objectOrZero(program), location, value);
</span><span class="cx"> if (length == 1)
</span><span class="cx"> return WebGLGetInfo(value[0]);
</span><del>- return WebGLGetInfo(Float32Array::create(value, length));
</del><ins>+ return WebGLGetInfo(Float32Array::create(value, length).release());
</ins><span class="cx"> }
</span><span class="cx"> case GraphicsContext3D::INT: {
</span><span class="cx"> GC3Dint value[4] = {0};
</span><span class="lines">@@ -2508,7 +2508,7 @@
</span><span class="cx"> m_context->getUniformiv(objectOrZero(program), location, value);
</span><span class="cx"> if (length == 1)
</span><span class="cx"> return WebGLGetInfo(value[0]);
</span><del>- return WebGLGetInfo(Int32Array::create(value, length));
</del><ins>+ return WebGLGetInfo(Int32Array::create(value, length).release());
</ins><span class="cx"> }
</span><span class="cx"> case GraphicsContext3D::BOOL: {
</span><span class="cx"> GC3Dint value[4] = {0};
</span><span class="lines">@@ -2607,7 +2607,7 @@
</span><span class="cx"> case GraphicsContext3D::VERTEX_ATTRIB_ARRAY_TYPE:
</span><span class="cx"> return WebGLGetInfo(state.type);
</span><span class="cx"> case GraphicsContext3D::CURRENT_VERTEX_ATTRIB:
</span><del>- return WebGLGetInfo(Float32Array::create(m_vertexAttribValue[index].value, 4));
</del><ins>+ return WebGLGetInfo(Float32Array::create(m_vertexAttribValue[index].value, 4).release());
</ins><span class="cx"> default:
</span><span class="cx"> synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "getVertexAttrib", "invalid parameter name");
</span><span class="cx"> return WebGLGetInfo();
</span><span class="lines">@@ -3986,7 +3986,7 @@
</span><span class="cx"> default:
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><del>- return WebGLGetInfo(Float32Array::create(value, length));
</del><ins>+ return WebGLGetInfo(Float32Array::create(value, length).release());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> WebGLGetInfo WebGLRenderingContextBase::getWebGLIntArrayParameter(GC3Denum pname)
</span><span class="lines">@@ -4005,7 +4005,7 @@
</span><span class="cx"> default:
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><del>- return WebGLGetInfo(Int32Array::create(value, length));
</del><ins>+ return WebGLGetInfo(Int32Array::create(value, length).release());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebGLRenderingContextBase::checkTextureCompleteness(const char* functionName, bool prepareToDraw)
</span></span></pre>
</div>
</div>
</body>
</html>