<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185478] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185478">185478</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2015-06-11 15:30:52 -0700 (Thu, 11 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
https://bugs.webkit.org/show_bug.cgi?id=145319
Reviewed by David Kilzer.
Add SPI wrapper header for CoreSimulator and update the source files to reference
it instead of directly referencing the CoreSimulator header.
* LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
* LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
* LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
* LayoutTestRelay/LayoutTestRelay/main.m:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsLayoutTestRelayLayoutTestRelayLTRelayControllerm">trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m</a></li>
<li><a href="#trunkToolsLayoutTestRelayLayoutTestRelaymainm">trunk/Tools/LayoutTestRelay/LayoutTestRelay/main.m</a></li>
<li><a href="#trunkToolsLayoutTestRelayLayoutTestRelayxcodeprojprojectpbxproj">trunk/Tools/LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkToolsLayoutTestRelayLayoutTestRelayCoreSimulatorSPIh">trunk/Tools/LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (185477 => 185478)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-06-11 21:49:49 UTC (rev 185477)
+++ trunk/Tools/ChangeLog 2015-06-11 22:30:52 UTC (rev 185478)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-06-11 Daniel Bates <dabates@apple.com>
+
+ [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
+ https://bugs.webkit.org/show_bug.cgi?id=145319
+
+ Reviewed by David Kilzer.
+
+ Add SPI wrapper header for CoreSimulator and update the source files to reference
+ it instead of directly referencing the CoreSimulator header.
+
+ * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
+ * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
+ * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
+ * LayoutTestRelay/LayoutTestRelay/main.m:
+
</ins><span class="cx"> 2015-06-10 KwangHyuk Kim <hyuki.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL] dimmed area for popup does not cover the fullscreen mode.
</span></span></pre></div>
<a id="trunkToolsLayoutTestRelayLayoutTestRelayCoreSimulatorSPIh"></a>
<div class="addfile"><h4>Added: trunk/Tools/LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h (0 => 185478)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h (rev 0)
+++ trunk/Tools/LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h 2015-06-11 22:30:52 UTC (rev 185478)
</span><span class="lines">@@ -0,0 +1,66 @@
</span><ins>+/*
+ * Copyright (C) 2015 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#if __has_include(<CoreSimulator/CoreSimulator.h>)
+
+#import <CoreSimulator/CoreSimulator.h>
+
+#else
+
+#import <Foundation/Foundation.h>
+
+#define kSimDeviceLaunchApplicationArguments @"arguments"
+#define kSimDeviceLaunchApplicationEnvironment @"environment"
+
+typedef NS_ENUM(NSUInteger, SimDeviceState) {
+ SimDeviceStateCreating = 0,
+};
+
+@interface SimDeviceType : NSObject
++ (NSDictionary *)supportedDeviceTypesByIdentifier;
+@property (readonly, copy) NSString *identifier;
+@end
+
+@interface SimRuntime : NSObject
++ (NSDictionary *)supportedRuntimesByIdentifier;
+@end
+
+@interface SimDevice : NSObject
+- (BOOL)installApplication:(NSURL *)installURL withOptions:(NSDictionary *)options error:(NSError **)error;
+- (pid_t)launchApplicationWithID:(NSString *)bundleID options:(NSDictionary *)options error:(NSError **)error;
+@property (readonly, retain) SimDeviceType *deviceType;
+@property (readonly, retain) SimRuntime *runtime;
+@property (readonly, assign) SimDeviceState state;
+@property (readonly, copy) NSString *name;
+@end
+
+@interface SimDeviceSet : NSObject
++ (SimDeviceSet *)defaultSet;
+- (SimDevice *)createDeviceWithType:(SimDeviceType *)deviceType runtime:(SimRuntime *)runtime name:(NSString *)name error:(NSError **)error;
+@property (readonly, copy) NSArray *devices;
+
+@end
+
+#endif
</ins></span></pre></div>
<a id="trunkToolsLayoutTestRelayLayoutTestRelayLTRelayControllerm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m (185477 => 185478)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m 2015-06-11 21:49:49 UTC (rev 185477)
+++ trunk/Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m 2015-06-11 22:30:52 UTC (rev 185478)
</span><span class="lines">@@ -24,10 +24,10 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #import "LTRelayController.h"
</span><ins>+
+#import "CoreSimulatorSPI.h"
</ins><span class="cx"> #import "LTPipeRelay.h"
</span><del>-
</del><span class="cx"> #import <AppKit/AppKit.h>
</span><del>-#import <CoreSimulator/CoreSimulator.h>
</del><span class="cx">
</span><span class="cx"> @interface LTRelayController ()
</span><span class="cx"> @property (readonly, strong) dispatch_source_t standardInputDispatchSource;
</span></span></pre></div>
<a id="trunkToolsLayoutTestRelayLayoutTestRelaymainm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/LayoutTestRelay/LayoutTestRelay/main.m (185477 => 185478)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/LayoutTestRelay/LayoutTestRelay/main.m 2015-06-11 21:49:49 UTC (rev 185477)
+++ trunk/Tools/LayoutTestRelay/LayoutTestRelay/main.m 2015-06-11 22:30:52 UTC (rev 185478)
</span><span class="lines">@@ -23,9 +23,8 @@
</span><span class="cx"> * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><ins>+#import "CoreSimulatorSPI.h"
</ins><span class="cx"> #import "LTRelayController.h"
</span><del>-
-#import <CoreSimulator/CoreSimulator.h>
</del><span class="cx"> #import <Foundation/Foundation.h>
</span><span class="cx">
</span><span class="cx"> static LTRelayController *relayController;
</span></span></pre></div>
<a id="trunkToolsLayoutTestRelayLayoutTestRelayxcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Tools/LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj (185477 => 185478)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj 2015-06-11 21:49:49 UTC (rev 185477)
+++ trunk/Tools/LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj 2015-06-11 22:30:52 UTC (rev 185478)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> 2E8D3F0319881FE2004F6CC2 /* LTPipeRelay.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = LTPipeRelay.h; sourceTree = "<group>"; };
</span><span class="cx"> 2E8D3F0419882406004F6CC2 /* LTRelayController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LTRelayController.h; sourceTree = "<group>"; };
</span><span class="cx"> 2E8D3F0519882406004F6CC2 /* LTRelayController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = LTRelayController.m; sourceTree = "<group>"; };
</span><ins>+ CE1FBC151B290E79000136F5 /* CoreSimulatorSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CoreSimulatorSPI.h; sourceTree = "<group>"; };
</ins><span class="cx"> /* End PBXFileReference section */
</span><span class="cx">
</span><span class="cx"> /* Begin PBXFrameworksBuildPhase section */
</span><span class="lines">@@ -69,6 +70,7 @@
</span><span class="cx"> isa = PBXGroup;
</span><span class="cx"> children = (
</span><span class="cx"> 2E8D3EF719881D43004F6CC2 /* main.m */,
</span><ins>+ CE1FBC151B290E79000136F5 /* CoreSimulatorSPI.h */,
</ins><span class="cx"> 2E8D3F0019881F29004F6CC2 /* LTRelay.h */,
</span><span class="cx"> 2E8D3F0119881FD0004F6CC2 /* LTPipeRelay.m */,
</span><span class="cx"> 2E8D3F0319881FE2004F6CC2 /* LTPipeRelay.h */,
</span></span></pre>
</div>
</div>
</body>
</html>