<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185481] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185481">185481</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-06-11 17:21:01 -0700 (Thu, 11 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/185470">r185470</a>.
https://bugs.webkit.org/show_bug.cgi?id=145902
Caused ASan violations (Requested by ap on #webkit).
Reverted changeset:
"Add an appearance keyword for wireless playback / airplay
icon"
https://bugs.webkit.org/show_bug.cgi?id=145892
http://trac.webkit.org/changeset/185470</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValueMappingsh">trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSValueKeywordsin">trunk/Source/WebCore/css/CSSValueKeywords.in</a></li>
<li><a href="#trunkSourceWebCoreplatformThemeTypesh">trunk/Source/WebCore/platform/ThemeTypes.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemecpp">trunk/Source/WebCore/rendering/RenderTheme.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeh">trunk/Source/WebCore/rendering/RenderTheme.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMach">trunk/Source/WebCore/rendering/RenderThemeMac.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMacmm">trunk/Source/WebCore/rendering/RenderThemeMac.mm</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssappearanceairplayexpectedtxt">trunk/LayoutTests/fast/css/appearance-airplay-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssappearanceairplayhtml">trunk/LayoutTests/fast/css/appearance-airplay.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/LayoutTests/ChangeLog 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-06-11 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r185470.
+ https://bugs.webkit.org/show_bug.cgi?id=145902
+
+ Caused ASan violations (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Add an appearance keyword for wireless playback / airplay
+ icon"
+ https://bugs.webkit.org/show_bug.cgi?id=145892
+ http://trac.webkit.org/changeset/185470
+
</ins><span class="cx"> 2015-06-11 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IndexedDB onupgradeneeded event has incorrect value for oldVersion.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssappearanceairplayexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/appearance-airplay-expected.txt (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/appearance-airplay-expected.txt 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/LayoutTests/fast/css/appearance-airplay-expected.txt 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-Test the -apple-airplay appearance keyword value.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS filterStyle is '-apple-airplay'
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastcssappearanceairplayhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/appearance-airplay.html (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/appearance-airplay.html 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/LayoutTests/fast/css/appearance-airplay.html 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -1,28 +0,0 @@
</span><del>-<!DOCTYPE>
-<html>
-<head>
-<script src="../../resources/js-test-pre.js"></script>
-<style>
-#target {
- -webkit-appearance: -apple-airplay;
-}
-</style>
-</head>
-<body>
-<div id="target"></div>
-<p id="description"></p>
-<div id="console"></div>
-<script>
-
-description("Test the -apple-airplay appearance keyword value.");
-
-var target = document.getElementById("target");
-var filterStyle = window.getComputedStyle(target).getPropertyValue('-webkit-appearance');
-shouldBe('filterStyle', "'-apple-airplay'");
-
-successfullyParsed = true;
-
-</script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/ChangeLog 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-06-11 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r185470.
+ https://bugs.webkit.org/show_bug.cgi?id=145902
+
+ Caused ASan violations (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Add an appearance keyword for wireless playback / airplay
+ icon"
+ https://bugs.webkit.org/show_bug.cgi?id=145892
+ http://trac.webkit.org/changeset/185470
+
</ins><span class="cx"> 2015-06-11 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IndexedDB onupgradeneeded event has incorrect value for oldVersion.
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -12830,11 +12830,7 @@
</span><span class="cx"> // This makes the string one character longer.
</span><span class="cx"> // On iOS we don't want to change values starting with -apple-system to -webkit-system.
</span><span class="cx"> // FIXME: Remove this mangling without breaking the web.
</span><del>- // FIXME: The better way to do this would be to mark up CSSValueKeywords.in with
- // commands that indicate if the keyword should support a translation.
- // https://bugs.webkit.org/show_bug.cgi?id=145883
-
- if ((hasPrefix(buffer, length, "-apple-") && !hasPrefix(buffer, length, "-apple-system") && memcmp(buffer, "-apple-airplay", length)) || hasPrefix(buffer, length, "-khtml-")) {
</del><ins>+ if ((hasPrefix(buffer, length, "-apple-") && !hasPrefix(buffer, length, "-apple-system")) || hasPrefix(buffer, length, "-khtml-")) {
</ins><span class="cx"> memmove(buffer + 7, buffer + 6, length + 1 - 6);
</span><span class="cx"> memcpy(buffer, "-webkit", 7);
</span><span class="cx"> ++length;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValueMappingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -616,9 +616,6 @@
</span><span class="cx"> m_value.valueID = CSSValueImageControlsButton;
</span><span class="cx"> break;
</span><span class="cx"> #endif
</span><del>- case WirelessPlaybackIconPart:
- m_value.valueID = CSSValueAppleAirplay;
- break;
</del><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValueKeywordsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValueKeywords.in 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -760,7 +760,6 @@
</span><span class="cx"> continuous-capacity-level-indicator
</span><span class="cx"> discrete-capacity-level-indicator
</span><span class="cx"> rating-level-indicator
</span><del>--apple-airplay
</del><span class="cx"> #if defined(ENABLE_SERVICE_CONTROLS) && ENABLE_SERVICE_CONTROLS
</span><span class="cx"> image-controls-button
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformThemeTypesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ThemeTypes.h (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ThemeTypes.h 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/platform/ThemeTypes.h 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -46,7 +46,6 @@
</span><span class="cx"> SearchFieldResultsDecorationPart, SearchFieldResultsButtonPart,
</span><span class="cx"> SearchFieldCancelButtonPart, SnapshottedPluginOverlayPart, TextFieldPart,
</span><span class="cx"> RelevancyLevelIndicatorPart, ContinuousCapacityLevelIndicatorPart, DiscreteCapacityLevelIndicatorPart, RatingLevelIndicatorPart,
</span><del>- WirelessPlaybackIconPart,
</del><span class="cx"> #if ENABLE(SERVICE_CONTROLS)
</span><span class="cx"> ImageControlsButtonPart,
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -257,8 +257,6 @@
</span><span class="cx"> case AttachmentPart:
</span><span class="cx"> return adjustAttachmentStyle(styleResolver, style, element);
</span><span class="cx"> #endif
</span><del>- case WirelessPlaybackIconPart:
- return adjustWirelessPlaybackIconStyle(styleResolver, style, element);
</del><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -401,8 +399,6 @@
</span><span class="cx"> case AttachmentPart:
</span><span class="cx"> return paintAttachment(o, paintInfo, integralSnappedRect);
</span><span class="cx"> #endif
</span><del>- case WirelessPlaybackIconPart:
- return paintWirelessPlaybackIcon(o, paintInfo, integralSnappedRect);
</del><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -999,15 +995,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void RenderTheme::adjustWirelessPlaybackIconStyle(StyleResolver&, RenderStyle&, Element*) const
-{
-}
-
-bool RenderTheme::paintWirelessPlaybackIcon(const RenderObject&, const PaintInfo&, const IntRect&)
-{
- return false;
-}
-
</del><span class="cx"> #if ENABLE(DATALIST_ELEMENT)
</span><span class="cx"> LayoutUnit RenderTheme::sliderTickSnappingThreshold() const
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.h (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.h 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -326,9 +326,6 @@
</span><span class="cx"> virtual bool paintAttachment(const RenderObject&, const PaintInfo&, const IntRect&);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- virtual void adjustWirelessPlaybackIconStyle(StyleResolver&, RenderStyle&, Element*) const;
- virtual bool paintWirelessPlaybackIcon(const RenderObject&, const PaintInfo&, const IntRect&);
-
</del><span class="cx"> virtual void adjustProgressBarStyle(StyleResolver&, RenderStyle&, Element*) const;
</span><span class="cx"> virtual bool paintProgressBar(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMach"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.h (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.h 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.h 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -173,9 +173,6 @@
</span><span class="cx"> virtual bool paintAttachment(const RenderObject&, const PaintInfo&, const IntRect&) override;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- virtual void adjustWirelessPlaybackIconStyle(StyleResolver&, RenderStyle&, Element*) const override;
- virtual bool paintWirelessPlaybackIcon(const RenderObject&, const PaintInfo&, const IntRect&) override;
-
</del><span class="cx"> private:
</span><span class="cx"> virtual String fileListNameForWidth(const FileList*, const FontCascade&, int width, bool multipleFilesAllowed) const override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (185480 => 185481)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-06-12 00:17:32 UTC (rev 185480)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-06-12 00:21:01 UTC (rev 185481)
</span><span class="lines">@@ -2613,15 +2613,6 @@
</span><span class="cx">
</span><span class="cx"> #endif // ENABLE(ATTACHMENT_ELEMENT)
</span><span class="cx">
</span><del>-void RenderThemeMac::adjustWirelessPlaybackIconStyle(StyleResolver&, RenderStyle&, Element*) const
-{
-}
-
-bool RenderThemeMac::paintWirelessPlaybackIcon(const RenderObject&, const PaintInfo&, const IntRect&)
-{
- return false;
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // !PLATFORM(IOS)
</span></span></pre>
</div>
</div>
</body>
</html>