<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185285] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185285">185285</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-06-05 21:40:18 -0700 (Fri, 05 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>From <a href="http://trac.webkit.org/projects/webkit/changeset/185273">r185273</a> on WTF::RefCounter exposes the actual refcount instead of a boolean value.
Reviewed by Dan Bernstein.
* TestWebKitAPI/Tests/WTF/RefCounter.cpp:
(TestWebKitAPI::TEST):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFRefCountercpp">trunk/Tools/TestWebKitAPI/Tests/WTF/RefCounter.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (185284 => 185285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-06-06 03:11:28 UTC (rev 185284)
+++ trunk/Tools/ChangeLog 2015-06-06 04:40:18 UTC (rev 185285)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-06-05 Zalan Bujtas <zalan@apple.com>
+
+ From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
+
+ Reviewed by Dan Bernstein.
+
+ * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
+ (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2015-06-05 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> [EFL] API test has been broken since r184357
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFRefCountercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/RefCounter.cpp (185284 => 185285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/RefCounter.cpp 2015-06-06 03:11:28 UTC (rev 185284)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/RefCounter.cpp 2015-06-06 04:40:18 UTC (rev 185285)
</span><span class="lines">@@ -88,47 +88,47 @@
</span><span class="cx"> });
</span><span class="cx"> counterPtr = &counter;
</span><span class="cx"> // Testing (4a) - after construction value() is 0.
</span><del>- EXPECT_EQ(false, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(0, static_cast<int>(counter.value()));
</ins><span class="cx">
</span><span class="cx"> // Testing (3a) - ref with callback from 0 -> 1.
</span><span class="cx"> callbackValue = CallbackExpected;
</span><span class="cx"> TokenType incTo1(counter.token<CounterType>());
</span><span class="cx"> // Testing (4b) & (4c) - values within & after callback.
</span><span class="cx"> EXPECT_EQ(true, callbackValue);
</span><del>- EXPECT_EQ(true, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(1, static_cast<int>(counter.value()));
</ins><span class="cx">
</span><span class="cx"> // Testing (3b) - ref with callback from 1 -> 2.
</span><span class="cx"> TokenType incTo2(incTo1);
</span><span class="cx"> // Testing (4b) & (4c) - values within & after callback.
</span><del>- EXPECT_EQ(true, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(2, static_cast<int>(counter.value()));
</ins><span class="cx">
</span><span class="cx"> // Testing (3c) - deref with callback from >1 -> 1.
</span><span class="cx"> incTo1 = nullptr;
</span><span class="cx"> // Testing (4b) & (4c) - values within & after callback.
</span><del>- EXPECT_EQ(true, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(1, static_cast<int>(counter.value()));
</ins><span class="cx">
</span><span class="cx"> {
</span><span class="cx"> // Testing (3j) - ref using a Ref rather than a RefPtr.
</span><span class="cx"> TokenType incTo2Again(counter.token<CounterType>());
</span><span class="cx"> // Testing (4b) & (4c) - values within & after callback.
</span><del>- EXPECT_EQ(true, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(2, static_cast<int>(counter.value()));
</ins><span class="cx"> // Testing (3k) - deref using a Ref rather than a RefPtr.
</span><span class="cx"> }
</span><del>- EXPECT_EQ(true, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(1, static_cast<int>(counter.value()));
</ins><span class="cx"> // Testing (4b) & (4c) - values within & after callback.
</span><span class="cx">
</span><span class="cx"> // Testing (3d) - deref with callback from 1 -> 0.
</span><span class="cx"> callbackValue = CallbackExpected;
</span><span class="cx"> incTo2 = nullptr;
</span><span class="cx"> // Testing (4b) & (4c) - values within & after callback.
</span><del>- EXPECT_EQ(false, callbackValue);
- EXPECT_EQ(false, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(0, callbackValue);
+ EXPECT_EQ(0, static_cast<int>(counter.value()));
</ins><span class="cx">
</span><span class="cx"> // Testing (2a) - Destruction where the RefCounter::Count has a non-zero reference count.
</span><span class="cx"> callbackValue = CallbackExpected;
</span><span class="cx"> incTo1Again = counter.token<CounterType>();
</span><del>- EXPECT_EQ(true, callbackValue);
- EXPECT_EQ(true, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(1, callbackValue);
+ EXPECT_EQ(1, static_cast<int>(counter.value()));
</ins><span class="cx"> callbackValue = CallbackNotExpected;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -142,15 +142,15 @@
</span><span class="cx"> // Testing (1b) - Construction without a callback.
</span><span class="cx"> RefCounter counter;
</span><span class="cx"> // Testing (4a) - after construction value() is 0.
</span><del>- EXPECT_EQ(false, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(0, static_cast<int>(counter.value()));
</ins><span class="cx"> // Testing (3h) - ref without callback
</span><span class="cx"> TokenType incTo1(counter.token<CounterType>());
</span><span class="cx"> // Testing (4c) - value as read after the ref.
</span><del>- EXPECT_EQ(true, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(1, static_cast<int>(counter.value()));
</ins><span class="cx"> // Testing (3i) - deref without callback
</span><span class="cx"> incTo1 = nullptr;
</span><span class="cx"> // Testing (4c) - value as read after the deref.
</span><del>- EXPECT_EQ(false, static_cast<int>(counter.value()));
</del><ins>+ EXPECT_EQ(0, static_cast<int>(counter.value()));
</ins><span class="cx"> // Testing (2b) - Destruction where the RefCounter::Count has a zero reference count.
</span><span class="cx"> // ... not a lot to test here! - we can at least ensure this code path is run & we don't crash!
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>