<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185255] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185255">185255</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2015-06-05 11:11:32 -0700 (Fri, 05 Jun 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
https://bugs.webkit.org/show_bug.cgi?id=145671

Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
&quot;Idle&quot; string no longer used.

* UserInterface/Views/TimelineRecordFrame.js:
Reduced maximum frame width by 2px.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
Added inner radius to chart and removed &quot;Idle&quot; value.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordFramejs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (185254 => 185255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/ChangeLog        2015-06-05 18:11:32 UTC (rev 185255)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-06-05  Matt Baker  &lt;mattbaker@apple.com&gt;
+
+        Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
+        https://bugs.webkit.org/show_bug.cgi?id=145671
+
+        Reviewed by Timothy Hatcher.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        &quot;Idle&quot; string no longer used.
+
+        * UserInterface/Views/TimelineRecordFrame.js:
+        Reduced maximum frame width by 2px.
+
+        * UserInterface/Views/TimelineSidebarPanel.js:
+        (WebInspector.TimelineSidebarPanel):
+        (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
+        Added inner radius to chart and removed &quot;Idle&quot; value.
+
</ins><span class="cx"> 2015-06-04  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: Class constructor appearing as Object Tree property does not include parameters
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (185254 => 185255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2015-06-05 18:11:32 UTC (rev 185255)
</span><span class="lines">@@ -259,7 +259,6 @@
</span><span class="cx"> localizedStrings[&quot;Icon and Text (Horizontal)&quot;] = &quot;Icon and Text (Horizontal)&quot;;
</span><span class="cx"> localizedStrings[&quot;Icon and Text (Vertical)&quot;] = &quot;Icon and Text (Vertical)&quot;;
</span><span class="cx"> localizedStrings[&quot;Identity&quot;] = &quot;Identity&quot;;
</span><del>-localizedStrings[&quot;Idle&quot;] = &quot;Idle&quot;;
</del><span class="cx"> localizedStrings[&quot;Ignored&quot;] = &quot;Ignored&quot;;
</span><span class="cx"> localizedStrings[&quot;Image&quot;] = &quot;Image&quot;;
</span><span class="cx"> localizedStrings[&quot;Image Size&quot;] = &quot;Image Size&quot;;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordFramejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js (185254 => 185255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js        2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js        2015-06-05 18:11:32 UTC (rev 185255)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> // FIXME: Move to a WebInspector.Object subclass and we can remove this.
</span><span class="cx"> WebInspector.Object.deprecatedAddConstructorFunctions(WebInspector.TimelineRecordFrame);
</span><span class="cx"> 
</span><del>-WebInspector.TimelineRecordFrame.MaximumWidthPixels = 16;
</del><ins>+WebInspector.TimelineRecordFrame.MaximumWidthPixels = 14;
</ins><span class="cx"> WebInspector.TimelineRecordFrame.MinimumWidthPixels = 4;
</span><span class="cx"> 
</span><span class="cx"> WebInspector.TimelineRecordFrame.prototype = {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (185254 => 185255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js        2015-06-05 18:09:58 UTC (rev 185254)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js        2015-06-05 18:11:32 UTC (rev 185255)
</span><span class="lines">@@ -82,11 +82,11 @@
</span><span class="cx">             this._chartColors = {
</span><span class="cx">                 layout: &quot;rgb(212, 108, 108)&quot;,
</span><span class="cx">                 script: &quot;rgb(153, 113, 185)&quot;,
</span><del>-                other: &quot;rgb(221, 221, 221)&quot;,
-                idle: &quot;rgb(255, 255, 255)&quot;
</del><ins>+                other: &quot;rgb(221, 221, 221)&quot;
</ins><span class="cx">             };
</span><span class="cx"> 
</span><span class="cx">             this._frameSelectionChartRow = new WebInspector.ChartDetailsSectionRow(this);
</span><ins>+            this._frameSelectionChartRow.innerRadius = 0.5;
</ins><span class="cx"> 
</span><span class="cx">             var chartGroup = new WebInspector.DetailsSectionGroup([this._frameSelectionChartRow]);
</span><span class="cx">             this._frameSelectionChartSection = new WebInspector.DetailsSection(&quot;frames-selection-chart&quot;, WebInspector.UIString(&quot;Selected Frames&quot;), [chartGroup], null, true);
</span><span class="lines">@@ -793,8 +793,7 @@
</span><span class="cx">             this._frameSelectionChartRow.data = [
</span><span class="cx">                 {label: WebInspector.UIString(&quot;Layout&quot;), value: 0, color: this._chartColors.layout},
</span><span class="cx">                 {label: WebInspector.UIString(&quot;Script&quot;), value: 0, color: this._chartColors.script},
</span><del>-                {label: WebInspector.UIString(&quot;Other&quot;), value: 0, color: this._chartColors.other},
-                {label: WebInspector.UIString(&quot;Idle&quot;), value: 0, color: this._chartColors.idle}
</del><ins>+                {label: WebInspector.UIString(&quot;Other&quot;), value: 0, color: this._chartColors.other}
</ins><span class="cx">             ];
</span><span class="cx">             return;
</span><span class="cx">         }
</span><span class="lines">@@ -821,13 +820,11 @@
</span><span class="cx">         var layoutTime = durationForRecordType(WebInspector.TimelineRecord.Type.Layout);
</span><span class="cx">         var scriptTime = durationForRecordType(WebInspector.TimelineRecord.Type.Script);
</span><span class="cx">         var otherTime = durationForRecordType();
</span><del>-        var idleTime = totalTime - layoutTime - scriptTime - otherTime;
</del><span class="cx"> 
</span><span class="cx">         this._frameSelectionChartRow.data = [
</span><span class="cx">             {label: WebInspector.UIString(&quot;Layout&quot;), value: layoutTime, color: this._chartColors.layout},
</span><span class="cx">             {label: WebInspector.UIString(&quot;Script&quot;), value: scriptTime, color: this._chartColors.script},
</span><del>-            {label: WebInspector.UIString(&quot;Other&quot;), value: otherTime, color: this._chartColors.other},
-            {label: WebInspector.UIString(&quot;Idle&quot;), value: idleTime, color: this._chartColors.idle}
</del><ins>+            {label: WebInspector.UIString(&quot;Other&quot;), value: otherTime, color: this._chartColors.other}
</ins><span class="cx">         ];
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>