<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185193] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185193">185193</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-06-03 23:45:47 -0700 (Wed, 03 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Added a patch so that the colors displayed on the page could be toggled
in case people need accessibility colors displayed in their browser.
https://bugs.webkit.org/show_bug.cgi?id=145570
<rdar://problem/20994468>
Added in CSS colors and toggle buttons for checkmarks in the page, so that
the page could be rendered in a specific way for accessibility needs if needed.
Patch by Matthew Daiter <mdaiter@apple.com> on 2015-06-03
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(updateHiddenPlatforms):
(applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
(toggleAccessibilityColors): Toggle colors on and off
(documentReady): Needed to make changes to the initialization
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(a:hover):
(div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
(div.cellButton.hide, div.accessibilityButton.hide):
(div.cellButton.unhide, div.accessibilityButton.unhide):
(.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
(.popover-tracking:hover):
(.accessibilityButton):
(div.cellButton): Deleted.
(div.cellButton.hide): Deleted.
(div.cellButton.unhide): Deleted.
(.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line.neutral .bubble):
(.status-line.unauthorized .bubble):
(.status-line.danger .bubble.pictogram):
(.status-line.bad .bubble.pictogram):
(.status-line.no-bubble .message):
(.status-line.bad .bubble):
(.status-line.good .bubble):
(.status-line.good .message):
(.status-line.bad .message):
(body.accessibility-colors .status-line.good .bubble):
(body.accessibility-colors .status-line.bad .bubble):
(body.accessibility-colors .status-line.good .message):
(body.accessibility-colors .status-line.bad .message):
(.status-line.danger .message):
(.status-line.unauthorized .message):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMaincss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesStatusLineViewcss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (185192 => 185193)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-06-04 06:45:47 UTC (rev 185193)
</span><span class="lines">@@ -136,6 +136,32 @@
</span><span class="cx"> unhideButton.classList.add("hidden");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function applyAccessibilityColorSetting()
+{
+ var useAccessibleColors = settings.getObject("accessibilityColorsEnabled");
+ var toggleAccessibilityColorButton = document.getElementById("accessibilityButton");
+ if (useAccessibleColors) {
+ toggleAccessibilityColorButton.textContent = "disable accessibility colors";
+ document.body.classList.toggle("accessibility-colors");
+ } else
+ toggleAccessibilityColorButton.textContent = "enable accessibility colors";
+}
+
+function toggleAccessibilityColors()
+{
+ var isCurrentlyActivated = settings.getObject("accessibilityColorsEnabled");
+ if (isCurrentlyActivated === undefined)
+ isCurrentlyActivated = false;
+
+ settings.setObject("accessibilityColorsEnabled", !isCurrentlyActivated);
+ document.body.classList.toggle("accessibility-colors");
+ var toggleAccessibilityColorButton = document.getElementById("accessibilityButton");
+ if (!isCurrentlyActivated)
+ toggleAccessibilityColorButton.textContent = "disable accessibility colors";
+ else
+ toggleAccessibilityColorButton.textContent = "enable accessibility colors";
+}
+
</ins><span class="cx"> function documentReady()
</span><span class="cx"> {
</span><span class="cx"> var table = document.createElement("table");
</span><span class="lines">@@ -144,11 +170,12 @@
</span><span class="cx"> var row = document.createElement("tr");
</span><span class="cx"> row.classList.add("headers");
</span><span class="cx">
</span><del>- var header = document.createElement("th");
</del><ins>+ var header = document.createElement("th");
</ins><span class="cx"> var unhideButton = document.createElement("div");
</span><span class="cx"> unhideButton.addEventListener("click", function () { settings.clearHiddenPlatforms(); });
</span><span class="cx"> unhideButton.textContent = "Show All Platforms";
</span><span class="cx"> unhideButton.classList.add("cellButton", "unhide", "hidden");
</span><ins>+
</ins><span class="cx"> header.appendChild(unhideButton);
</span><span class="cx"> row.appendChild(header);
</span><span class="cx">
</span><span class="lines">@@ -260,6 +287,14 @@
</span><span class="cx"> settingsButton.classList.add("settings");
</span><span class="cx"> document.body.appendChild(settingsButton);
</span><span class="cx">
</span><ins>+ var toggleAccessibilityColorButton = document.createElement("div");
+ toggleAccessibilityColorButton.addEventListener("click", function() { toggleAccessibilityColors(); });
+ toggleAccessibilityColorButton.setAttribute("class", "unhide hidden accessibilityButton");
+ toggleAccessibilityColorButton.setAttribute("id", "accessibilityButton");
+ toggleAccessibilityColorButton.textContent = "enable accessibility colors";
+ document.body.appendChild(toggleAccessibilityColorButton);
+ applyAccessibilityColorSetting();
+
</ins><span class="cx"> updateHiddenPlatforms();
</span><span class="cx"> settings.addSettingListener("hiddenPlatforms", updateHiddenPlatforms);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMaincss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (185192 => 185193)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2015-06-04 06:45:47 UTC (rev 185193)
</span><span class="lines">@@ -42,25 +42,26 @@
</span><span class="cx"> text-decoration: underline;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-div.cellButton {
</del><ins>+div.cellButton, div.accessibilityButton {
</ins><span class="cx"> font-family: "HelveticaNeue-Light", sans-serif;
</span><span class="cx"> font-size: 12px;
</span><span class="cx"> color: rgb(185, 175, 125);
</span><span class="cx"> cursor: pointer;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-div.cellButton.hide {
</del><ins>+div.cellButton.hide, div.accessibilityButton.hide {
</ins><span class="cx"> display: none;
</span><span class="cx"> position: absolute;
</span><span class="cx"> bottom: 2px;
</span><span class="cx"> right: 4px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-div.cellButton.unhide {
</del><ins>+div.cellButton.unhide, div.accessibilityButton.unhide {
</ins><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide {
</del><ins>+.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide,
+.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide {
</ins><span class="cx"> display: block;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -200,3 +201,9 @@
</span><span class="cx"> .popover-tracking:hover {
</span><span class="cx"> text-shadow: 0px 0px 3px rgba(0, 0, 0, 0.2)
</span><span class="cx"> }
</span><ins>+
+.accessibilityButton {
+ position: absolute;
+ left: 45px;
+ top: 13.5px;
+}
</ins></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesStatusLineViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css (185192 => 185193)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2015-06-04 06:45:47 UTC (rev 185193)
</span><span class="lines">@@ -50,10 +50,6 @@
</span><span class="cx"> background-color: rgb(181, 174, 148);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.status-line.good .bubble {
- background-color: rgb(50, 219, 72);
-}
-
</del><span class="cx"> .status-line.unauthorized .bubble {
</span><span class="cx"> background-color: rgb(171, 61, 171);
</span><span class="cx"> }
</span><span class="lines">@@ -80,10 +76,6 @@
</span><span class="cx"> font-weight: bold;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.status-line.bad .bubble {
- background-color: rgb(196, 49, 49);
-}
-
</del><span class="cx"> .status-line.bad .bubble.pictogram {
</span><span class="cx"> font-family: "Menlo-Bold", sans-serif;
</span><span class="cx"> font-size: 23px;
</span><span class="lines">@@ -129,21 +121,47 @@
</span><span class="cx"> color: rgb(145, 135, 95);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.status-line.bad .bubble {
+ background-color: rgb(191, 67, 41);
+}
+
+.status-line.good .bubble {
+ background-color: rgb(76, 151, 61);
+}
+
</ins><span class="cx"> .status-line.good .label,
</span><span class="cx"> .status-line.good .message {
</span><ins>+ color: rgb(76, 151, 61);
+}
+
+.status-line.bad .label,
+.status-line.bad .message {
+ color: rgb(191, 67, 41);
+}
+
+body.accessibility-colors .status-line.good .bubble {
+ background-color: rgb(50, 219, 72);
+}
+
+body.accessibility-colors .status-line.bad .bubble {
+ background-color: rgb(196, 49, 49);
+}
+
+body.accessibility-colors .status-line.good .label,
+body.accessibility-colors .status-line.good .message {
</ins><span class="cx"> color: rgb(40, 177, 58);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body.accessibility-colors .status-line.bad .label,
+body.accessibility-colors .status-line.bad .message {
+ color: rgb(191, 67, 41);
+}
+
</ins><span class="cx"> .status-line.danger .label,
</span><span class="cx"> .status-line.danger .message {
</span><span class="cx"> color: rgb(230, 175, 44);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.status-line.bad .label,
-.status-line.bad .message {
- color: rgb(191, 67, 41);
-}
-
</del><span class="cx"> .status-line.unauthorized .label,
</span><span class="cx"> .status-line.unauthorized .message {
</span><span class="cx"> color: rgb(171, 61, 171);
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (185192 => 185193)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/ChangeLog 2015-06-04 06:45:47 UTC (rev 185193)
</span><span class="lines">@@ -1,3 +1,49 @@
</span><ins>+2015-06-03 Matthew Daiter <mdaiter@apple.com>
+
+ Added a patch so that the colors displayed on the page could be toggled
+ in case people need accessibility colors displayed in their browser.
+ https://bugs.webkit.org/show_bug.cgi?id=145570
+ <rdar://problem/20994468>
+
+ Added in CSS colors and toggle buttons for checkmarks in the page, so that
+ the page could be rendered in a specific way for accessibility needs if needed.
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+ (updateHiddenPlatforms):
+ (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
+ (toggleAccessibilityColors): Toggle colors on and off
+ (documentReady): Needed to make changes to the initialization
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ (a:hover):
+ (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
+ (div.cellButton.hide, div.accessibilityButton.hide):
+ (div.cellButton.unhide, div.accessibilityButton.unhide):
+ (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
+ (.popover-tracking:hover):
+ (.accessibilityButton):
+ (div.cellButton): Deleted.
+ (div.cellButton.hide): Deleted.
+ (div.cellButton.unhide): Deleted.
+ (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
+ (.status-line.neutral .bubble):
+ (.status-line.unauthorized .bubble):
+ (.status-line.danger .bubble.pictogram):
+ (.status-line.bad .bubble.pictogram):
+ (.status-line.no-bubble .message):
+ (.status-line.bad .bubble):
+ (.status-line.good .bubble):
+ (.status-line.good .message):
+ (.status-line.bad .message):
+ (body.accessibility-colors .status-line.good .bubble):
+ (body.accessibility-colors .status-line.bad .bubble):
+ (body.accessibility-colors .status-line.good .message):
+ (body.accessibility-colors .status-line.bad .message):
+ (.status-line.danger .message):
+ (.status-line.unauthorized .message):
+
</ins><span class="cx"> 2015-06-03 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed build fix for Dromaeo.
</span></span></pre>
</div>
</div>
</body>
</html>